averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[devirtualization] Properly substitute in types for upcast when handling

Browse Source 
a specialized inherited conformance.

Swift SVN r16900
This commit is contained in:
Michael Gottesman
2014-04-27 00:06:46 +00:00
parent 2aa3e50343
commit e2cde3c7f4
5 changed files with 167 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
lib/AST/ProtocolConformance.cpp
View File

@@ -87,34 +87,51 @@ bool ProtocolConformance::usesDefaultDefinition(ValueDecl *requirement) const {
CONFORMANCE_SUBCLASS_DISPATCH(usesDefaultDefinition, (requirement))
}
GenericParamList *ProtocolConformance::getGenericParams() const {
switch (getKind()) {
case ProtocolConformanceKind::Normal: {
// FIXME: This should be an independent property of the conformance.
// Assuming a BoundGenericType conformance is always for the
// DeclaredTypeInContext is unsound if we ever add constrained extensions.
Type ty = getType();
while (ty) {
if (auto nt = ty->getAs<NominalType>())
ty = nt->getParent();
else
break;
}
if (!ty)
return nullptr;
if (auto bgt = ty->getAs<BoundGenericType>()) {
auto decl = bgt->getDecl();
assert(bgt->isEqual(decl->getDeclaredTypeInContext())
&& "conformance for constrained generic type not implemented");
return decl->getGenericParams();
}
/// FIXME: This should be an independent property of the conformance.
/// Assuming a BoundGenericType conformance is always for the
/// DeclaredTypeInContext is unsound if we ever add constrained extensions.
static GenericParamList *genericParamListForType(Type ty) {
while (ty) {
if (auto nt = ty->getAs<NominalType>())
ty = nt->getParent();
else
break;
}
if (!ty)
return nullptr;
if (auto bgt = ty->getAs<BoundGenericType>()) {
auto decl = bgt->getDecl();
assert(bgt->isEqual(decl->getDeclaredTypeInContext()) &&
"conformance for constrained generic type not implemented");
return decl->getGenericParams();
}
return nullptr;
}
GenericParamList *ProtocolConformance::getGenericParams() const {
const ProtocolConformance *C = this;
switch (getKind()) {
case ProtocolConformanceKind::Inherited: {
// Look through all the inherited layers and then fall through to the
// normal.
do {
C = cast<InheritedProtocolConformance>(C)->getInheritedConformance();
} while (C->getKind() == ProtocolConformanceKind::Inherited);
// We don't handle specialized conformances here so bail.
if (C->getKind() == ProtocolConformanceKind::Specialized)
return nullptr;
// Otherwise we have a normal conformance. Fallthrough.
SWIFT_FALLTHROUGH;
}
case ProtocolConformanceKind::Normal: {
return genericParamListForType(C->getType());
}
case ProtocolConformanceKind::Specialized:
case ProtocolConformanceKind::Inherited:
// FIXME: These could reasonably have open type variables.
// FIXME: This could reasonably have open type variables.
return nullptr;
}
}