averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[stdlib] replace precondition with guard-else-_assertionFailure

Browse Source
This commit is contained in:
Guillaume Lessard
2021-11-04 21:33:32 -06:00
committed by Hassan
parent 1d4f220ed4
commit e87a3e30ca
1 changed files with 40 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
stdlib/public/core/ArrayBuffer.swift
View File

@@ -254,23 +254,29 @@ extension _ArrayBuffer {
internal func _typeCheckSlowPath(_ index: Int) {
if _fastPath(_isNative) {
let element: AnyObject = cast(toBufferOf: AnyObject.self)._native[index]
precondition(
element is Element,
"""
Down-casted Array element failed to match the target type
Expected \(Element.self) but found \(type(of: element))
"""
)
guard element is Element else {
_assertionFailure(
"Fatal error",
"""
Down-casted Array element failed to match the target type
Expected \(Element.self) but found \(type(of: element))
""",
flags: _fatalErrorFlags()
)
}
}
else {
let element = _nonNative[index]
precondition(
element is Element,
"""
NSArray element failed to match the Swift Array Element type
Expected \(Element.self) but found \(type(of: element))
"""
)
guard element is Element else {
_assertionFailure(
"Fatal error",
"""
NSArray element failed to match the Swift Array Element type
Expected \(Element.self) but found \(type(of: element))
""",
flags: _fatalErrorFlags()
)
}
}
}
@@ -505,23 +511,29 @@ extension _ArrayBuffer {
_native._checkValidSubscript(i)
element = cast(toBufferOf: AnyObject.self)._native[i]
precondition(
element is Element,
"""
Down-casted Array element failed to match the target type
Expected \(Element.self) but found \(type(of: element))
"""
)
guard element is Element else {
_assertionFailure(
"Fatal error",
"""
Down-casted Array element failed to match the target type
Expected \(Element.self) but found \(type(of: element))
""",
flags: _fatalErrorFlags()
)
}
} else {
// ObjC arrays do their own subscript checking.
element = _nonNative[i]
precondition(
element is Element,
"""
NSArray element failed to match the Swift Array Element type
Expected \(Element.self) but found \(type(of: element))
"""
)
guard element is Element else {
_assertionFailure(
"Fatal error",
"""
NSArray element failed to match the Swift Array Element type
Expected \(Element.self) but found \(type(of: element))
""",
flags: _fatalErrorFlags()
)
}
}
return element
}