averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SourceKit] Hide RenameRangeDetailCollector as an implementation detail

Browse Source 
The usage becomes a lot clearer if there’s just a top-level function that returns the details for the syntactic rename ranges.
This commit is contained in:
Alex Hoppen
2023-11-06 12:18:38 -08:00
parent a0313e3005
commit ec267e2c08
6 changed files with 101 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Refactoring/ExtractFunction.cpp
View File

@@ -12,7 +12,6 @@
#include "ExtractExprBase.h"
#include "RefactoringActions.h"
#include "RenameRangeDetailCollector.h"
#include "Utils.h"
#include "swift/AST/DiagnosticsRefactoring.h"
#include "swift/IDETool/CompilerInvocation.h"
@@ -109,9 +108,9 @@ static std::vector<NoteRegion> getNotableRegions(StringRef SourceText,
RenameLoc RenameConfig = {LineAndCol.first, LineAndCol.second,
NameUsage::Definition, /*OldName=*/Name,
IsFunctionLike};
RenameRangeDetailCollector Renamer(SM, Name);
Renamer.addSyntacticRenameRanges(Resolved.back(), RenameConfig);
auto Ranges = Renamer.getResult();
std::vector<RenameRangeDetail> Ranges =
getSyntacticRenameRangeDetails(SM, Name, Resolved.back(), RenameConfig)
.Ranges;
std::vector<NoteRegion> NoteRegions(Ranges.size());
llvm::transform(Ranges, NoteRegions.begin(),