averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary 'visitDecl' default cases.

Browse Source 
The default cases are unnecessary and provide no benefits so they should
just be removed.
This commit is contained in:
Mohammad Ghasembeigi
2015-12-06 03:08:08 +11:00
parent 480c9c2993
commit ee2ceca8d1
2 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp
View File

@@ -156,9 +156,6 @@ class UIdentVisitor : public ASTVisitor<UIdentVisitor,
public: public:
explicit UIdentVisitor(bool IsRef) : IsRef(IsRef) { } explicit UIdentVisitor(bool IsRef) : IsRef(IsRef) { }
/// TODO: reconsider whether having a default case is a good idea.
UIdent visitDecl(const Decl *D) { return UIdent(); }
UIdent visitFuncDecl(const FuncDecl *D); UIdent visitFuncDecl(const FuncDecl *D);
UIdent visitVarDecl(const VarDecl *D); UIdent visitVarDecl(const VarDecl *D);
UIdent visitExtensionDecl(const ExtensionDecl *D); UIdent visitExtensionDecl(const ExtensionDecl *D);

4
tools/swift-ide-test/ModuleAPIDiff.cpp
View File

@@ -781,10 +781,6 @@ public:
return Result; return Result;
} }
void visitDecl(Decl *D) {
// FIXME: maybe don't have a default case
}
void visitStructDecl(StructDecl *SD) { void visitStructDecl(StructDecl *SD) {
auto ResultSD = std::make_shared<sma::StructDecl>(); auto ResultSD = std::make_shared<sma::StructDecl>();
ResultSD->Name = convertToIdentifier(SD->getName()); ResultSD->Name = convertToIdentifier(SD->getName());