averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

AST: Remove MakeAbstractConformanceForGenericType

Browse Source 
While the intent behind this functor was noble, it has grown in complexity
considerably over the years, and it seems to be nothing but a source of
crashes in practice. I don't want to deal with it anymore, so I've decided
to just subsume all usages with LookUpConformanceInModule instead.
This commit is contained in:
Slava Pestov
2025-07-15 15:45:26 -04:00
parent a4ad806319
commit ee440f3c91
18 changed files with 27 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/AST/ProtocolConformanceRef.cpp
View File

@@ -118,13 +118,13 @@ ProtocolConformanceRef ProtocolConformanceRef::mapConformanceOutOfContext() cons
if (isConcrete()) {
return getConcrete()->subst(
MapTypeOutOfContext(),
MakeAbstractConformanceForGenericType(),
LookUpConformanceInModule(),
SubstFlags::PreservePackExpansionLevel |
SubstFlags::SubstitutePrimaryArchetypes);
} else if (isPack()) {
return getPack()->subst(
MapTypeOutOfContext(),
MakeAbstractConformanceForGenericType(),
LookUpConformanceInModule(),
SubstFlags::PreservePackExpansionLevel |
SubstFlags::SubstitutePrimaryArchetypes);
} else if (isAbstract()) {