averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[NFC] Added TODO about phi pruning of lifetimes.

Browse Source
This commit is contained in:
Nate Chandler
2021-10-12 16:11:46 -07:00
parent 8af76de85d
commit ee9d309116
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/SILOptimizer/Transforms/SILMem2Reg.cpp
View File

@@ -666,6 +666,11 @@ StoreInst *StackAllocationPromoter::promoteAllocationInBlock(
runningVals = beginLexicalLifetimeAfterStore(asi, si);
// Create a use of the newly created copy in order to keep phi pruning
// from deleting our lifetime beginning instructions.
//
// TODO: Remove this hack, it is only necessary because erasePhiArgument
// calls deleteEdgeValue which calls
// deleteTriviallyDeadOperandsOfDeadArgument and deletes the copy
// and borrow that we added and want not to have deleted.
SILBuilderWithScope::insertAfter(
runningVals->value.copy->getDefiningInstruction(),
[&](auto builder) {