averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[embedded] Specialize superclasses in VTableSpecializer as part of MandatoryPerformanceOptimizations

Browse Source
This commit is contained in:
Kuba Mracek
2024-03-15 21:30:08 -07:00
parent 8a4137ac6c
commit f5797941b7
3 changed files with 80 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
lib/SILOptimizer/Transforms/VTableSpecializer.cpp
View File

@@ -38,7 +38,6 @@ namespace {
class VTableSpecializer : public SILModuleTransform {
bool specializeVTables(SILModule &module);
bool specializeVTablesOfSuperclasses(SILModule &module);
/// The entry point to the transformation.
void run() override {
@@ -59,6 +58,8 @@ static SILFunction *specializeVTableMethod(SILFunction *origMethod,
SILModule &module,
SILTransform *transform);
static bool specializeVTablesOfSuperclasses(SILModule &module, SILTransform *transform);
static bool specializeVTablesInFunction(SILFunction &func, SILModule &module,
SILTransform *transform) {
bool changed = false;
@@ -89,7 +90,7 @@ bool VTableSpecializer::specializeVTables(SILModule &module) {
changed |= specializeVTablesInFunction(func, module, this);
}
changed |= specializeVTablesOfSuperclasses(module);
changed |= specializeVTablesOfSuperclasses(module, this);
for (SILVTable *vtable : module.getVTables()) {
if (vtable->getClass()->isGenericContext()) continue;
@@ -115,24 +116,36 @@ bool VTableSpecializer::specializeVTables(SILModule &module) {
return changed;
}
bool VTableSpecializer::specializeVTablesOfSuperclasses(SILModule &module) {
static bool specializeVTablesOfSuperclasses(SILVTable *vtable,
SILModule &module,
SILTransform *transform) {
if (vtable->getClass()->isGenericContext() && !vtable->getClassType())
return false;
SILType superClassTy;
if (SILType classTy = vtable->getClassType()) {
superClassTy = classTy.getSuperclass();
} else {
if (Type superTy = vtable->getClass()->getSuperclass())
superClassTy =
SILType::getPrimitiveObjectType(superTy->getCanonicalType());
}
if (superClassTy) {
return (specializeVTableForType(superClassTy, module, transform) !=
nullptr);
}
return false;
}
static bool specializeVTablesOfSuperclasses(SILModule &module,
SILTransform *transform) {
bool changed = false;
// The module's vtable table can grow while we are specializing superclass vtables.
// The module's vtable table can grow while we are specializing superclass
// vtables.
for (unsigned i = 0; i < module.getVTables().size(); ++i) {
SILVTable *vtable = module.getVTables()[i];
if (vtable->getClass()->isGenericContext() && !vtable->getClassType())
continue;
SILType superClassTy;
if (SILType classTy = vtable->getClassType()) {
superClassTy = classTy.getSuperclass();
} else {
if (Type superTy = vtable->getClass()->getSuperclass())
superClassTy = SILType::getPrimitiveObjectType(superTy->getCanonicalType());
}
if (superClassTy) {
changed |= (specializeVTableForType(superClassTy, module, this) != nullptr);
}
specializeVTablesOfSuperclasses(vtable, module, transform);
}
return changed;
}
@@ -173,6 +186,9 @@ SILVTable *swift::specializeVTableForType(SILType classTy, SILModule &module,
SILVTable *vtable = SILVTable::create(module, classDecl, classTy,
IsNotSerialized, newEntries);
specializeVTablesOfSuperclasses(vtable, module, transform);
return vtable;
}