averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Excise the terms "blacklist" and "whitelist" from Swift source. (#11687)

Browse Source 
The etymology of these terms isn't about race, but "black" = "blocked"
and "white" = "allowed" isn't really a good look these days. In most
cases we weren't using these terms particularly precisely anyway, so
the rephrasing is actually an improvement.
This commit is contained in:
Jordan Rose
2017-08-30 09:28:00 -07:00
committed by GitHub
parent bac8e202d8
commit f8b7db4e76
27 changed files with 113 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/IDE/Refactoring.cpp
View File

@@ -769,14 +769,15 @@ public:
ExtractCheckResult(ArrayRef<CannotExtractReason> AllReasons):
KnownFailure(false), AllReasons(AllReasons.begin(), AllReasons.end()) {}
bool success() { return success({}); }
bool success(llvm::ArrayRef<CannotExtractReason> WhiteList) {
bool success(llvm::ArrayRef<CannotExtractReason> ExpectedReasons) {
if (KnownFailure)
return false;
bool Result = true;
// Check if any reasons are out of the white list provided by the client.
// Check if any reasons aren't covered by the list of expected reasons
// provided by the client.
for (auto R: AllReasons) {
Result &= llvm::is_contained(WhiteList, R);
Result &= llvm::is_contained(ExpectedReasons, R);
}
return Result;
}
@@ -1739,8 +1740,8 @@ static bool rangeStartMayNeedRename(ResolvedRangeInfo Info) {
return true;
// When callling an instance method inside another instance method,
// we have a dot sytnax call whose dot and base are both implicit. We
// need to whitelist the specific case here.
// we have a dot syntax call whose dot and base are both implicit. We
// need to explicitly allow the specific case here.
if (auto *DSC = dyn_cast<DotSyntaxCallExpr>(CE->getFn())) {
if (DSC->getBase()->isImplicit() &&
DSC->getFn()->getStartLoc() == Info.TokensInRange.front().getLoc())