averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove some of unneeded functionality in CallerAnalysis

Browse Source 
We really only need the analysis to tell whether a function has caller
inside the module or not. We do not need to know the callsites.

Remove them for now to make the analysis more memory efficient.

Add a note to indicate it can be extended.
This commit is contained in:
Xin Tong
2016-03-17 21:10:27 -07:00
parent afcf0e34e0
commit fd353df19e
4 changed files with 36 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
include/swift/SILOptimizer/Analysis/CallerAnalysis.h
View File

@@ -24,31 +24,12 @@
namespace swift {
using ApplyList = llvm::SmallVector<FullApplySite, 4>;
class CallerAnalysisFunctionInfo {
/// NOTE: this can be extended to contain the callsites of the function.
struct CallerAnalysisFunctionInfo {
/// A list of all the functions this function calls.
llvm::SmallVector<SILFunction *, 4> Callees;
/// A list of all the functions that calls this function.
/// Keeping this list allows us to iterate over the CallSites
/// deterministically.
llvm::SmallVector<SILFunction *, 4> Callers;
/// A map between all the callers and the callsites in them which
/// calls this function.
llvm::SmallDenseMap<SILFunction *, ApplyList, 1> CallSites;
public:
/// Return a list of all the callsites for this function.
ApplyList getCallSites() {
ApplyList Sites;
for (auto &F : Callers) {
for (auto &S : CallSites[F])
Sites.push_back(S);
}
return Sites;
}
friend class CallerAnalysis;
llvm::SetVector<SILFunction *> Callees;
/// A list of all the callers this function has.
llvm::SetVector<SILFunction *> Callers;
};
/// CallerAnalysis relies on keeping the Caller/Callee relation up-to-date
@@ -93,6 +74,7 @@ public:
CallerAnalysis(SILModule *M) : SILAnalysis(AnalysisKind::Caller), Mod(*M) {
// Make sure we compute everything first time called.
for(auto &F : Mod) {
CallInfo.FindAndConstruct(&F);
RecomputeFunctionList.insert(&F);
}
}
@@ -142,17 +124,7 @@ public:
// list.
processRecomputeFunctionList();
auto Iter = CallInfo.FindAndConstruct(F);
return !Iter.second.CallSites.empty();
}
/// Return all the callsites to this function in the current module.
ApplyList getCallSites(SILFunction *F) {
// Recompute every function in the invalidated function list and empty the
// list.
processRecomputeFunctionList();
auto Iter = CallInfo.FindAndConstruct(F);
return Iter.second.getCallSites();
return !Iter.second.Callers.empty();
}
};