averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid storing a SourceManager on JSONFixitWriter

Browse Source 
Switch to storing the necessary edit information
instead.
This commit is contained in:
Hamish Knight
2023-09-15 18:27:49 +01:00
parent 746128c7aa
commit febb019a86
4 changed files with 52 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/FrontendTool/FrontendTool.cpp
View File

@@ -216,7 +216,7 @@ class JSONFixitWriter
std::string FixitsOutputPath;
std::unique_ptr<llvm::raw_ostream> OSPtr;
bool FixitAll;
std::vector<SingleEdit> AllEdits;
SourceEdits AllEdits;
public:
JSONFixitWriter(std::string fixitsOutputPath,
@@ -229,9 +229,8 @@ private:
const DiagnosticInfo &Info) override {
if (!(FixitAll || shouldTakeFixit(Info)))
return;
for (const auto &Fix : Info.FixIts) {
AllEdits.push_back({SM, Fix.getRange(), Fix.getText().str()});
}
for (const auto &Fix : Info.FixIts)
AllEdits.addEdit(SM, Fix.getRange(), Fix.getText());
}
bool finishProcessing() override {
@@ -251,7 +250,7 @@ private:
return true;
}
swift::writeEditsInJson(llvm::makeArrayRef(AllEdits), *OS);
swift::writeEditsInJson(AllEdits, *OS);
return false;
}
};