averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

TBDGen: Skip visiting nominal types with non-public linkage.

Browse Source 
As a performance optimization, `SILSymbolVisitor` can skip doing any work for
nominal types that have non-public linkage when the `PublicSymbolsOnly` option
is enabled. This makes `.tbd` emission trigger fewer unnecessary type checking
requests when `-experimenal-lazy-typecheck` is specified.

Resolves rdar://114704791
This commit is contained in:
Allan Shortlidge
2023-08-30 10:42:19 -07:00
parent ccbb6e1a42
commit fed04e0289
2 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
lib/SIL/IR/SILSymbolVisitor.cpp
View File

@@ -239,8 +239,7 @@ class SILSymbolVisitorImpl : public ASTVisitor<SILSymbolVisitorImpl> {
for (auto conformance :
IDC->getLocalConformances(ConformanceLookupKind::NonInherited)) {
auto protocol = conformance->getProtocol();
if (Ctx.getOpts().PublicSymbolsOnly &&
getDeclLinkage(protocol) != FormalLinkage::PublicUnique)
if (canSkipNominal(protocol))
continue;
auto needsWTable =
@@ -308,8 +307,7 @@ class SILSymbolVisitorImpl : public ASTVisitor<SILSymbolVisitorImpl> {
}
bool addClassMetadata(ClassDecl *CD) {
if (Ctx.getOpts().PublicSymbolsOnly &&
getDeclLinkage(CD) != FormalLinkage::PublicUnique)
if (canSkipNominal(CD))
return false;
auto &ctxt = CD->getASTContext();
@@ -365,6 +363,18 @@ class SILSymbolVisitorImpl : public ASTVisitor<SILSymbolVisitorImpl> {
Visitor.addMethodDescriptor(method);
}
/// Returns `true` if the neither the nominal nor its members have any symbols
/// that need to be visited because it has non-public linkage.
bool canSkipNominal(const NominalTypeDecl *NTD) {
if (!Ctx.getOpts().PublicSymbolsOnly)
return false;
if (NTD->hasClangNode())
return false;
return getDeclLinkage(NTD) != FormalLinkage::PublicUnique;
}
public:
SILSymbolVisitorImpl(SILSymbolVisitor &Visitor,
const SILSymbolVisitorContext &Ctx)
@@ -585,6 +595,9 @@ public:
}
void visitNominalTypeDecl(NominalTypeDecl *NTD) {
if (canSkipNominal(NTD))
return;
auto declaredType = NTD->getDeclaredType()->getCanonicalType();
if (!NTD->getObjCImplementationDecl()) {
@@ -680,12 +693,16 @@ public:
}
void visitExtensionDecl(ExtensionDecl *ED) {
auto nominal = ED->getExtendedNominal();
if (canSkipNominal(nominal))
return;
if (auto CD = dyn_cast_or_null<ClassDecl>(ED->getImplementedObjCDecl())) {
// @_objcImplementation extensions generate the class metadata symbols.
(void)addClassMetadata(CD);
}
if (!isa<ProtocolDecl>(ED->getExtendedNominal())) {
if (!isa<ProtocolDecl>(nominal)) {
addConformances(ED);
}
@@ -738,6 +755,9 @@ public:
#endif
void visitProtocolDecl(ProtocolDecl *PD) {
if (canSkipNominal(PD))
return;
if (!PD->isObjC() && !PD->isMarkerProtocol()) {
Visitor.addProtocolDescriptor(PD);