averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Sema: Warn on resilient uses of @_implementationOnly as deprecated

Browse Source 
Report uses of `@_implementationOnly` in resilient modules as deprecated.
With a fixit to replace it with `internal` or delete it when imports
are internal by default.

Uses of `@_implementationOnly` in non-resilient modules is already reported
as being unsafe.
This commit is contained in:
Alexis Laferrière
2024-04-21 10:47:09 -07:00
parent f4d73275cb
commit ff797cfd66
4 changed files with 65 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
test/Sema/implementation-only-deprecated.swift Normal file
View File

@@ -0,0 +1,23 @@
// RUN: %empty-directory(%t)
// RUN: split-file %s %t --leading-lines
// RUN: %target-swift-frontend -emit-module %t/Lib.swift \
// RUN: -enable-library-evolution -swift-version 5 \
// RUN: -emit-module-path %t/Lib.swiftmodule
// RUN: %target-swift-frontend -typecheck %t/Client.swift -I %t \
// RUN: -enable-library-evolution -swift-version 5 \
// RUN: -verify -verify-additional-prefix swift-5-
// RUN: %target-swift-frontend -typecheck %t/Client.swift -I %t \
// RUN: -enable-library-evolution -swift-version 5 \
// RUN: -enable-upcoming-feature InternalImportsByDefault \
// RUN: -verify -verify-additional-prefix default-to-internal-
//--- Lib.swift
public struct SomeType {}
//--- Client.swift
@_implementationOnly import Lib
// expected-swift-5-warning @-1 {{'@_implementationOnly' is deprecated, use 'internal import' and family instead}} {{1-21=internal}}
// expected-default-to-internal-warning @-2 {{'@_implementationOnly' is deprecated, use a bare import as 'InternalImportsByDefault' is enabled}} {{1-22=}}
internal func foo(_: SomeType) {}