mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
a13940f1c4
In the reverse interop header we generated move constructors that call abort at runtime. This is problematic for several reasons: * In C++14 and below some of our own generated functions like _make ended up calling the move constructor. Those are calling abort and also trigger unreachable code warning in newer versions of Clang. In C++17 and up it is fine due to the guaranteed copy elision. * Type traits are fooled and think these types are movable. As a result, libraries could generate calls to the aborting move ctor. This PR removes the generation of move operations. As we generate copy operations, the compiler will not declare or define the move operations implicitly. Whenever the user goes out of their way and try to move an object they will get a copy instead. rdar://150793518
193 lines
8.9 KiB
Swift
193 lines
8.9 KiB
Swift
// RUN: %empty-directory(%t)
|
|
// RUN: %target-swift-frontend %s -module-name Init -clang-header-expose-decls=all-public -typecheck -verify -emit-clang-header-path %t/inits.h
|
|
// RUN: %FileCheck %s < %t/inits.h
|
|
|
|
// RUN: %check-interop-cxx-header-in-clang(%t/inits.h -Wno-unused-function -DSWIFT_CXX_INTEROP_HIDE_STL_OVERLAY)
|
|
|
|
// RUN: %target-swift-frontend %s -module-name Init -clang-header-expose-decls=all-public -swift-version 5 -typecheck -verify -emit-clang-header-path %t/inits2.h
|
|
// RUN: %FileCheck %s < %t/inits2.h
|
|
|
|
|
|
// CHECK: SWIFT_EXTERN void * _Nonnull $s4Init9BaseClassCyACSi_SitcfC(ptrdiff_t x, ptrdiff_t y, SWIFT_CONTEXT void * _Nonnull _self) SWIFT_NOEXCEPT SWIFT_CALL; // init(_:_:)
|
|
// CHECK-NEXT: SWIFT_EXTERN void * _Nonnull $s4Init9BaseClassCyACSicfC(ptrdiff_t x, SWIFT_CONTEXT void * _Nonnull _self) SWIFT_NOEXCEPT SWIFT_CALL; // init(_:)
|
|
// CHECK-NEXT: SWIFT_EXTERN void * _Nonnull $s4Init12DerivedClassCyACSi_SitcfC(ptrdiff_t x, ptrdiff_t y, SWIFT_CONTEXT void * _Nonnull _self) SWIFT_NOEXCEPT SWIFT_CALL; // init(_:_:)
|
|
|
|
// CHECK: SWIFT_EXTERN struct swift_interop_returnStub_Init_uint32_t_0_4 $s4Init16FirstSmallStructVACycfC(void) SWIFT_NOEXCEPT SWIFT_CALL; // init()
|
|
// CHECK-NEXT: SWIFT_EXTERN struct swift_interop_returnStub_Init_uint32_t_0_4 $s4Init16FirstSmallStructVyACSicfC(ptrdiff_t x) SWIFT_NOEXCEPT SWIFT_CALL; // init(_:)
|
|
|
|
// CHECK: SWIFT_EXTERN void $s4Init11LargeStructVACycfC(SWIFT_INDIRECT_RESULT void * _Nonnull) SWIFT_NOEXCEPT SWIFT_CALL; // init()
|
|
// CHECK-NEXT: SWIFT_EXTERN void $s4Init11LargeStructV1x1yACSi_AA010FirstSmallC0VtcfC(SWIFT_INDIRECT_RESULT void * _Nonnull, ptrdiff_t x, struct swift_interop_passStub_Init_uint32_t_0_4 y) SWIFT_NOEXCEPT SWIFT_CALL; // init(x:y:)
|
|
|
|
// CHECK: SWIFT_EXTERN struct swift_interop_returnStub_Init_[[PTRENC:void_ptr_0_[0-9]]] $s4Init28StructWithRefCountStoredPropVACycfC(void) SWIFT_NOEXCEPT SWIFT_CALL; // init()
|
|
// CHECK-NEXT: SWIFT_EXTERN struct swift_interop_returnStub_Init_[[PTRENC]] $s4Init28StructWithRefCountStoredPropV1xACSi_tcfC(ptrdiff_t x) SWIFT_NOEXCEPT SWIFT_CALL; // init(x:)
|
|
|
|
public struct FirstSmallStruct {
|
|
public let x: UInt32
|
|
|
|
public init() {
|
|
x = 42
|
|
}
|
|
|
|
public init(_ x: Int) {
|
|
self.x = UInt32(x)
|
|
}
|
|
|
|
private init(_ y: Float) {
|
|
fatalError("nope")
|
|
}
|
|
}
|
|
|
|
// CHECK: class SWIFT_SYMBOL("s:4Init16FirstSmallStructV") FirstSmallStruct final {
|
|
// CHECK-NEXT: public:
|
|
// CHECK: SWIFT_INLINE_THUNK FirstSmallStruct &operator =(const FirstSmallStruct &other) noexcept {
|
|
// CHECK: }
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK uint32_t getX() const SWIFT_SYMBOL("s:4Init16FirstSmallStructV1xs6UInt32Vvp");
|
|
// CHECK-NEXT: static SWIFT_INLINE_THUNK FirstSmallStruct init() SWIFT_SYMBOL("s:4Init16FirstSmallStructVACycfc");
|
|
// CHECK-NEXT: static SWIFT_INLINE_THUNK FirstSmallStruct init(swift::Int x) SWIFT_SYMBOL("s:4Init16FirstSmallStructVyACSicfc");
|
|
// CHECK-NEXT: private:
|
|
|
|
public struct LargeStruct {
|
|
public let x1, x2, x3, x4, x5, x6: Int
|
|
|
|
public init () {
|
|
x1 = 0
|
|
x2 = 0
|
|
x3 = 0
|
|
x4 = 0
|
|
x5 = 0
|
|
x6 = 0
|
|
}
|
|
|
|
public init(x: Int, y: FirstSmallStruct) {
|
|
x1 = x
|
|
x2 = Int(y.x)
|
|
x3 = -x
|
|
x4 = 0
|
|
x5 = 11
|
|
x6 = x * Int(y.x)
|
|
}
|
|
}
|
|
|
|
// CHECK: class SWIFT_SYMBOL("s:4Init11LargeStructV") LargeStruct final {
|
|
// CHECK: SWIFT_INLINE_THUNK swift::Int getX6() const SWIFT_SYMBOL("s:4Init11LargeStructV2x6Sivp");
|
|
// CHECK-NEXT: static SWIFT_INLINE_THUNK LargeStruct init() SWIFT_SYMBOL("s:4Init11LargeStructVACycfc");
|
|
// CHECK-NEXT: static SWIFT_INLINE_THUNK LargeStruct init(swift::Int x, const FirstSmallStruct& y) SWIFT_SYMBOL("s:4Init11LargeStructV1x1yACSi_AA010FirstSmallC0Vtcfc");
|
|
// CHECK-NEXT: private:
|
|
|
|
private class RefCountedClass {
|
|
let x: Int
|
|
|
|
init(x: Int) {
|
|
self.x = x
|
|
print("create RefCountedClass \(x)")
|
|
}
|
|
deinit {
|
|
print("destroy RefCountedClass \(x)")
|
|
}
|
|
}
|
|
|
|
public struct StructWithRefCountStoredProp {
|
|
private let storedRef: RefCountedClass
|
|
|
|
public init() {
|
|
storedRef = RefCountedClass(x: -1)
|
|
}
|
|
|
|
public init(x: Int) {
|
|
storedRef = RefCountedClass(x: x)
|
|
}
|
|
}
|
|
|
|
// CHECK: static SWIFT_INLINE_THUNK StructWithRefCountStoredProp init() SWIFT_SYMBOL("s:4Init28StructWithRefCountStoredPropVACycfc");
|
|
// CHECK-NEXT: static SWIFT_INLINE_THUNK StructWithRefCountStoredProp init(swift::Int x) SWIFT_SYMBOL("s:4Init28StructWithRefCountStoredPropV1xACSi_tcfc");
|
|
|
|
|
|
public final class FinalClass {
|
|
public var prop: FirstSmallStruct
|
|
|
|
public init(_ prop: FirstSmallStruct) { self.prop = prop }
|
|
}
|
|
|
|
public class BaseClass {
|
|
public var x: Int
|
|
|
|
public init(_ x: Int, _ y: Int) { self.x = x + y }
|
|
|
|
public convenience init(_ x: Int) {
|
|
self.init(x, x * 2)
|
|
}
|
|
}
|
|
|
|
public class DerivedClass: BaseClass {
|
|
override public init(_ x: Int, _ y: Int) {
|
|
super.init(x + 1, y + 1)
|
|
}
|
|
}
|
|
|
|
public class DerivedClassTwo: BaseClass {
|
|
}
|
|
|
|
public struct WrapOverloadedInits {
|
|
let x: Int
|
|
|
|
public init(_ x: Int) {
|
|
self.x = x
|
|
}
|
|
public init(_ x: Float) {
|
|
self.x = Int(x)
|
|
}
|
|
}
|
|
|
|
// CHECK: static SWIFT_INLINE_THUNK WrapOverloadedInits init
|
|
// CHECK-SAME: (swift::Int x) SWIFT_SYMBOL("s:4Init19WrapOverloadedInitsVyACSicfc");
|
|
// CHECK-NOT: WrapOverloadedInits init(
|
|
|
|
// CHECK: BaseClass BaseClass::init(swift::Int x, swift::Int y) {
|
|
// CHECK-NEXT: return _impl::_impl_BaseClass::makeRetained(Init::_impl::$s4Init9BaseClassCyACSi_SitcfC(x, y, swift::TypeMetadataTrait<BaseClass>::getTypeMetadata()));
|
|
|
|
// CHECK: DerivedClass DerivedClass::init(swift::Int x, swift::Int y) {
|
|
// CHECK-NEXT: _impl::_impl_DerivedClass::makeRetained(Init::_impl::$s4Init12DerivedClassCyACSi_SitcfC(x, y, swift::TypeMetadataTrait<DerivedClass>::getTypeMetadata()));
|
|
|
|
// CHECK: DerivedClassTwo DerivedClassTwo::init(swift::Int x, swift::Int y) {
|
|
// CHECK-NEXT: return _impl::_impl_DerivedClassTwo::makeRetained(Init::_impl::$s4Init15DerivedClassTwoCyACSi_SitcfC(x, y, swift::TypeMetadataTrait<DerivedClassTwo>::getTypeMetadata()));
|
|
|
|
// CHECK: FinalClass FinalClass::init(const FirstSmallStruct& prop) {
|
|
// CHECK-NEXT: return _impl::_impl_FinalClass::makeRetained(Init::_impl::$s4Init10FinalClassCyAcA16FirstSmallStructVcfC(Init::_impl::swift_interop_passDirect_Init_uint32_t_0_4(Init::_impl::_impl_FirstSmallStruct::getOpaquePointer(prop)), swift::TypeMetadataTrait<FinalClass>::getTypeMetadata()));
|
|
|
|
|
|
// CHECK: SWIFT_INLINE_THUNK uint32_t FirstSmallStruct::getX() const {
|
|
// CHECK-NEXT: return Init::_impl::$s4Init16FirstSmallStructV1xs6UInt32Vvg(Init::_impl::swift_interop_passDirect_Init_uint32_t_0_4(_getOpaquePointer()));
|
|
// CHECK-NEXT: }
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK FirstSmallStruct FirstSmallStruct::init() {
|
|
// CHECK-NEXT: return Init::_impl::_impl_FirstSmallStruct::returnNewValue([&](char * _Nonnull result) SWIFT_INLINE_THUNK_ATTRIBUTES {
|
|
// CHECK-NEXT: _impl::swift_interop_returnDirect_Init_uint32_t_0_4(result, Init::_impl::$s4Init16FirstSmallStructVACycfC());
|
|
// CHECK-NEXT: });
|
|
// CHECK-NEXT: }
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK FirstSmallStruct FirstSmallStruct::init(swift::Int x) {
|
|
// CHECK-NEXT: return Init::_impl::_impl_FirstSmallStruct::returnNewValue([&](char * _Nonnull result) SWIFT_INLINE_THUNK_ATTRIBUTES {
|
|
// CHECK-NEXT: _impl::swift_interop_returnDirect_Init_uint32_t_0_4(result, Init::_impl::$s4Init16FirstSmallStructVyACSicfC(x));
|
|
// CHECK-NEXT: });
|
|
// CHECK-NEXT: }
|
|
|
|
// CHECK: SWIFT_INLINE_THUNK LargeStruct LargeStruct::init() {
|
|
// CHECK-NEXT: return Init::_impl::_impl_LargeStruct::returnNewValue([&](char * _Nonnull result) SWIFT_INLINE_THUNK_ATTRIBUTES {
|
|
// CHECK-NEXT: _impl::$s4Init11LargeStructVACycfC(result);
|
|
// CHECK-NEXT: });
|
|
// CHECK-NEXT: }
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK LargeStruct LargeStruct::init(swift::Int x, const FirstSmallStruct& y) {
|
|
// CHECK-NEXT: return Init::_impl::_impl_LargeStruct::returnNewValue([&](char * _Nonnull result) SWIFT_INLINE_THUNK_ATTRIBUTES {
|
|
// CHECK-NEXT: _impl::$s4Init11LargeStructV1x1yACSi_AA010FirstSmallC0VtcfC(result, x, Init::_impl::swift_interop_passDirect_Init_uint32_t_0_4(Init::_impl::_impl_FirstSmallStruct::getOpaquePointer(y)));
|
|
// CHECK-NEXT: });
|
|
// CHECK-NEXT: }
|
|
|
|
// CHECK: SWIFT_INLINE_THUNK StructWithRefCountStoredProp StructWithRefCountStoredProp::init() {
|
|
// CHECK-NEXT: return Init::_impl::_impl_StructWithRefCountStoredProp::returnNewValue([&](char * _Nonnull result) SWIFT_INLINE_THUNK_ATTRIBUTES {
|
|
// CHECK-NEXT: _impl::swift_interop_returnDirect_Init_[[PTRENC]](result, Init::_impl::$s4Init28StructWithRefCountStoredPropVACycfC());
|
|
// CHECK-NEXT: });
|
|
// CHECK-NEXT: }
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK StructWithRefCountStoredProp StructWithRefCountStoredProp::init(swift::Int x) {
|
|
// CHECK-NEXT: return Init::_impl::_impl_StructWithRefCountStoredProp::returnNewValue([&](char * _Nonnull result) SWIFT_INLINE_THUNK_ATTRIBUTES {
|
|
// CHECK-NEXT: _impl::swift_interop_returnDirect_Init_[[PTRENC]](result, Init::_impl::$s4Init28StructWithRefCountStoredPropV1xACSi_tcfC(x));
|
|
// CHECK-NEXT: });
|
|
// CHECK-NEXT: }
|