Files
swift-mirror/test/Sema/diag_self_assign.swift
Slava Pestov d5febdb791 Sema: Fix diagnoseSelfAssignment() with computed properties
This check did not handle MemberRefExprs with an InOutExpr base,
giving it inconsistent behavior:

- With a class, we would diagnose self-assignment of computed
  properties

- With a struct, accesses to computed properties would build a
  MemberRefExpr with an InOutExpr base, so self-assignments
  were *not* diagnosed.

Let's tweak the check to consistently diagnose self-assignments
to stored properties only, instead of the emergent behavior
as described above.
2020-09-26 00:02:42 -04:00

172 lines
5.0 KiB
Swift

// RUN: %target-typecheck-verify-swift
var sa1_global: Int
sa1_global = sa1_global // expected-error {{assigning a variable to itself}}
class SA1 {
var foo: Int = 0
init(fooi: Int) {
var foo = fooi
foo = foo // expected-error {{assigning a variable to itself}}
self.foo = self.foo // expected-error {{assigning a property to itself}}
foo = self.foo // no-error
self.foo = foo // no-error
}
func f(fooi: Int) {
var foo = fooi
foo = foo // expected-error {{assigning a variable to itself}}
self.foo = self.foo // expected-error {{assigning a property to itself}}
foo = self.foo // no-error
self.foo = foo // no-error
}
}
struct SA1a {
var foo: Int = 0
init(fooi: Int) {
var foo = fooi
foo = foo // expected-error {{assigning a variable to itself}}
self.foo = self.foo // expected-error {{assigning a property to itself}}
foo = self.foo // no-error
self.foo = foo // no-error
}
mutating func f(fooi: Int) {
var foo = fooi
foo = foo // expected-error {{assigning a variable to itself}}
self.foo = self.foo // expected-error {{assigning a property to itself}}
foo = self.foo // no-error
self.foo = foo // no-error
}
}
class SA2 {
var foo: Int {
get {
return 0
}
set {}
}
init(fooi: Int) {
var foo = fooi
foo = foo // expected-error {{assigning a variable to itself}}
self.foo = self.foo // no-error
foo = self.foo // no-error
self.foo = foo // no-error
}
func f(fooi: Int) {
var foo = fooi
foo = foo // expected-error {{assigning a variable to itself}}
self.foo = self.foo // no-error
foo = self.foo // no-error
self.foo = foo // no-error
}
}
struct SA2a {
var foo: Int {
get {
return 0
}
set {}
}
init(fooi: Int) {
var foo = fooi
foo = foo // expected-error {{assigning a variable to itself}}
self.foo = self.foo // no-error
foo = self.foo // no-error
self.foo = foo // no-error
}
mutating func f(fooi: Int) {
var foo = fooi
foo = foo // expected-error {{assigning a variable to itself}}
self.foo = self.foo // no-error
foo = self.foo // no-error
self.foo = foo // no-error
}
}
class SA3 {
var foo: Int {
get {
return foo // expected-warning {{attempting to access 'foo' within its own getter}} expected-note{{access 'self' explicitly to silence this warning}} {{14-14=self.}}
}
set {
foo = foo // expected-warning {{attempting to modify 'foo' within its own setter}} expected-note{{access 'self' explicitly to silence this warning}} {{7-7=self.}} expected-warning{{setter argument 'newValue' was never used, but the property was accessed}} expected-note{{did you mean to use 'newValue' instead of accessing the property's current value?}}
self.foo = self.foo // no-error
foo = self.foo // expected-warning {{attempting to modify 'foo' within its own setter}} expected-note{{access 'self' explicitly to silence this warning}} {{7-7=self.}}
self.foo = foo
}
}
}
struct SA3a {
var foo: Int {
get {
return foo // expected-warning {{attempting to access 'foo' within its own getter}} expected-note{{access 'self' explicitly to silence this warning}} {{14-14=self.}}
}
set {
foo = foo // expected-warning {{attempting to modify 'foo' within its own setter}} expected-note{{access 'self' explicitly to silence this warning}} {{7-7=self.}} expected-warning{{setter argument 'newValue' was never used, but the property was accessed}} expected-note{{did you mean to use 'newValue' instead of accessing the property's current value?}}
self.foo = self.foo // no-error
foo = self.foo // expected-warning {{attempting to modify 'foo' within its own setter}} expected-note{{access 'self' explicitly to silence this warning}} {{7-7=self.}}
self.foo = foo
}
}
}
class SA4 {
var foo: Int {
get {
return foo // expected-warning {{attempting to access 'foo' within its own getter}} expected-note{{access 'self' explicitly to silence this warning}} {{14-14=self.}}
}
set(value) {
value = value // expected-error {{cannot assign to value: 'value' is a 'let' constant}}
}
}
}
struct SA4a {
var foo: Int {
get {
return foo // expected-warning {{attempting to access 'foo' within its own getter}} expected-note{{access 'self' explicitly to silence this warning}} {{14-14=self.}}
}
set(value) {
value = value // expected-error {{cannot assign to value: 'value' is a 'let' constant}}
}
}
}
class SA5 {
var foo: Int = 0
}
func SA5_test(a: SA5, b: SA5) {
a.foo = a.foo // expected-error {{assigning a property to itself}}
a.foo = b.foo
}
struct SA5a {
var foo: Int = 0
}
func SA5a_test(a: inout SA5, b: inout SA5) {
a.foo = a.foo // expected-error {{assigning a property to itself}}
a.foo = b.foo
}
class SA_Deep1 {
class Foo {
var aThing = String()
}
class Bar {
var aFoo = Foo()
}
var aFoo = Foo()
func test() {
let aBar = Bar()
aBar.aFoo = Foo()
aBar.aFoo.aThing = self.aFoo.aThing // no-error
}
}