mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
7996c5b30c
The compiler derived implementations of `Codable` conformances for enums did not take enum element unavailability into account. This could result in unavailable values being instantiated at runtime, leading to a general violation of the invariant that unavailable code is unreachable at runtime. This problem is possible because synthesized code is not type checked; had the conformances been hand-written, they would have been rejected for referencing unavailable declarations inside of available declarations. This change specifically alters derivation for the following declarations: - `Decodable.init(from:)` - `Encodable.encode(to:)` - `CodingKey.init(stringValue:)` Resolves rdar://110098469
60 lines
2.6 KiB
Swift
60 lines
2.6 KiB
Swift
// RUN: %target-typecheck-verify-swift -verify-ignore-unknown
|
|
|
|
// Simple enums with all Codable parameters should get derived conformance to
|
|
// Codable.
|
|
enum SimpleEnum : Codable {
|
|
case a(x: Int, y: Double)
|
|
case b(z: String)
|
|
case c(Int, String, b: Bool)
|
|
case d(_ inner: Int)
|
|
@available(*, unavailable) case e(Int)
|
|
|
|
// These lines have to be within the SimpleEnum type because CodingKeys
|
|
// should be private.
|
|
func foo() {
|
|
// They should receive a synthesized CodingKeys enum.
|
|
let _ = SimpleEnum.CodingKeys.self
|
|
let _ = SimpleEnum.ACodingKeys.self
|
|
let _ = SimpleEnum.BCodingKeys.self
|
|
let _ = SimpleEnum.CCodingKeys.self
|
|
let _ = SimpleEnum.DCodingKeys.self
|
|
let _ = SimpleEnum.ECodingKeys.self
|
|
|
|
// The enum should have a case for each of the cases.
|
|
let _ = SimpleEnum.CodingKeys.a
|
|
let _ = SimpleEnum.CodingKeys.b
|
|
|
|
// The enum should have a case for each of the vars.
|
|
let _ = SimpleEnum.ACodingKeys.x
|
|
let _ = SimpleEnum.ACodingKeys.y
|
|
|
|
let _ = SimpleEnum.BCodingKeys.z
|
|
|
|
let _ = SimpleEnum.CCodingKeys._0
|
|
let _ = SimpleEnum.CCodingKeys._1
|
|
let _ = SimpleEnum.CCodingKeys.b
|
|
|
|
let _ = SimpleEnum.DCodingKeys._0
|
|
|
|
let _ = SimpleEnum.ECodingKeys._0
|
|
}
|
|
}
|
|
|
|
// They should receive synthesized init(from:) and an encode(to:).
|
|
let _ = SimpleEnum.init(from:)
|
|
let _ = SimpleEnum.encode(to:)
|
|
|
|
// The synthesized CodingKeys type should not be accessible from outside the
|
|
// enum.
|
|
let _ = SimpleEnum.CodingKeys.self // expected-error {{'CodingKeys' is inaccessible due to 'private' protection level}}
|
|
let _ = SimpleEnum.ACodingKeys.self // expected-error {{'ACodingKeys' is inaccessible due to 'private' protection level}}
|
|
let _ = SimpleEnum.BCodingKeys.self // expected-error {{'BCodingKeys' is inaccessible due to 'private' protection level}}
|
|
let _ = SimpleEnum.CCodingKeys.self // expected-error {{'CCodingKeys' is inaccessible due to 'private' protection level}}
|
|
|
|
// Empty enum must be diagnosed early, rather than leave the failure to DI.
|
|
enum EmptyCodableEnum1: Encodable {} // expected-error{{cannot automatically synthesize 'Encodable' conformance for empty enum 'EmptyCodableEnum1'}}
|
|
enum EmptyCodableEnum2: Decodable {} // expected-error{{cannot automatically synthesize 'Decodable' conformance for empty enum 'EmptyCodableEnum2'}}
|
|
enum EmptyCodableEnum: Codable {}
|
|
// expected-error@-1{{cannot automatically synthesize 'Encodable' conformance for empty enum 'EmptyCodableEnum'}}
|
|
// expected-error@-2{{cannot automatically synthesize 'Decodable' conformance for empty enum 'EmptyCodableEnum'}}
|