mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
11f0ff6e32
For years, optimizer engineers have been hitting a common bug caused by passes assuming all SILValues have a parent function only to be surprised by SILUndef. Generally we see SILUndef not that often so we see this come up later in testing. This patch eliminates that problem by making SILUndef uniqued at the function level instead of the module level. This ensures that it makes sense for SILUndef to have a parent function, eliminating this possibility since we can define an API to get its parent function. rdar://123484595
27 lines
918 B
C++
27 lines
918 B
C++
//===--- SILUndef.cpp -----------------------------------------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "swift/SIL/SILUndef.h"
|
|
#include "swift/SIL/SILModule.h"
|
|
|
|
using namespace swift;
|
|
|
|
SILUndef::SILUndef(SILFunction *parent, SILType type)
|
|
: ValueBase(ValueKind::SILUndef, type), parent(parent) {}
|
|
|
|
SILUndef *SILUndef::get(SILFunction *fn, SILType ty) {
|
|
SILUndef *&entry = fn->undefValues[ty];
|
|
if (entry == nullptr)
|
|
entry = new (fn->getModule()) SILUndef(fn, ty);
|
|
return entry;
|
|
}
|