mirror of
https://github.com/apple/swift.git
synced 2026-10-22 19:15:50 +02:00
Nenad VULIC
b051ef4ce7
Companion to swiftlang/swift-syntax#3363. That PR makes swift-syntax parse `#warning`/`#error` in case position of a `switch` as a `MacroExpansionDecl` element of the case list (instead of diagnosing them), to match the compiler. As a result `SwitchCaseListSyntax.Element` gains a `.macroExpansionDecl` case, which makes the exhaustive switch in `generate(switchCaseList:)` no longer compile. This handles the new case in ASTGen: - `Stmts.swift`: in `generate(switchCaseList:)`, handle `.macroExpansionDecl` by evaluating it with `maybeGenerateBuiltinPound` (for the `#warning`/`#error` diagnostic) and skipping it, since it isn't a case. - `ASTGen+CompilerBuildConfiguration.swift`: add a `skip` case to `IfConfigOrUnderlying` so the `split` closure can handle an element itself without producing a flat element to visit. - `BuiltinPound.swift`: `handlePoundDiagnostic` asserted that a pound diagnostic must be at code-block/member-block level; the parent in this case is a `SwitchCaseListSyntax`, so accept that parent kind too. Added an ASTGen test covering `#warning`/`#error` in case position, including inside an `#if`. This only builds against the swift-syntax branch above, so it needs to be cross-repo tested with it.
66 lines
1.3 KiB
Swift
66 lines
1.3 KiB
Swift
// RUN: %target-typecheck-verify-swift -enable-experimental-feature ParserASTGen
|
|
|
|
// REQUIRES: swift_feature_ParserASTGen
|
|
|
|
// '#warning'/'#error' are allowed in case position of a switch and are
|
|
// evaluated for their diagnostic, without being treated as a case.
|
|
|
|
func testPoundWarningInSwitch(_ x: Int) {
|
|
switch x {
|
|
#warning("warning in case position") // expected-warning {{warning in case position}}
|
|
case 1:
|
|
break
|
|
default:
|
|
break
|
|
}
|
|
}
|
|
|
|
func testPoundErrorInSwitch(_ x: Int) {
|
|
switch x {
|
|
#error("error in case position") // expected-error {{error in case position}}
|
|
case 1:
|
|
break
|
|
default:
|
|
break
|
|
}
|
|
}
|
|
|
|
func testPoundDiagnosticInSwitchIfConfig(_ x: Int) {
|
|
switch x {
|
|
#if true
|
|
#warning("warning in #if") // expected-warning {{warning in #if}}
|
|
#endif
|
|
case 1:
|
|
break
|
|
default:
|
|
break
|
|
}
|
|
}
|
|
|
|
func testPoundDiagnosticInSwitchElse(_ x: Int) {
|
|
switch x {
|
|
#if false
|
|
case 1:
|
|
break
|
|
#else
|
|
#warning("warning in #else") // expected-warning {{warning in #else}}
|
|
#endif
|
|
default:
|
|
break
|
|
}
|
|
}
|
|
|
|
func testPoundDiagnosticInSwitchNestedIfConfig(_ x: Int) {
|
|
switch x {
|
|
#if true
|
|
#if true
|
|
#warning("warning in nested #if") // expected-warning {{warning in nested #if}}
|
|
#endif
|
|
#endif
|
|
case 1:
|
|
break
|
|
default:
|
|
break
|
|
}
|
|
}
|