mirror of
https://github.com/apple/swift.git
synced 2026-10-20 19:13:47 +02:00
Slava Pestov
e321f29906
This fixes a regression from the new join implementation, where computing more joins had the incidental side effect of changing the binding order and causing us to find weird solutions involving the Any default type of an array. This fix is a bit messy, because in reality every kind of Defaultable or FallbackType constraint has slightly different behavior. They should probably be represented differently. Hopefully once I start converting Default constraints to Fallback bindings, this can be greatly simplified, but in the meantime, establishing the behavior in the tests is still a step forward. Some diagnostics changed, but I don't think any got worse. A number of examples which didn't type check now do.
113 lines
3.0 KiB
Swift
113 lines
3.0 KiB
Swift
// RUN: %target-typecheck-verify-swift
|
|
|
|
// Expression that appeared in a real project.
|
|
|
|
struct URLComponents {
|
|
var queryItems: [URLQueryItem]?
|
|
}
|
|
|
|
struct URLQueryItem {
|
|
var name: String
|
|
var value: String?
|
|
}
|
|
|
|
extension String {
|
|
var removingPercentEncoding: String? { fatalError() }
|
|
}
|
|
|
|
func moreComplexExample1(_ urlComponents: URLComponents) -> [String: AnyHashable] {
|
|
let result = urlComponents.queryItems?.reduce(into: [String: AnyHashable]()) { partialResult, queryItem in
|
|
partialResult[queryItem.name] = queryItem.value?.removingPercentEncoding
|
|
} ?? [:]
|
|
|
|
// The type of result must be inferred as [String: AnyHashable], and not
|
|
// [String: AnyHashable]?, [String: Any], or [String: Any]?, even though
|
|
// the latter two solutions have a better score under our existing scoring
|
|
// rules, which are hard to change. The trick is that we must not attempt
|
|
// the 'Any' binding for the dictionary element type at all.
|
|
return result
|
|
}
|
|
|
|
// Further reductions of the above.
|
|
|
|
do {
|
|
func f<U, V>(_: U, _: V, _: (U, V) -> ()) -> U? { fatalError() }
|
|
|
|
func g<V>(_: Array<V>, _: V) {}
|
|
|
|
func test1a(u: [String], v: any Sequence) -> [any Sequence] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1b(u: [any Sequence], v: String) -> [any Sequence] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1c(u: [String], v: String?) -> [String?] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1d(u: [String?], v: String) -> [String?] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1e(u: [String], v: Any) -> [Any] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1f(u: [Any], v: String) -> [Any] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1g(u: [String], v: AnyHashable) -> [AnyHashable] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1h(u: [AnyHashable], v: String) -> [AnyHashable] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1i(u: [() -> Int], v: @escaping () -> Any) -> [() -> Any] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test1j(u: [() -> Any], v: @escaping () -> Int) -> [() -> Any] {
|
|
let result = f(u, v) { u, v in g(u, v) } ?? []
|
|
return result
|
|
}
|
|
|
|
func test2(u: [AnyHashable], v: String) -> [AnyHashable] {
|
|
let result = f(u, v, g) ?? []
|
|
return result
|
|
}
|
|
|
|
func test3(u: [AnyHashable], v: String) -> [AnyHashable] {
|
|
let result = f([], v) { u, v in g(u, v) } ?? u
|
|
return result
|
|
}
|
|
|
|
func test4(u: [AnyHashable], v: String) -> [AnyHashable] {
|
|
let result = f([], v, g) ?? u
|
|
return result
|
|
}
|
|
|
|
func test5(u: [AnyHashable], v: String) -> [AnyHashable] {
|
|
let result = (f(u, v) { u, v in g(u, v) })!
|
|
return result
|
|
}
|
|
|
|
func test6(u: [AnyHashable], v: String) -> [AnyHashable] {
|
|
let result = f(u, v, g)!
|
|
return result
|
|
}
|
|
}
|