mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
1a4176041e
When importing C++ methods, Swift always assumes that methods named `begin()` and `end()` are unsafe, since these methods commonly return iterator types that are inherently unsafe in Swift.
Some additional logic in Sema tries to diagnose usages of `.begin()` and `.end()` from Swift and suggest safe alternatives. That logic had a null pointer dereference bug.
rdar://153814676 / resolves https://github.com/swiftlang/swift/issues/82361
(cherry picked from commit 883ff18adb)
61 lines
2.1 KiB
Swift
61 lines
2.1 KiB
Swift
// RUN: rm -rf %t
|
|
// RUN: split-file %s %t
|
|
// RUN: not %target-swift-frontend -typecheck -I %t/Inputs %t/test.swift -enable-experimental-cxx-interop -diagnostic-style llvm 2>&1 | %FileCheck %s
|
|
|
|
//--- Inputs/module.modulemap
|
|
module Test {
|
|
header "test.h"
|
|
requires cplusplus
|
|
}
|
|
|
|
//--- Inputs/test.h
|
|
struct Ptr { int *p; };
|
|
struct __attribute__((swift_attr("import_owned"))) StringLiteral { const char *name; };
|
|
|
|
struct M {
|
|
M(const M&);
|
|
int *_Nonnull test1() const;
|
|
int &test2() const;
|
|
Ptr test3() const;
|
|
|
|
int *begin() const;
|
|
|
|
StringLiteral stringLiteral() const { return StringLiteral{"M"}; }
|
|
};
|
|
|
|
struct HasNonIteratorBeginMethod {
|
|
void begin() const;
|
|
void end() const;
|
|
};
|
|
|
|
//--- test.swift
|
|
|
|
import Test
|
|
|
|
public func test(x: M) {
|
|
// CHECK: note: C++ method 'test1' that returns a pointer of type 'UnsafeMutablePointer' is unavailable
|
|
// CHECK: note: C++ method 'test1' may return an interior pointer
|
|
// CHECK: note: annotate method 'test1' with 'SWIFT_RETURNS_INDEPENDENT_VALUE' in C++ to make it available in Swift
|
|
x.test1()
|
|
// CHECK: note: C++ method 'test2' that returns a reference of type 'UnsafeMutablePointer' is unavailable
|
|
// CHECK: note: C++ method 'test2' may return an interior pointer
|
|
// CHECK: note: annotate method 'test2' with 'SWIFT_RETURNS_INDEPENDENT_VALUE' in C++ to make it available in Swift
|
|
x.test2()
|
|
// CHECK: note: C++ method 'test3' that returns a value of type 'Ptr' is unavailable
|
|
// CHECK: note: C++ method 'test3' may return an interior pointer
|
|
// CHECK: note: annotate method 'test3' with 'SWIFT_RETURNS_INDEPENDENT_VALUE' in C++ to make it available in Swift
|
|
// CHECK: note: annotate type 'Ptr' with 'SWIFT_SELF_CONTAINED' in C++ to make methods that return it available in Swift
|
|
x.test3()
|
|
// CHECK: note: C++ method 'begin' that returns an iterator is unavailable
|
|
// CHECK: note: C++ methods that return iterators are potentially unsafe; try using Swift collection APIs instead
|
|
x.begin()
|
|
|
|
// CHECK-NOT: error: value of type 'M' has no member 'stringLiteral'
|
|
x.stringLiteral()
|
|
}
|
|
|
|
public func test(_ x: HasNonIteratorBeginMethod) {
|
|
x.begin()
|
|
x.end()
|
|
}
|