mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
c3a7203221
Explanation: There was an inconsistency between non-const and const FRT pointers. The former used Direct_Unowned the latter used Indirect calling convention. We want to use Direct_Unowned for both cases. The crash was the result of a calling convention mismatch between the SILFunctionType of a Swift closure and the SILFunctionType of the C++ function's formal parameter that is taking a function pointer. The compiler tried to insert a conversion between the two function types that does not exist and caused an assertion in debug compilers and miscompilation in production compilers. Issue: rdar://149398905 Risk: Low, the fix is targeted and we change to a well-tested behavior with non-const FRT pointers. Testing: Regression test added. Original PR: #81070 Reviewer: @j-hui
38 lines
1.8 KiB
Swift
38 lines
1.8 KiB
Swift
// RUN: %target-swift-emit-silgen -Xllvm -sil-print-types %s -I %S/Inputs -enable-experimental-cxx-interop -disable-availability-checking | %FileCheck %s
|
|
|
|
import POD
|
|
|
|
// CHECK-NOT: borrow
|
|
// CHECK-NOT: retain
|
|
// CHECK-NOT: release
|
|
// CHECK-LABEL: sil [ossa] @$s4main4testyyF : $@convention(thin) () -> ()
|
|
|
|
// CHECK: [[BOX:%.*]] = project_box {{.*}} : ${ var IntPair }, 0
|
|
|
|
// CHECK: [[CREATE_FN:%.*]] = function_ref @{{_ZN7IntPair6createEv|\?create\@IntPair\@\@SAPEAU1\@XZ}} : $@convention(c) () -> IntPair
|
|
// CHECK: [[CREATED_PTR:%.*]] = apply [[CREATE_FN]]() : $@convention(c) () -> IntPair
|
|
// CHECK: store [[CREATED_PTR]] to [trivial] [[BOX]] : $*IntPair
|
|
// CHECK: [[ACCESS_1:%.*]] = begin_access [read] [unknown] [[BOX]] : $*IntPair
|
|
// CHECK: [[X_1:%.*]] = load [trivial] [[ACCESS_1]] : $*IntPair
|
|
|
|
// CHECK: [[X_B:%.*]] = ref_element_addr [[X_1]] : $IntPair, #IntPair.b
|
|
// CHECK: [[ACCESS_2:%.*]] = begin_access [modify] [dynamic] [[X_B]] : $*Int32
|
|
// CHECK: assign {{.*}} to [[ACCESS_2]] : $*Int32
|
|
|
|
// CHECK: [[ACCESS_3:%.*]] = begin_access [read] [unknown] [[BOX]] : $*IntPair
|
|
// CHECK: [[X_2:%.*]] = load [trivial] [[ACCESS_3]] : $*IntPair
|
|
// CHECK: [[TEST_FN:%.*]] = function_ref @{{_ZNK7IntPair4testEv|\?test\@IntPair\@\@QEBAHXZ}} : $@convention(cxx_method) (IntPair) -> Int32
|
|
// CHECK: apply [[TEST_FN]]([[X_2]]) : $@convention(cxx_method) (IntPair) -> Int32
|
|
|
|
// CHECK: return
|
|
// CHECK-LABEL: end sil function '$s4main4testyyF'
|
|
public func test() {
|
|
var x = IntPair.create()
|
|
x.b = 42
|
|
_ = x.test()
|
|
}
|
|
|
|
// CHECK-LABEL: sil{{ \[available .*\] | }}[clang IntPair.create] @{{_ZN7IntPair6createEv|\?create\@IntPair\@\@SAPEAU1\@XZ}} : $@convention(c) () -> IntPair
|
|
|
|
// CHECK-LABEL: sil{{ \[available .*\] | }}[clang IntPair.test] @{{_ZNK7IntPair4testEv|\?test\@IntPair\@\@QEBAHXZ}} : $@convention(cxx_method) (IntPair) -> Int32
|