mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
c3a7203221
Explanation: There was an inconsistency between non-const and const FRT pointers. The former used Direct_Unowned the latter used Indirect calling convention. We want to use Direct_Unowned for both cases. The crash was the result of a calling convention mismatch between the SILFunctionType of a Swift closure and the SILFunctionType of the C++ function's formal parameter that is taking a function pointer. The compiler tried to insert a conversion between the two function types that does not exist and caused an assertion in debug compilers and miscompilation in production compilers. Issue: rdar://149398905 Risk: Low, the fix is targeted and we change to a well-tested behavior with non-const FRT pointers. Testing: Regression test added. Original PR: #81070 Reviewer: @j-hui
25 lines
910 B
Swift
25 lines
910 B
Swift
// RUN: %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop -validate-tbd-against-ir=none -disable-llvm-verify -Xcc -fignore-exceptions -disable-availability-checking | %FileCheck %s
|
|
|
|
import Singleton
|
|
|
|
// CHECK: %struct.DeletedSpecialMembers = type { i32 }
|
|
|
|
// CHECK-LABEL: define {{.*}}swiftcc void @"$s4main4testyyF"
|
|
|
|
// CHECK: [[X:%.*]] = alloca ptr
|
|
|
|
// CHECK: [[CREATED:%.*]] = call ptr @{{_ZN21DeletedSpecialMembers6createEv|"\?create\@DeletedSpecialMembers\@\@SAPEAU1\@XZ"}}()
|
|
// CHECK: store ptr [[CREATED]], ptr [[X]]
|
|
|
|
// CHECK: call i32 @{{_ZNK21DeletedSpecialMembers4testEv|"\?test\@DeletedSpecialMembers\@\@QEBAHXZ"}}(ptr [[CREATED]])
|
|
|
|
// CHECK: call void @{{_Z8mutateItR21DeletedSpecialMembers|"\?mutateIt\@\@YAXAEAUDeletedSpecialMembers\@\@\@Z"}}(ptr [[CREATED]])
|
|
|
|
// CHECK: ret void
|
|
|
|
public func test() {
|
|
var x = DeletedSpecialMembers.create()
|
|
_ = x.test()
|
|
mutateIt(x)
|
|
}
|