mirror of
https://github.com/apple/swift.git
synced 2026-10-24 20:15:56 +02:00
`containsSingleReference` only accepted class types, so the pass bailed on the
%o = alloc_ref [stack] $_ContiguousArrayStorage<Int>
%b = unchecked_ref_cast %o to $Builtin.BridgeObject
%e = end_cow_mutation %b
destroy_value %e
dealloc_stack_ref %o
pattern which a stack promoted array buffer has. The `destroy_value` then stayed
a real `swift_bridgeObjectRelease` call instead of becoming a `begin_dealloc_ref`
plus a direct deinit call.
Use `isHeapObjectReferenceType` instead, which covers exactly those types with a
single pointer representation.
225 lines
7.4 KiB
Swift
225 lines
7.4 KiB
Swift
//===--- ClassDestroyDevirtualizer.swift ----------------------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2025 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import AST
|
|
import SIL
|
|
|
|
/// Devirtualizes `destroy_value` instructions which are known to destruct a class object.
|
|
///
|
|
/// This means, it replaces a sequence of
|
|
/// ```
|
|
/// %x = alloc_ref [stack] $X
|
|
/// ...
|
|
/// destroy_value %x
|
|
/// dealloc_stack_ref %x
|
|
/// ```
|
|
/// with
|
|
/// ```
|
|
/// %x = alloc_ref [stack] $X
|
|
/// ...
|
|
/// %y = begin_dealloc_ref %x
|
|
/// %d = function_ref @dealloc_of_X
|
|
/// %a = apply %d(%y)
|
|
/// dealloc_stack_ref %x
|
|
/// ```
|
|
///
|
|
/// The optimization is only done for stack promoted objects because they are known to have no
|
|
/// associated objects (which are not explicitly released in the deinit method).
|
|
let classDestroyDevirtualizerPass = FunctionPass(name: "class-destroy-devirtualizer") {
|
|
(function: Function, context: FunctionPassContext) in
|
|
|
|
for inst in function.instructions {
|
|
if let dealloc = inst as? DeallocStackRefInst {
|
|
if !context.continueWithNextSubpassRun(for: dealloc) {
|
|
return
|
|
}
|
|
tryDevirtualizeDestroy(of: dealloc, context)
|
|
}
|
|
}
|
|
}
|
|
|
|
private func tryDevirtualizeDestroy(of dealloc: DeallocStackRefInst, _ context: FunctionPassContext) {
|
|
guard let (lastDestroy, pathToDestroy) = findLastDestroy(of: dealloc, context),
|
|
pathToDestroy.isMaterializable
|
|
else {
|
|
return
|
|
}
|
|
|
|
let allocRef = dealloc.allocRef
|
|
var upWalker = FindAllocationWalker(allocation: allocRef)
|
|
if upWalker.walkUp(value: lastDestroy.destroyedValue, path: pathToDestroy) == .abortWalk {
|
|
return
|
|
}
|
|
|
|
let type = allocRef.type
|
|
|
|
guard let dealloc = context.calleeAnalysis.getDestructor(ofExactType: type) else {
|
|
return
|
|
}
|
|
|
|
let builder = Builder(before: lastDestroy, location: lastDestroy.location, context)
|
|
|
|
var object = lastDestroy.operand.value.createProjection(path: pathToDestroy, builder: builder)
|
|
if object.type != type {
|
|
object = builder.createUncheckedRefCast(from: object, to: type)
|
|
}
|
|
|
|
// Do what a `destroy_value` would do before calling the deallocator: set the object
|
|
// in deallocating state, which means set the RC_DEALLOCATING_FLAG flag.
|
|
let beginDealloc = builder.createBeginDeallocRef(reference: object, allocation: allocRef)
|
|
|
|
// Create the call to the destructor with the allocated object as self
|
|
// argument.
|
|
let functionRef = builder.createFunctionRef(dealloc)
|
|
|
|
let substitutionMap: SubstitutionMap
|
|
if dealloc.isGeneric {
|
|
substitutionMap = context.getContextSubstitutionMap(for: type)
|
|
} else {
|
|
// In embedded Swift, dealloc might be a specialized deinit, so the substitution map on the old apply isn't valid for the new apply
|
|
substitutionMap = SubstitutionMap()
|
|
}
|
|
|
|
builder.createApply(function: functionRef, substitutionMap, arguments: [beginDealloc])
|
|
context.erase(instruction: lastDestroy)
|
|
}
|
|
|
|
private func findLastDestroy(
|
|
of dealloc: DeallocStackRefInst,
|
|
_ context: FunctionPassContext
|
|
) -> (lastDestroy: DestroyValueInst, pathToDestroy: SmallProjectionPath)? {
|
|
let allocRef = dealloc.allocRef
|
|
|
|
// Search for the final `destroy_value` in the same basic block of the dealloc.
|
|
for instruction in ReverseInstructionList(first: dealloc.previous) {
|
|
switch instruction {
|
|
case let destroy as DestroyValueInst:
|
|
if destroy.destroyedValue.type.containsSingleReference(in: dealloc.parentFunction) {
|
|
if let pathToDestroy = getPathToDestroy(from: allocRef, to: destroy) {
|
|
return (destroy, pathToDestroy)
|
|
}
|
|
}
|
|
case is BeginDeallocRefInst, is DeallocRefInst:
|
|
// Check if the last `destroy_value` was already de-virtualized.
|
|
if allocRef.escapes(to: instruction, context) {
|
|
return nil
|
|
}
|
|
default:
|
|
break
|
|
}
|
|
if instruction.mayRelease && allocRef.escapes(to: instruction, context) {
|
|
// This instruction may release the allocRef, which means that any destroy we find
|
|
// earlier in the block is not guaranteed to be the final destroy.
|
|
return nil
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// The final destroy might destroy a struct which _contains_ the allocated object.
|
|
// Return a projection path to the contained object in this case.
|
|
private func getPathToDestroy(from allocRef: AllocRefInstBase, to destroy: DestroyValueInst) -> SmallProjectionPath? {
|
|
var downWalker = FindDestroyWalker(destroy: destroy)
|
|
if downWalker.walkDownUses(ofValue: allocRef, path: SmallProjectionPath()) == .continueWalk {
|
|
return downWalker.result
|
|
}
|
|
return nil
|
|
}
|
|
|
|
private struct FindDestroyWalker : ValueDefUseWalker {
|
|
private let destroy: DestroyValueInst
|
|
private(set) var result: SmallProjectionPath? = nil
|
|
|
|
var walkDownCache = WalkerCache<SmallProjectionPath>()
|
|
|
|
init(destroy: DestroyValueInst) {
|
|
self.destroy = destroy
|
|
}
|
|
|
|
mutating func leafUse(value: Operand, path: SmallProjectionPath) -> WalkResult {
|
|
if value.instruction == destroy {
|
|
if let existingResult = result {
|
|
result = existingResult.merge(with: path)
|
|
} else {
|
|
result = path
|
|
}
|
|
}
|
|
return .continueWalk
|
|
}
|
|
}
|
|
|
|
private extension AllocRefInstBase {
|
|
func escapes(to instruction: Instruction, _ context: FunctionPassContext) -> Bool {
|
|
return self.isEscaping(using: EscapesToInstructionVisitor(target: instruction), context)
|
|
}
|
|
}
|
|
|
|
private struct EscapesToInstructionVisitor : EscapeVisitor {
|
|
let target: Instruction
|
|
|
|
mutating func visitUse(operand: Operand, path: EscapePath) -> UseResult {
|
|
if operand.instruction == target {
|
|
return .abort
|
|
}
|
|
return .continueWalk
|
|
}
|
|
}
|
|
|
|
// Up-walker to find the root of a `destroy_value` instruction.
|
|
private struct FindAllocationWalker : ValueUseDefWalker {
|
|
private let allocInst: AllocRefInstBase
|
|
|
|
var walkUpCache = WalkerCache<SmallProjectionPath>()
|
|
|
|
init(allocation: AllocRefInstBase) { allocInst = allocation }
|
|
|
|
mutating func rootDef(value: Value, path: SmallProjectionPath) -> WalkResult {
|
|
return value == allocInst && path.isEmpty ? .continueWalk : .abortWalk
|
|
}
|
|
}
|
|
|
|
private extension Type {
|
|
func containsSingleReference(in function: Function) -> Bool {
|
|
// Beside class references this also includes `Builtin.NativeObject` and `Builtin.BridgeObject`,
|
|
// which a class reference can be casted to. For example, an array buffer reference is casted to
|
|
// a `Builtin.BridgeObject` before it's destroyed.
|
|
if isHeapObjectReferenceType {
|
|
return true
|
|
}
|
|
if isStruct {
|
|
return getNominalFields(in: function)?.containsSingleReference(in: function) ?? false
|
|
} else if isTuple {
|
|
return tupleElements.containsSingleReference(in: function)
|
|
} else {
|
|
return false
|
|
}
|
|
}
|
|
}
|
|
|
|
private extension Collection where Element == Type {
|
|
func containsSingleReference(in function: Function) -> Bool {
|
|
var nonTrivialFieldFound = false
|
|
for elementTy in self {
|
|
if !elementTy.isTrivial(in: function) {
|
|
if nonTrivialFieldFound {
|
|
return false
|
|
}
|
|
if !elementTy.containsSingleReference(in: function) {
|
|
return false
|
|
}
|
|
nonTrivialFieldFound = true
|
|
}
|
|
}
|
|
return nonTrivialFieldFound
|
|
}
|
|
}
|