mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
2d7500eda6
Today ParenType is used: 1. As the type of ParenExpr 2. As the payload type of an unlabeled single associated value enum case (and the type of ParenPattern). 3. As the type for an `(X)` TypeRepr For 1, this leads to some odd behavior, e.g the type of `(5.0 * 5).squareRoot()` is `(Double)`. For 2, we should be checking the arity of the enum case constructor parameters and the presence of ParenPattern respectively. Eventually we ought to consider replacing Paren/TuplePattern with a PatternList node, similar to ArgumentList. 3 is one case where it could be argued that there's some utility in preserving the sugar of the type that the user wrote. However it's really not clear to me that this is particularly desirable since a bunch of diagnostic logic is already stripping ParenTypes. In cases where we care about how the type was written in source, we really ought to be consulting the TypeRepr.
93 lines
3.3 KiB
Swift
93 lines
3.3 KiB
Swift
// RUN: %batch-code-completion -disable-objc-attr-requires-foundation-module
|
|
|
|
struct FooStruct {
|
|
init() {}
|
|
init(a: Int) {}
|
|
init(a: Int, b: Float) {}
|
|
mutating func instanceFunc2(_ a: Int, b: inout Double) {}
|
|
}
|
|
|
|
func testInsideFunctionCall_1(_ x: inout FooStruct) {
|
|
x.instanceFunc(#^BEFORE_COMMA^#,
|
|
// BEFORE_COMMA-NOT: Pattern/{{.*}}:{{.*}}({{.*}}{#Int#}
|
|
// BEFORE_COMMA-NOT: Decl[InstanceMethod]/{{.*}}:{{.*}}({{.*}}{#Int#}
|
|
}
|
|
func testInsideFunctionCall_2(_ x: inout FooStruct) {
|
|
x.instanceFunc(#^BEFORE_PLACEHOLDER^#<#placeholder#>
|
|
// BEFORE_PLACEHOLDER-NOT: Pattern/{{.*}}:{{.*}}({{.*}}{#Int#}
|
|
// BEFORE_PLACEHOLDER-NOT: Decl[InstanceMethod]/{{.*}}:{{.*}}({{.*}}{#Int#}
|
|
}
|
|
func testConstructor() {
|
|
FooStruct(#^CONSTRUCTOR^#,
|
|
// CONSTRUCTOR: Begin completions, 3 items
|
|
// CONSTRUCTOR-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]: ['('][')'][#FooStruct#];
|
|
// CONSTRUCTOR-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]: ['(']{#a: Int#}[')'][#FooStruct#];
|
|
// CONSTRUCTOR-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]: ['(']{#a: Int#}, {#b: Float#}[')'][#FooStruct#];
|
|
}
|
|
|
|
func firstArg(arg1 arg1: Int, arg2: Int) {}
|
|
func testArg2Name3() {
|
|
firstArg(#^LABELED_FIRSTARG^#,
|
|
// LABELED_FIRSTARG: Begin completions, 1 item
|
|
// LABELED_FIRSTARG-DAG: Decl[FreeFunction]/CurrModule/Flair[ArgLabels]: ['(']{#arg1: Int#}, {#arg2: Int#}[')'][#Void#];
|
|
}
|
|
|
|
func optionalClosure(optClosure: ((Int) -> Void)?, someArg: Int) {
|
|
optClosure?(#^OPTIONAL_CLOSURE^#someArg)
|
|
// OPTIONAL_CLOSURE-DAG: Decl[LocalVar]/Local/TypeRelation[Convertible]: someArg[#Int#]; name=someArg
|
|
}
|
|
|
|
func optionalProtocolMethod() {
|
|
@objc protocol Foo {
|
|
@objc optional func foo(arg: Int)
|
|
}
|
|
|
|
func test(foo: Foo) {
|
|
foo.foo?(#^OPTIONAL_PROTOCOL_METHOD^#)
|
|
// OPTIONAL_PROTOCOL_METHOD-DAG: Decl[InstanceMethod]/CurrNominal/Flair[ArgLabels]: ['(']{#arg: Int#}[')'][#Void#];
|
|
}
|
|
}
|
|
|
|
func subscriptAccess(info: [String: Int]) {
|
|
info[#^SUBSCRIPT_ACCESS^#]
|
|
// SUBSCRIPT_ACCESS: Pattern/CurrNominal/Flair[ArgLabels]: ['[']{#keyPath: KeyPath<[String : Int], Value>#}[']'][#Value#];
|
|
}
|
|
|
|
struct StaticMethods {
|
|
static func before() {
|
|
self.after(num)#^AFTER_STATIC_FUNC^#
|
|
}
|
|
static func after(_ num: Int) -> (() -> Int) {}
|
|
// AFTER_STATIC_FUNC: Begin completions, 2 items
|
|
// AFTER_STATIC_FUNC-DAG: Keyword[self]/CurrNominal: .self[#() -> Int#];
|
|
// AFTER_STATIC_FUNC-DAG: Pattern/CurrModule/Flair[ArgLabels]: ()[#Int#];
|
|
// AFTER_STATIC_FUNC: End completions
|
|
}
|
|
|
|
struct AmbiguousInResultBuilder {
|
|
@resultBuilder
|
|
struct MyViewBuilder {
|
|
static func buildBlock(_ elt: Text) -> Int {
|
|
53
|
|
}
|
|
}
|
|
|
|
struct Text {
|
|
init(verbatim content: String) {}
|
|
init<S>(_ content: S) where S : StringProtocol {}
|
|
}
|
|
|
|
func foo(@MyViewBuilder content: () -> Int) {}
|
|
|
|
func test(myStr: String) {
|
|
foo {
|
|
Text(#^AMBIGUOUS_IN_RESULT_BUILDER?xfail=TODO^#)
|
|
// AMBIGUOUS_IN_RESULT_BUILDER: Begin completions
|
|
// AMBIGUOUS_IN_RESULT_BUILDER-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]: ['(']{#verbatim: String#}[')'][#Text#]; name=verbatim:
|
|
// AMBIGUOUS_IN_RESULT_BUILDER-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]: ['(']{#(content): _#}[')'][#Text#]; name=:
|
|
// AMBIGUOUS_IN_RESULT_BUILDER-DAG: Decl[LocalVar]/Local/TypeRelation[Convertible]: myStr[#String#]; name=myStr
|
|
// AMBIGUOUS_IN_RESULT_BUILDER: End completions
|
|
}
|
|
}
|
|
}
|