mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
d7e39ff570
This is a new attempt at a reexport feature for SPI decls. The previous behavior was to reexport SPIs only between modules with both `@_exported` and an export-as relationship. The limitation on export-as turned out to be too restrictive in some cases. We may be tempted to reexport SPIs through all exported imports. However, the exported imports are very common between clang module and it can lead to surprises if dependencies between clang modules end up exporting SPIs from unexpected modules. As a middle ground, reexport SPI only through Swift `@_exported` dependencies, and not through clang reexports. While this is a new distinction between Swift and clang dependencies, I believe it provides the expected behavior and the result is more straightforward than the current logic. rdar://115901208
189 lines
6.8 KiB
Swift
189 lines
6.8 KiB
Swift
// RUN: %empty-directory(%t)
|
|
// RUN: split-file %s %t
|
|
|
|
/// Build lib defining SPIs
|
|
// RUN: %target-swift-frontend -emit-module %t/Exported.swift \
|
|
// RUN: -module-name Exported -swift-version 5 -I %t \
|
|
// RUN: -enable-library-evolution \
|
|
// RUN: -emit-module-path %t/Exported.swiftmodule \
|
|
// RUN: -emit-module-interface-path %t/Exported.swiftinterface \
|
|
// RUN: -emit-private-module-interface-path %t/Exported.private.swiftinterface
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/Exported.swiftinterface) -I %t
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/Exported.private.swiftinterface) -module-name Exported -I %t
|
|
|
|
/// Build lib reexporting SPIs
|
|
// RUN: %target-swift-frontend -emit-module %t/Exporter.swift \
|
|
// RUN: -module-name Exporter -swift-version 5 -I %t \
|
|
// RUN: -enable-library-evolution \
|
|
// RUN: -emit-module-path %t/Exporter.swiftmodule \
|
|
// RUN: -emit-module-interface-path %t/Exporter.swiftinterface \
|
|
// RUN: -emit-private-module-interface-path %t/Exporter.private.swiftinterface
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/Exporter.swiftinterface) -I %t
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/Exporter.private.swiftinterface) -module-name Exporter -I %t
|
|
|
|
// RUN: %target-swift-frontend -emit-module %t/NonExportedAs.swift \
|
|
// RUN: -module-name NonExportedAs -swift-version 5 -I %t \
|
|
// RUN: -enable-library-evolution \
|
|
// RUN: -emit-module-path %t/NonExportedAs.swiftmodule \
|
|
// RUN: -emit-module-interface-path %t/NonExportedAs.swiftinterface \
|
|
// RUN: -emit-private-module-interface-path %t/NonExportedAs.private.swiftinterface
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/NonExportedAs.swiftinterface) -I %t
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/NonExportedAs.private.swiftinterface) -module-name NonExportedAs -I %t
|
|
|
|
/// Build lib not reexporting SPIs (a normal import)
|
|
// RUN: %target-swift-frontend -emit-module %t/NonExporter.swift \
|
|
// RUN: -module-name NonExporter -swift-version 5 -I %t \
|
|
// RUN: -enable-library-evolution \
|
|
// RUN: -emit-module-path %t/NonExporter.swiftmodule \
|
|
// RUN: -emit-module-interface-path %t/NonExporter.swiftinterface \
|
|
// RUN: -emit-private-module-interface-path %t/NonExporter.private.swiftinterface
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/NonExporter.swiftinterface) -I %t
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/NonExporter.private.swiftinterface) -module-name NonExporter -I %t
|
|
|
|
/// Build client of transitive SPIs and its swiftinterfaces
|
|
// RUN: %target-swift-frontend -emit-module %t/ClientLib.swift \
|
|
// RUN: -module-name ClientLib -swift-version 5 -I %t \
|
|
// RUN: -enable-library-evolution \
|
|
// RUN: -emit-module-path %t/ClientLib.swiftmodule \
|
|
// RUN: -emit-module-interface-path %t/ClientLib.swiftinterface \
|
|
// RUN: -emit-private-module-interface-path %t/ClientLib.private.swiftinterface
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/ClientLib.swiftinterface) -I %t
|
|
// RUN: %target-swift-typecheck-module-from-interface(%t/ClientLib.private.swiftinterface) -module-name ClientLib -I %t
|
|
|
|
/// Test diagnostics of a multifile client
|
|
// RUN: %target-swift-frontend -typecheck \
|
|
// RUN: %t/Client_FileA.swift %t/Client_FileB.swift\
|
|
// RUN: -swift-version 5 -I %t -verify
|
|
|
|
/// SPIs are now reexported by any `@_exported` from Swift modules, no matter
|
|
/// if `export_as` is present or not.
|
|
// RUN: %target-swift-frontend -typecheck \
|
|
// RUN: %t/NonExportedAsClient.swift \
|
|
// RUN: -swift-version 5 -I %t -verify
|
|
|
|
/// Test that SPIs don't leak when not reexported
|
|
// RUN: %target-swift-frontend -typecheck \
|
|
// RUN: %t/NonExporterClient.swift \
|
|
// RUN: -swift-version 5 -I %t -verify
|
|
|
|
/// Test diagnostics against private swiftinterfaces
|
|
// RUN: rm %t/Exported.swiftmodule %t/Exporter.swiftmodule
|
|
// RUN: %target-swift-frontend -typecheck \
|
|
// RUN: %t/Client_FileA.swift %t/Client_FileB.swift\
|
|
// RUN: -swift-version 5 -I %t -verify
|
|
|
|
/// Test diagnostics against public swiftinterfaces
|
|
// RUN: rm %t/Exported.private.swiftinterface %t/Exporter.private.swiftinterface
|
|
// RUN: %target-swift-frontend -typecheck \
|
|
// RUN: %t/PublicClient.swift \
|
|
// RUN: -swift-version 5 -I %t -verify
|
|
|
|
//--- module.modulemap
|
|
module Exported {
|
|
export_as Exporter
|
|
}
|
|
|
|
//--- Exported.swift
|
|
|
|
@_exported import Exported
|
|
|
|
public func exportedPublicFunc() {}
|
|
|
|
@_spi(X) public func exportedSpiFunc() {}
|
|
|
|
@_spi(X) public struct ExportedSpiType {}
|
|
|
|
@_spi(O) public func exportedSpiFuncOtherGroup() {}
|
|
|
|
//--- Exporter.swift
|
|
|
|
@_exported import Exported
|
|
|
|
@_spi(X) public func exporterSpiFunc() {}
|
|
|
|
//--- NonExportedAs.swift
|
|
|
|
@_exported import Exported
|
|
|
|
@_spi(X) public func exporterSpiFunc() {}
|
|
|
|
//--- NonExporter.swift
|
|
|
|
@_spi(X) import Exported
|
|
|
|
@_spi(X) public func exporterSpiFunc() {}
|
|
|
|
//--- ClientLib.swift
|
|
|
|
@_spi(X) import Exporter
|
|
|
|
public func clientA() {
|
|
exportedPublicFunc()
|
|
exportedSpiFunc()
|
|
exporterSpiFunc()
|
|
}
|
|
|
|
@_spi(X) public func spiUseExportedSpiType(_ a: ExportedSpiType) {}
|
|
|
|
//--- Client_FileA.swift
|
|
|
|
@_spi(X) import Exporter
|
|
|
|
public func clientA() {
|
|
exportedPublicFunc()
|
|
exportedSpiFunc()
|
|
exporterSpiFunc()
|
|
exportedSpiFuncOtherGroup() // expected-error {{cannot find 'exportedSpiFuncOtherGroup' in scope}}
|
|
}
|
|
|
|
@inlinable
|
|
public func inlinableClient() {
|
|
exportedPublicFunc()
|
|
exportedSpiFunc() // expected-error {{global function 'exportedSpiFunc()' cannot be used in an '@inlinable' function because it is an SPI imported from 'Exported'}}
|
|
exporterSpiFunc() // expected-error {{global function 'exporterSpiFunc()' cannot be used in an '@inlinable' function because it is an SPI imported from 'Exporter'}}
|
|
}
|
|
|
|
@_spi(X) public func spiUseExportedSpiType(_ a: ExportedSpiType) {}
|
|
|
|
public func publicUseExportedSpiType(_ a: ExportedSpiType) {} // expected-error {{cannot use struct 'ExportedSpiType' here; it is an SPI imported from 'Exported'}}
|
|
|
|
//--- Client_FileB.swift
|
|
|
|
import Exporter
|
|
|
|
public func clientB() {
|
|
exportedPublicFunc()
|
|
exportedSpiFunc() // expected-error {{cannot find 'exportedSpiFunc' in scope}}
|
|
exporterSpiFunc() // expected-error {{cannot find 'exporterSpiFunc' in scope}}
|
|
}
|
|
|
|
//--- NonExportedAsClient.swift
|
|
|
|
@_spi(X) import NonExportedAs
|
|
|
|
public func client() {
|
|
exportedPublicFunc()
|
|
exportedSpiFunc()
|
|
exporterSpiFunc()
|
|
}
|
|
|
|
//--- NonExporterClient.swift
|
|
|
|
@_spi(X) import NonExporter
|
|
|
|
public func client() {
|
|
exportedPublicFunc() // expected-error {{cannot find 'exportedPublicFunc' in scope}}
|
|
exportedSpiFunc() // expected-error {{cannot find 'exportedSpiFunc' in scope}}
|
|
exporterSpiFunc()
|
|
}
|
|
|
|
//--- PublicClient.swift
|
|
|
|
@_spi(X) import Exporter // expected-warning {{'@_spi' import of 'Exporter' will not include any SPI symbols}}
|
|
|
|
public func client() {
|
|
exportedPublicFunc()
|
|
exportedSpiFunc() // expected-error {{cannot find 'exportedSpiFunc' in scope}}
|
|
exporterSpiFunc() // expected-error {{cannot find 'exporterSpiFunc' in scope}}
|
|
}
|