mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
8770c7f826
This PR refactors the ASTDumper to make it more structured, less mistake-prone, and more amenable to future changes. For example:
```cpp
// Before:
void visitUnresolvedDotExpr(UnresolvedDotExpr *E) {
printCommon(E, "unresolved_dot_expr")
<< " field '" << E->getName() << "'";
PrintWithColorRAII(OS, ExprModifierColor)
<< " function_ref=" << getFunctionRefKindStr(E->getFunctionRefKind());
if (E->getBase()) {
OS << '\n';
printRec(E->getBase());
}
PrintWithColorRAII(OS, ParenthesisColor) << ')';
}
// After:
void visitUnresolvedDotExpr(UnresolvedDotExpr *E, StringRef label) {
printCommon(E, "unresolved_dot_expr", label);
printFieldQuoted(E->getName(), "field");
printField(E->getFunctionRefKind(), "function_ref", ExprModifierColor);
if (E->getBase()) {
printRec(E->getBase());
}
printFoot();
}
```
* Values are printed through calls to base class methods, rather than direct access to the underlying `raw_ostream`.
* These methods tend to reduce the chances of bugs like missing/extra spaces or newlines, too much/too little indentation, etc.
* More values are quoted, and unprintable/non-ASCII characters in quoted values are escaped before printing.
* Infrastructure to label child nodes now exists.
* Some weird breaks from the normal "style", like `PatternBindingDecl`'s original and processed initializers, have been brought into line.
* Some types that previously used ad-hoc dumping functions, like conformances and substitution maps, are now structured similarly to the dumper classes.
* I've fixed the odd dumping bug along the way. For example, distributed actors were only marked `actor`, not `distributed actor`.
This PR doesn't change the overall style of AST dumps; they're still pseudo-S-expressions. But the logic that implements this style is now isolated into a relatively small base class, making it feasible to introduce e.g. JSON dumping in the future.
69 lines
3.5 KiB
Swift
69 lines
3.5 KiB
Swift
// RUN: %empty-directory(%t)
|
|
|
|
// FIXME: BEGIN -enable-source-import hackaround
|
|
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -emit-module -o %t %clang-importer-sdk-path/swift-modules/Darwin.swift
|
|
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -emit-module -o %t %clang-importer-sdk-path/swift-modules/Foundation.swift
|
|
// FIXME: END -enable-source-import hackaround
|
|
|
|
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk-nosource -I %t) -typecheck %s -verify
|
|
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk-nosource -I %t) %s -dump-ast -verify | %FileCheck %s
|
|
|
|
// REQUIRES: objc_interop
|
|
|
|
import Foundation
|
|
|
|
func testDowncastObjectToArray(obj: AnyObject, objImplicit: AnyObject!) {
|
|
var nsstrArr1 = (obj as! [NSString])! // expected-error{{cannot force unwrap value of non-optional type '[NSString]'}}{{39-40=}}
|
|
var strArr1 = (obj as! [String])! // expected-error{{cannot force unwrap value of non-optional type '[String]'}}{{35-36=}}
|
|
|
|
var nsstrArr2 = (objImplicit as! [NSString])! // expected-error{{cannot force unwrap value of non-optional type '[NSString]'}}{{47-48=}}
|
|
var strArr2 = (objImplicit as! [String])! // expected-error{{cannot force unwrap value of non-optional type '[String]'}}{{43-44=}}
|
|
}
|
|
|
|
func testArrayDowncast(arr: [AnyObject], arrImplicit: [AnyObject]!) {
|
|
var nsstrArr1 = (arr as! [NSString])! // expected-error{{cannot force unwrap value of non-optional type '[NSString]'}} {{39-40=}}
|
|
var strArr1 = (arr as! [String])! // expected-error{{cannot force unwrap value of non-optional type '[String]'}} {{35-36=}}
|
|
|
|
var nsstrArr2 = (arrImplicit as! [NSString])! // expected-error{{cannot force unwrap value of non-optional type '[NSString]'}} {{47-48=}}
|
|
var strArr2 = (arrImplicit as! [String])! // expected-error{{cannot force unwrap value of non-optional type '[String]'}} {{43-44=}}
|
|
}
|
|
|
|
func testDowncastNSArrayToArray(nsarray: NSArray) {
|
|
_ = nsarray as! [NSString]
|
|
_ = nsarray as! [String]
|
|
}
|
|
|
|
// CHECK-LABEL: testDowncastOptionalObject
|
|
func testDowncastOptionalObject(obj: AnyObject?!) -> [String]? {
|
|
// CHECK: (optional_evaluation_expr implicit type="[String]?"
|
|
// CHECK-NEXT: (inject_into_optional implicit type="[String]?"
|
|
// CHECK: (forced_checked_cast_expr type="[String]"{{.*value_cast}}
|
|
// CHECK: (bind_optional_expr implicit type="AnyObject"
|
|
// CHECK-NEXT: (force_value_expr implicit type="AnyObject?"
|
|
// CHECK-NEXT: (declref_expr type="AnyObject??"
|
|
return obj as! [String]?
|
|
}
|
|
|
|
// CHECK-LABEL: testDowncastOptionalObjectConditional
|
|
func testDowncastOptionalObjectConditional(obj: AnyObject?!) -> [String]?? {
|
|
// CHECK: (optional_evaluation_expr implicit type="[String]??"
|
|
// CHECK-NEXT: (inject_into_optional implicit type="[String]??"
|
|
// CHECK-NEXT: (optional_evaluation_expr implicit type="[String]?"
|
|
// CHECK-NEXT: (inject_into_optional implicit type="[String]?"
|
|
// CHECK-NEXT: (bind_optional_expr implicit type="[String]"
|
|
// CHECK-NEXT: (conditional_checked_cast_expr type="[String]?" {{.*value_cast}} written_type="[String]?"
|
|
// CHECK-NEXT: (bind_optional_expr implicit type="AnyObject"
|
|
// CHECK-NEXT: (bind_optional_expr implicit type="AnyObject?"
|
|
// CHECK-NEXT: (declref_expr type="AnyObject??"
|
|
return obj as? [String]?
|
|
}
|
|
|
|
// Do not crash examining the casted-to (or tested) type if it is
|
|
// invalid (null or error_type).
|
|
class rdar28583595 : NSObject {
|
|
public func test(i: Int) {
|
|
if i is Array {} // expected-error {{generic parameter 'Element' could not be inferred}}
|
|
// expected-note@-1 {{explicitly specify the generic arguments to fix this issue}}
|
|
}
|
|
}
|