Files
swift-mirror/lib/ClangImporter/Serializability.cpp
Gabor Horvath 89323879f5 [Serialization][cxx-interop] Fix a deserialization failure
The deserialization failure is due to missing Clang type when an entity
is being deserialized. This is a regression introduced by #86517. It turns out
the logic to filter out clang types that were synthesized by the Swift
compiler was incorrect and we also filtered out imported types. Also,
the logic was different when the decl was a null pointer.

This PR fixes the logic for the first problem and restores the previous
behavior for null declarations.

Unfortunately, I was not able to come up with a minimal reproducer.

rdar://168932071
2026-01-30 16:05:12 +00:00

366 lines
13 KiB
C++

//===--- Serializability.cpp - Swift serializability of Clang AST refs ----===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
//
// This file implements support for working with StableSerializationPaths
// and determining whether references to Clang declarations and types are
// serializable.
//
// The expectation here is that the same basic predicates are
// interesting for both binary (.swiftmodule) and textual
// (.swiftinterface) serialization. For textual serialization, the
// key question is whether a printed representation will round-trip.
//
//===----------------------------------------------------------------------===//
#include "ImporterImpl.h"
#include "swift/AST/ClangModuleLoader.h"
#include "swift/Basic/Assertions.h"
#include "swift/ClangImporter/SwiftAbstractBasicWriter.h"
using namespace swift;
using ExternalPath = StableSerializationPath::ExternalPath;
static bool isSameDecl(const clang::Decl *lhs, const clang::Decl *rhs) {
return lhs == rhs || lhs->getCanonicalDecl() == rhs->getCanonicalDecl();
}
namespace {
class SerializationPathFinder {
ClangImporter::Implementation &Impl;
public:
SerializationPathFinder(ClangImporter::Implementation &impl) : Impl(impl) {}
StableSerializationPath find(const clang::Decl *decl) {
// We can't do anything with non-NamedDecl declarations.
auto named = dyn_cast<clang::NamedDecl>(decl);
if (!named) return StableSerializationPath();
if (decl->isFromASTFile()) {
return findImportedPath(named);
}
// If the declaration isn't from an AST file, it might be something that
// we built automatically when exporting a Swift type.
if (auto swiftDecl =
Impl.SwiftContext.getSwiftDeclForExportedClangDecl(decl))
return swiftDecl;
// Allow serialization for non-modular headers as well, with the hope that
// we find the same header when doing unqualified lookup during
// deserialization.
return findImportedPath(named);
}
private:
Identifier getIdentifier(const clang::IdentifierInfo *clangIdent) {
return Impl.SwiftContext.getIdentifier(clangIdent->getName());
}
StableSerializationPath findImportedPath(const clang::NamedDecl *decl) {
// We've almost certainly imported this declaration, look for it.
std::optional<Decl *> swiftDeclOpt =
Impl.importDeclCached(decl, Impl.CurrentVersion);
if (swiftDeclOpt.has_value() && swiftDeclOpt.value()) {
auto swiftDecl = swiftDeclOpt.value();
// The serialization code doesn't allow us to cross-reference
// typealias declarations directly. We could fix that, but it's
// easier to just avoid doing so and fall into the external-path code.
if (!isa<TypeAliasDecl>(swiftDecl)) {
// Only accept this declaration if it round-trips.
if (auto swiftClangDecl = swiftDecl->getClangDecl())
if (isSameDecl(decl, swiftClangDecl))
return swiftDecl;
}
}
// Otherwise, check to see if it's something we can easily find.
ExternalPath path;
if (findExternalPath(decl, path))
return std::move(path);
// Otherwise we have no way to find it.
return StableSerializationPath();
}
bool findExternalPath(const clang::NamedDecl *decl, ExternalPath &path) {
if (auto tag = dyn_cast<clang::TagDecl>(decl))
return findExternalPath(tag, path);
if (auto alias = dyn_cast<clang::TypedefNameDecl>(decl))
return findExternalPath(alias, path);
if (auto proto = dyn_cast<clang::ObjCProtocolDecl>(decl))
return findExternalPath(proto, path);
if (auto iface = dyn_cast<clang::ObjCInterfaceDecl>(decl))
return findExternalPath(iface, path);
return false;
}
bool findExternalPath(const clang::TagDecl *decl, ExternalPath &path) {
// We can't handle class template specializations right now.
if (isa<clang::ClassTemplateSpecializationDecl>(decl))
return false;
// Named tags are straightforward.
if (auto name = decl->getIdentifier()) {
if (!findExternalPath(decl->getDeclContext(), path)) return false;
path.add(decl->isEnum() ? ExternalPath::Enum : ExternalPath::Record,
getIdentifier(name));
return true;
}
// We can handle anonymous tags if they're defined in an obvious
// position in a typedef.
if (auto alias = decl->getTypedefNameForAnonDecl()) {
auto aliasTag = alias->getAnonDeclWithTypedefName(/*any*/true);
if (aliasTag && isSameDecl(decl, aliasTag)) {
if (!findExternalPath(alias, path)) return false;
path.add(ExternalPath::TypedefAnonDecl, Identifier());
return true;
}
}
// Otherwise we're stuck.
return false;
}
bool findExternalPath(const clang::TypedefNameDecl *decl,
ExternalPath &path) {
auto name = decl->getIdentifier();
if (!name) return false;
if (!findExternalPath(decl->getDeclContext(), path)) return false;
path.add(ExternalPath::Typedef, getIdentifier(name));
return true;
}
bool findExternalPath(const clang::ObjCProtocolDecl *decl,
ExternalPath &path) {
auto name = decl->getIdentifier();
if (!name) return false;
path.add(ExternalPath::ObjCProtocol, getIdentifier(name));
return true;
}
bool findExternalPath(const clang::ObjCInterfaceDecl *decl,
ExternalPath &path) {
auto name = decl->getIdentifier();
if (!name) return false;
path.add(ExternalPath::ObjCInterface, getIdentifier(name));
return true;
}
bool findExternalPath(const clang::DeclContext *dc, ExternalPath &path) {
// If we've reached the translation unit, we're done.
if (isa<clang::TranslationUnitDecl>(dc))
return true;
// Linkage specifications don't contribute to the path.
if (isa<clang::LinkageSpecDecl>(dc))
return findExternalPath(dc->getParent(), path);
// Handle namespaces.
if (auto ns = dyn_cast<clang::NamespaceDecl>(dc)) {
// Don't try to handle anonymous namespaces.
auto name = ns->getIdentifier();
if (!name) return false;
// Drill to the parent.
if (!findExternalPath(dc->getParent(), path)) return false;
path.Path.push_back({ExternalPath::Namespace, getIdentifier(name)});
return true;
}
// Handle types.
if (auto tag = dyn_cast<clang::TagDecl>(dc))
return findExternalPath(tag, path);
// Can't handle anything else.
return false;
}
};
} // end anonymous namespace
StableSerializationPath
ClangImporter::findStableSerializationPath(const clang::Decl *decl) const {
return Impl.findStableSerializationPath(decl);
}
StableSerializationPath
ClangImporter::Implementation::findStableSerializationPath(
const clang::Decl *decl) {
return SerializationPathFinder(*this).find(decl);
}
const clang::Decl *
ClangImporter::resolveStableSerializationPath(
const StableSerializationPath &path) const {
if (!path) return nullptr;
if (path.isSwiftDecl()) {
return path.getSwiftDecl()->getClangDecl();
}
auto &extpath = path.getExternalPath();
auto &clangCtx = getClangASTContext();
const clang::Decl *decl = nullptr;
// Perform a lookup in the current context (`decl` if set, and
// otherwise the translation unit).
auto lookup = [&](Identifier name) -> clang::DeclContext::lookup_result {
if (name.empty()) return clang::DeclContext::lookup_result();
const clang::DeclContext *dc;
if (decl) {
dc = dyn_cast<clang::DeclContext>(decl);
if (!dc) return clang::DeclContext::lookup_result();
} else {
dc = clangCtx.getTranslationUnitDecl();
}
auto ident = &clangCtx.Idents.get(name.str());
return dc->lookup(ident);
};
for (auto step : extpath.Path) {
// Handle the non-lookup steps here.
if (step.first == ExternalPath::TypedefAnonDecl) {
if (auto alias = dyn_cast_or_null<clang::TypedefNameDecl>(decl))
return alias->getAnonDeclWithTypedefName();
return nullptr;
}
assert(ExternalPath::requiresIdentifier(step.first) &&
"should've handled all non-lookup kinds above");
const clang::Decl *resultDecl = nullptr;
for (auto lookupDecl : lookup(step.second)) {
auto isAcceptable = [](const clang::Decl *decl,
ExternalPath::ComponentKind kind) {
switch (kind) {
case ExternalPath::Record:
return isa<clang::RecordDecl>(decl);
case ExternalPath::Enum:
return isa<clang::EnumDecl>(decl);
case ExternalPath::Namespace:
return isa<clang::NamespaceDecl>(decl);
case ExternalPath::Typedef:
return isa<clang::TypedefNameDecl>(decl);
case ExternalPath::ObjCInterface:
return isa<clang::ObjCInterfaceDecl>(decl);
case ExternalPath::ObjCProtocol:
return isa<clang::ObjCProtocolDecl>(decl);
case ExternalPath::TypedefAnonDecl:
llvm_unreachable("should have been filtered above");
}
llvm_unreachable("bad kind");
};
// Ignore unacceptable declarations.
if (!isAcceptable(lookupDecl, step.first))
continue;
// Bail out if we find multiple matching declarations.
// TODO: make an effort to filter by the target module?
if (resultDecl && !isSameDecl(resultDecl, lookupDecl))
return nullptr;
resultDecl = lookupDecl;
}
// Bail out if lookup found nothing.
if (!resultDecl) return nullptr;
decl = resultDecl;
}
return decl;
}
namespace {
/// The logic here for the supported cases must match the logic in
/// ClangToSwiftBasicWriter in Serialization.cpp.
struct ClangTypeSerializationChecker :
DataStreamBasicWriter<ClangTypeSerializationChecker> {
ClangImporter::Implementation &Impl;
bool IsSerializable = true;
bool HasSwiftDecl = false;
ClangTypeSerializationChecker(ClangImporter::Implementation &impl)
: DataStreamBasicWriter<ClangTypeSerializationChecker>(
impl.getClangASTContext()),
Impl(impl) {}
void writeUInt64(uint64_t value) {}
void writeIdentifier(const clang::IdentifierInfo *ident) {}
void writeStmtRef(const clang::Stmt *stmt) {
if (stmt != nullptr)
IsSerializable = false;
}
void writeDeclRef(const clang::Decl *decl) {
if (!decl)
return;
auto path = Impl.findStableSerializationPath(decl);
if (!path) {
IsSerializable = false;
return;
}
if (Impl.SwiftContext.getSwiftDeclForExportedClangDecl(decl))
HasSwiftDecl = true;
}
void writeSourceLocation(clang::SourceLocation loc) {
// If a source location is written into a type, it's likely to be
// something like the location of a VLA which we shouldn't simply
// replace with a meaningless location.
if (loc.isValid())
IsSerializable = false;
}
void writeAttr(const clang::Attr *attr) {}
// CountAttributedType is a clang type representing a pointer with
// a "counted_by" type attribute and DynamicRangePointerType
// is representing a "__ended_by" type attribute.
// TypeCoupledDeclRefInfo is used to hold information of a declaration
// referenced from an expression argument of "__counted_by(expr)" or
// "__ended_by(expr)".
// Leave it non-serializable for now as we currently don't import
// these types into Swift.
void writeTypeCoupledDeclRefInfo(clang::TypeCoupledDeclRefInfo info) {
llvm_unreachable("TypeCoupledDeclRefInfo shouldn't be reached from swift");
}
void writeHLSLSpirvOperand(clang::SpirvOperand) {
llvm_unreachable("SpirvOperand shouldn't be reached from swift");
}
};
}
ClangModuleLoader::SerializableInfo
ClangImporter::isSerializable(const clang::Type *type,
bool checkCanonical) const {
return Impl.isSerializable(clang::QualType(type, 0), checkCanonical);
}
ClangModuleLoader::SerializableInfo
ClangImporter::Implementation::isSerializable(clang::QualType type,
bool checkCanonical) {
if (checkCanonical)
type = getClangASTContext().getCanonicalType(type);
// Make a pass over the type as if we were serializing it, flagging
// anything that we can't stably serialize.
ClangTypeSerializationChecker checker(*this);
checker.writeQualType(type);
return {checker.IsSerializable, checker.HasSwiftDecl};
}