Files
swift-mirror/lib/DependencyScan/DependencyScanningTool.cpp
Saleem Abdulrasool a8b1dd7136 DependencyScan: avoid re-tokenising the command line in the scanner
We would concatenate and re-tokenise the command line even though we
receive the command line pre-tokenised. This behaviour was introduced in
cfde1fb693 in order to deal with paths
which may be escaped. Rather than joining the arguments and
re-tokenising to unescape the parameters, prefer instead to process each
argument individually to unescape any parameter. By doing this, we are
no longer required to ensure that the parameters are properly shell
quoted prior to passing them to the scanner, but any escaped parameter
will be unescaped.

This repairs some of the test failures in the swift-driver test suite on
Windows.

Adjust the test to properly construct the command line and take the
opportunity to slightly improve the test by changing a few `ASSERT_TRUE`
to `EXPECT_EQ`. The former will terminate the test, the latter will
continue. More importantly, the `_EQ` variant reports the LHS and RHS,
allowing easier debugging.
2026-01-21 11:36:29 -08:00

427 lines
17 KiB
C++

//===------------ DependencyScanningTool.cpp - Swift Compiler -------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2020 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#include "swift/AST/DiagnosticEngine.h"
#include "swift/AST/DiagnosticsFrontend.h"
#include "swift/Basic/LLVMInitialize.h"
#include "swift/Basic/TargetInfo.h"
#include "swift/Basic/ColorUtils.h"
#include "swift/Basic/Defer.h"
#include "swift/DependencyScan/DependencyScanningTool.h"
#include "swift/DependencyScan/DependencyScanImpl.h"
#include "swift/DependencyScan/SerializedModuleDependencyCacheFormat.h"
#include "swift/DependencyScan/StringUtils.h"
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/VirtualOutputBackends.h"
#include <sstream>
namespace {
llvm::ErrorOr<swift::CompilerInvocation>
ConstructInvocation(llvm::ArrayRef<const char *> CommandArgs,
llvm::StringRef executable, llvm::StringRef pwd,
swift::DiagnosticEngine &DE) {
auto unescape =
#if LLVM_ON_WIN32
llvm::cl::TokenizeWindowsCommandLine;
#else
llvm::cl::TokenizeGNUCommandLine;
#endif
llvm::BumpPtrAllocator Alloc;
llvm::SmallVector<std::string, 16> Args;
for (llvm::StringRef Arg : CommandArgs) {
llvm::StringSaver Saver(Alloc);
llvm::SmallVector<const char *, 4> Tokens;
// Unescape any arguments
unescape(Arg, Saver, Tokens, /*MarkEOLs=*/false);
Args.push_back(llvm::join(Tokens, " "));
}
std::vector<const char *> arguments;
arguments.reserve(Args.size());
std::transform(std::begin(Args), std::end(Args), std::back_inserter(arguments),
[](const std::string &S) { return S.data(); });
swift::CompilerInvocation Invocation;
if (Invocation.parseArgs(arguments, DE, nullptr, pwd, executable))
return std::make_error_code(std::errc::invalid_argument);
return Invocation;
}
}
namespace swift {
namespace dependencies {
// Global mutex for target info queries since they are executed separately .
llvm::sys::SmartMutex<true> TargetInfoMutex;
llvm::ErrorOr<swiftscan_string_ref_t> getTargetInfo(ArrayRef<const char *> Command,
const char *main_executable_path) {
llvm::sys::SmartScopedLock<true> Lock(TargetInfoMutex);
SourceManager dummySM;
DiagnosticEngine DE(dummySM);
llvm::ErrorOr<CompilerInvocation> Invocation =
ConstructInvocation(Command, main_executable_path, {}, DE);
if (std::error_code EC = Invocation.getError())
return EC;
// Store the result to a string.
std::string ResultStr;
llvm::raw_string_ostream StrOS(ResultStr);
swift::targetinfo::printTargetInfo(*Invocation, StrOS);
return c_string_utils::create_clone(ResultStr.c_str());
}
void ThreadSafeDiagnosticCollector::handleDiagnostic(SourceManager &SM,
const DiagnosticInfo &Info) {
llvm::sys::SmartScopedLock<true> Lock(DiagnosticConsumerStateLock);
addDiagnostic(SM, Info);
for (auto ChildInfo : Info.ChildDiagnosticInfo) {
addDiagnostic(SM, *ChildInfo);
}
}
void DepScanInMemoryDiagnosticCollector::addDiagnostic(
SourceManager &SM, const DiagnosticInfo &Info) {
// Determine what kind of diagnostic we're emitting.
llvm::SourceMgr::DiagKind SMKind;
switch (Info.Kind) {
case DiagnosticKind::Error:
SMKind = llvm::SourceMgr::DK_Error;
break;
case DiagnosticKind::Warning:
SMKind = llvm::SourceMgr::DK_Warning;
break;
case DiagnosticKind::Note:
SMKind = llvm::SourceMgr::DK_Note;
break;
case DiagnosticKind::Remark:
SMKind = llvm::SourceMgr::DK_Remark;
break;
}
// Translate ranges.
SmallVector<llvm::SMRange, 2> Ranges;
for (auto R : Info.Ranges)
Ranges.push_back(getRawRange(SM, R));
// Translate fix-its.
SmallVector<llvm::SMFixIt, 2> FixIts;
for (DiagnosticInfo::FixIt F : Info.FixIts)
FixIts.push_back(getRawFixIt(SM, F));
// Display the diagnostic.
std::string FormattedMessage;
llvm::raw_string_ostream Stream(FormattedMessage);
// Actually substitute the diagnostic arguments into the diagnostic text.
llvm::SmallString<256> Text;
{
llvm::raw_svector_ostream Out(Text);
DiagnosticEngine::formatDiagnosticText(Out, Info.FormatString,
Info.FormatArgs);
auto Msg = SM.GetMessage(Info.Loc, SMKind, Text, Ranges, FixIts, true);
Msg.print(nullptr, Stream, false, false, false);
Stream.flush();
}
if (Info.Loc && Info.Loc.isValid()) {
auto bufferIdentifier = SM.getDisplayNameForLoc(Info.Loc);
auto lineAndColumnNumbers = SM.getLineAndColumnInBuffer(Info.Loc);
auto importLocation = ScannerImportStatementInfo::ImportDiagnosticLocationInfo(
bufferIdentifier.str(), lineAndColumnNumbers.first,
lineAndColumnNumbers.second);
Diagnostics.push_back(
ScannerDiagnosticInfo{FormattedMessage, SMKind, importLocation});
} else {
Diagnostics.push_back(
ScannerDiagnosticInfo{FormattedMessage, SMKind, std::nullopt});
}
}
swiftscan_diagnostic_set_t *mapCollectedDiagnosticsForOutput(
ArrayRef<DepScanInMemoryDiagnosticCollector::ScannerDiagnosticInfo>
diagnostics) {
auto numDiagnostics = diagnostics.size();
swiftscan_diagnostic_set_t *diagnosticOutput = new swiftscan_diagnostic_set_t;
diagnosticOutput->count = numDiagnostics;
diagnosticOutput->diagnostics =
new swiftscan_diagnostic_info_t[numDiagnostics];
for (size_t i = 0; i < numDiagnostics; ++i) {
const auto &Diagnostic = diagnostics[i];
swiftscan_diagnostic_info_s *diagnosticInfo =
new swiftscan_diagnostic_info_s;
diagnosticInfo->message =
swift::c_string_utils::create_clone(Diagnostic.Message.c_str());
switch (Diagnostic.Severity) {
case llvm::SourceMgr::DK_Error:
diagnosticInfo->severity = SWIFTSCAN_DIAGNOSTIC_SEVERITY_ERROR;
break;
case llvm::SourceMgr::DK_Warning:
diagnosticInfo->severity = SWIFTSCAN_DIAGNOSTIC_SEVERITY_WARNING;
break;
case llvm::SourceMgr::DK_Note:
diagnosticInfo->severity = SWIFTSCAN_DIAGNOSTIC_SEVERITY_NOTE;
break;
case llvm::SourceMgr::DK_Remark:
diagnosticInfo->severity = SWIFTSCAN_DIAGNOSTIC_SEVERITY_REMARK;
break;
}
if (Diagnostic.ImportLocation.has_value()) {
auto importLocation = Diagnostic.ImportLocation.value();
swiftscan_source_location_s *sourceLoc = new swiftscan_source_location_s;
if (importLocation.bufferIdentifier.empty())
sourceLoc->buffer_identifier = swift::c_string_utils::create_null();
else
sourceLoc->buffer_identifier = swift::c_string_utils::create_clone(
importLocation.bufferIdentifier.c_str());
sourceLoc->line_number = importLocation.lineNumber;
sourceLoc->column_number = importLocation.columnNumber;
diagnosticInfo->source_location = sourceLoc;
} else {
diagnosticInfo->source_location = nullptr;
}
diagnosticOutput->diagnostics[i] = diagnosticInfo;
}
return diagnosticOutput;
}
// Generate an instance of the `swiftscan_dependency_graph_s` which contains no
// module dependnecies but captures the diagnostics emitted during the attempted
// scan query.
static swiftscan_dependency_graph_t generateHollowDiagnosticOutput(
ArrayRef<DepScanInMemoryDiagnosticCollector::ScannerDiagnosticInfo>
diagnostics) {
// Create a dependency graph instance
swiftscan_dependency_graph_t hollowResult = new swiftscan_dependency_graph_s;
// Populate the `modules` with a single info for the main module
// containing no dependencies
swiftscan_dependency_set_t *dependencySet = new swiftscan_dependency_set_t;
dependencySet->count = 1;
dependencySet->modules = new swiftscan_dependency_info_t[1];
swiftscan_dependency_info_s *hollowMainModuleInfo =
new swiftscan_dependency_info_s;
dependencySet->modules[0] = hollowMainModuleInfo;
hollowResult->dependencies = dependencySet;
// Other main module details empty
hollowMainModuleInfo->direct_dependencies =
c_string_utils::create_empty_set();
hollowMainModuleInfo->source_files = c_string_utils::create_empty_set();
hollowMainModuleInfo->module_path = c_string_utils::create_null();
hollowResult->main_module_name = c_string_utils::create_clone("unknown");
hollowMainModuleInfo->module_name =
c_string_utils::create_clone("swiftTextual:unknown");
// Hollow info details
swiftscan_module_details_s *hollowDetails = new swiftscan_module_details_s;
hollowDetails->kind = SWIFTSCAN_DEPENDENCY_INFO_SWIFT_TEXTUAL;
hollowDetails->swift_textual_details = {c_string_utils::create_null(),
c_string_utils::create_empty_set(),
c_string_utils::create_null(),
c_string_utils::create_empty_set(),
c_string_utils::create_empty_set(),
c_string_utils::create_empty_set(),
c_string_utils::create_empty_set(),
c_string_utils::create_empty_set(),
c_string_utils::create_empty_set(),
c_string_utils::create_null(),
false,
false,
c_string_utils::create_null(),
c_string_utils::create_null(),
c_string_utils::create_null(),
nullptr,
c_string_utils::create_null(),
c_string_utils::create_null(),
c_string_utils::create_null()};
hollowMainModuleInfo->details = hollowDetails;
// Empty Link Library set
swiftscan_link_library_set_t *hollowLinkLibrarySet =
new swiftscan_link_library_set_t;
hollowLinkLibrarySet->count = 0;
hollowLinkLibrarySet->link_libraries = nullptr;
hollowMainModuleInfo->link_libraries = hollowLinkLibrarySet;
// Empty Import set
swiftscan_import_info_set_t *hollowImportInfoSet =
new swiftscan_import_info_set_t;
hollowImportInfoSet->count = 0;
hollowImportInfoSet->imports = nullptr;
hollowMainModuleInfo->imports = hollowImportInfoSet;
// Populate the diagnostic info
hollowResult->diagnostics =
mapCollectedDiagnosticsForOutput(diagnostics);
return hollowResult;
}
// Generate an instance of the `swiftscan_import_set_t` which contains no
// imports but captures the diagnostics emitted during the attempted
// scan query.
static swiftscan_import_set_t generateHollowDiagnosticOutputImportSet(
ArrayRef<DepScanInMemoryDiagnosticCollector::ScannerDiagnosticInfo>
diagnostics) {
// Create an dependency graph instance
swiftscan_import_set_t hollowResult = new swiftscan_import_set_s;
hollowResult->imports = c_string_utils::create_empty_set();
hollowResult->diagnostics =
mapCollectedDiagnosticsForOutput(diagnostics);
return hollowResult;
}
DependencyScanningTool::DependencyScanningTool()
: ScanningService(std::make_unique<SwiftDependencyScanningService>()) {}
llvm::ErrorOr<swiftscan_dependency_graph_t>
DependencyScanningTool::getDependencies(ArrayRef<const char *> Command,
StringRef WorkingDirectory) {
// Diagnostics which may get collected during scanning instance
// initialization
std::vector<DepScanInMemoryDiagnosticCollector::ScannerDiagnosticInfo>
InitializationDiagnostics;
// The primary instance used to scan the query Swift source-code
auto QueryContext = createScanQueryContext(Command, WorkingDirectory,
InitializationDiagnostics);
if (QueryContext.getError())
return generateHollowDiagnosticOutput(InitializationDiagnostics);
auto ScanInstance = QueryContext->ScanInstance.get();
// Local scan cache instance, wrapping the shared global cache.
ModuleDependenciesCache cache(
ScanInstance->getMainModule()->getNameStr().str(),
ScanInstance->getInvocation().getModuleScanningHash());
// Execute the scanning action, retrieving the in-memory result
auto DependenciesOrErr =
performModuleScan(*ScanningService, cache, *QueryContext);
if (DependenciesOrErr.getError())
return generateHollowDiagnosticOutput(
QueryContext->InMemoryDiagnosticCollector->getDiagnosticsRef());
return std::move(*DependenciesOrErr);
}
llvm::ErrorOr<swiftscan_import_set_t>
DependencyScanningTool::getImports(ArrayRef<const char *> Command,
StringRef WorkingDirectory) {
// Diagnostics which may get collected during scanning instance
// initialization
std::vector<DepScanInMemoryDiagnosticCollector::ScannerDiagnosticInfo>
InitializationDiagnostics;
// The primary instance used to scan the query Swift source-code
auto QueryContext = createScanQueryContext(Command, WorkingDirectory,
InitializationDiagnostics);
if (QueryContext.getError())
return generateHollowDiagnosticOutputImportSet(InitializationDiagnostics);
auto ScanInstance = QueryContext->ScanInstance.get();
// Local scan cache instance, wrapping the shared global cache.
ModuleDependenciesCache cache(
ScanInstance->getMainModule()->getNameStr().str(),
ScanInstance->getInvocation().getModuleScanningHash());
// Execute the pre-scanning action, retrieving the in-memory result
auto DependenciesOrErr =
performModulePrescan(*ScanningService, cache, *QueryContext);
if (DependenciesOrErr.getError())
return generateHollowDiagnosticOutputImportSet(
QueryContext->InMemoryDiagnosticCollector->getDiagnosticsRef());
return std::move(*DependenciesOrErr);
}
llvm::ErrorOr<ScanQueryContext> DependencyScanningTool::createScanQueryContext(
ArrayRef<const char *> CommandArgs, StringRef WorkingDir,
std::vector<DepScanInMemoryDiagnosticCollector::ScannerDiagnosticInfo>
&InitializationDiagnostics) {
// The remainder of this method operates on shared state in the
// scanning service
llvm::sys::SmartScopedLock<true> Lock(DependencyScanningToolStateLock);
// FIXME: Instead, target-info and supported-features queries must use
// `DependencyScanningToolStateLock`, but this currently requires further
// client-side API plumbing.
llvm::sys::SmartScopedLock<true> TargetInfoLock(TargetInfoMutex);
// There may be errors as early as in instance initialization, so we must
// ensure we can catch those
auto ScannerDiagnosticsCollector =
std::make_unique<DepScanInMemoryDiagnosticCollector>();
// State unique to an individual scan
auto Instance = std::make_unique<CompilerInstance>();
Instance->addDiagnosticConsumer(ScannerDiagnosticsCollector.get());
{
// In case we exit with an error, ensure the client gets the
// diagnostics collected so-far.
SWIFT_DEFER {
InitializationDiagnostics = ScannerDiagnosticsCollector->getDiagnostics();
};
// Basic error checking on the arguments
if (CommandArgs.empty()) {
Instance->getDiags().diagnose(SourceLoc(), diag::error_no_frontend_args);
return std::make_error_code(std::errc::invalid_argument);
}
SmallString<128> WorkingDirectory(WorkingDir);
if (WorkingDirectory.empty())
llvm::sys::fs::current_path(WorkingDirectory);
llvm::ErrorOr<CompilerInvocation> Invocation =
ConstructInvocation(CommandArgs, "swiftc", WorkingDirectory,
Instance->getDiags());
if (std::error_code EC = Invocation.getError())
return EC;
// Setup the instance
std::string InstanceSetupError;
if (Instance->setup(*Invocation, InstanceSetupError))
return std::make_error_code(std::errc::not_supported);
Invocation->getFrontendOptions().LLVMArgs.clear();
// Setup the caching service after the instance finishes setup.
if (ScanningService->setupCachingDependencyScanningService(*Instance))
return std::make_error_code(std::errc::invalid_argument);
(void)Instance->getMainModule();
}
auto SerializedDiagnosticsOutputPath =
Instance->getInvocation()
.getSerializedDiagnosticsPathForAtMostOnePrimary();
std::unique_ptr<DiagnosticConsumer> SerailizedDiagnosticsConsumer;
if (!SerializedDiagnosticsOutputPath.empty()) {
SerailizedDiagnosticsConsumer =
swift::serialized_diagnostics::createThreadSafeConsumer(
SerializedDiagnosticsOutputPath, false);
Instance->addDiagnosticConsumer(SerailizedDiagnosticsConsumer.get());
}
return ScanQueryContext{std::move(Instance),
std::move(ScannerDiagnosticsCollector),
std::move(SerailizedDiagnosticsConsumer)};
}
} // namespace dependencies
} // namespace swift