Files
Slava Pestov ac03df3a91 Sema: -enable-crash-on-valid-salvage => -enable-diagnose-valid-salvage
A crash log here doesn't really give any useful information because
the stack trace of the call into the expression type checker doesn't
really determine the outcome. To understand why the solver found a valid
solution in salvage, you really need to look at -debug-constraints
output anyway.

So it's better to just emit a fallback diagnostic instead. This cleans
up some tests as well, since we can show flag the exact expression
that ends up in this code path instead of just expecting a crash.

Note that this flag is already enabled for the standard library and
validation tests, and I'd like to enable it by default soon once we
fix some more bugs.
2026-07-24 14:51:36 -04:00
..