mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
a4eeae2a01
This patch re-enables diagnostics for unannotated C++ functions or methods returning `SWIFT_SHARED_REFERENCE` types. These warnings now fire only **once per source location**, even in the presence of multiple template instantiations. This avoids diagnostic duplication that was a key source of noise in the compilation of larger codebases. These warnings were previously disabled starting in **Swift 6.2** via [PR-#81411](https://github.com/swiftlang/swift/pull/81411) due to concerns around false positives and excessive duplication in projects adopting C++ interop. This patch addresses the duplication issue by adding source-location-based caching, which ensures that a warning is emitted only once per source location, even across template instantiations with different types. However, the false positive issue remains to be investigated and will be addressed in a follow-up patch. Until that happens, the warnings are gated behind a new experimental feature flag: `WarnUnannotatedReturnOfCxxFrt`. This feature will be enabled by default only after thorough qualification and testing on large C++ codebases. rdar://154261051
50 lines
3.1 KiB
Swift
50 lines
3.1 KiB
Swift
// RUN: rm -rf %t
|
|
// RUN: %target-swift-frontend -typecheck -verify -I %S/Inputs %s -cxx-interoperability-mode=upcoming-swift -enable-experimental-feature WarnUnannotatedReturnOfCxxFrt -verify-additional-file %S/Inputs/cxx-functions-and-methods-returning-frt.h -Xcc -Wno-return-type -Xcc -Wno-nullability-completeness
|
|
|
|
// XFAIL: OS=windows-msvc
|
|
// TODO: Enable this on windows when -verify-additional-file issue on Windows Swift CI is resolved
|
|
|
|
// REQUIRES: swift_feature_WarnUnannotatedReturnOfCxxFrt
|
|
|
|
import FunctionsAndMethodsReturningFRT
|
|
import CxxStdlib
|
|
|
|
let frtLocalVar1 = global_function_returning_FRT_with_both_attrs_returns_retained_returns_unretained()
|
|
let frtLocalVar2 = StructWithStaticMethodsReturningFRTWithBothAttributesReturnsRetainedAndReturnsUnretained.StaticMethodReturningFRT()
|
|
let frtLocalVar3 = StructWithAPIsReturningCxxFrt.StaticMethodReturningCxxFrt()
|
|
let frtLocalVar4 = StructWithAPIsReturningCxxFrt.StaticMethodReturningCxxFrtWithAnnotation()
|
|
let frtLocalVar5 = global_function_returning_cxx_frt()
|
|
let frtLocalVar6 = global_function_returning_cxx_frt_with_annotations()
|
|
let frtLocalVar7 = StructWithAPIsReturningNonCxxFrt.StaticMethodReturningNonCxxFrt()
|
|
let frtLocalVar8 = StructWithAPIsReturningNonCxxFrt.StaticMethodReturningNonCxxFrtWithAnnotation()
|
|
let frtLocalVar9 = global_function_returning_non_cxx_frt()
|
|
let frtLocalVar10 = global_function_returning_non_cxx_frt_with_annotations()
|
|
let frtLocalVar11 = StructWithAPIsReturningImmortalReference.StaticMethodReturningImmortalReference()
|
|
let frtLocalVar12 = StructWithAPIsReturningImmortalReference.StaticMethodReturningImmortalReferenceWithAnnotation()
|
|
let frtLocalVar13 = global_function_returning_immortal_reference()
|
|
let frtLocalVar14 = global_function_returning_immortal_reference_with_annotations()
|
|
let frtLocalVar16 = StructWithAPIsReturningUnsafeReference.StaticMethodReturningUnsafeReferenceWithAnnotation()
|
|
let frtLocalVar17 = global_function_returning_unsafe_reference()
|
|
let frtLocalVar18 = global_function_returning_unsafe_reference_with_annotations()
|
|
let x = returnFRTOverloadedOperators()
|
|
let y = returnFRTOverloadedOperators()
|
|
let z = x + y
|
|
let w = x - y
|
|
let f = FunctionVoidToFRTStruct()
|
|
let frt = f()
|
|
let nonFrt = NonFRTStruct()
|
|
let nonFrtLocalVar1 = global_function_returning_templated_retrun_frt_owned(nonFrt)
|
|
let _ = DefaultOwnershipConventionOnCXXForeignRefType.returnRefTyDefUnretained()
|
|
let _ = FunctionAnnotationHasPrecedence.returnRefTyDefUnretained()
|
|
let _ = FunctionAnnotationHasPrecedence.returnRefTyDefUnretainedAnnotatedRetained()
|
|
let _ = DefaultOwnershipSuppressUnannotatedAPIWarning.returnRefType()
|
|
let _ = DefaultOwnershipSuppressUnannotatedAPIWarning.returnRefTyDefUnretainedd()
|
|
let _ = DefaultOwnershipInheritance.createBaseType()
|
|
let _ = DefaultOwnershipInheritance.createDerivedType()
|
|
let _ = DefaultOwnershipInheritance.createDerivedType2()
|
|
let _ = DefaultOwnershipInheritance.createBaseTypeNonDefault()
|
|
let _ = DefaultOwnershipInheritance.createDerivedTypeNonDefault()
|
|
let _ = DefaultOwnershipInheritance.createDerivedTypeNonDefaultUnretained()
|
|
let _ = SourceLocationCaching.FactoryA.make()
|
|
let _ = SourceLocationCaching.FactoryB.make()
|