Files
swift-mirror/lib/SILOptimizer/Utils/PartialApplyCombiner.cpp
Andrew Savonichev 5aa9d3e29b Add partial_apply support for coroutines (#71653)
The patch adds lowering of partial_apply instructions for coroutines.

This pattern seems to trigger a lot of type mismatch errors in IRGen, because
coroutine functions are not substituted in the same way as regular functions
(see the patch 07f03bd2 "Use pattern substitutions to consistently abstract
yields" for more details). 

Other than that, lowering of partial_apply for coroutines is straightforward: we
generate another coroutine that captures arguments passed to the partial_apply
instructions. It calls the original coroutine for yields (first return) and
yields the resulting values. Then it calls the original function's continuation
for return or unwind, and forwards them to the caller as well.

After IRGen, LLVM's Coroutine pass transforms the generated coroutine (along with
all other coroutines) and eliminates llvm.coro.* intrinsics. LIT tests check
LLVM IR after this transformation.

Co-authored-by: Anton Korobeynikov <anton@korobeynikov.info>
Co-authored-by: Arnold Schwaighofer <aschwaighofer@apple.com>
2024-08-08 18:36:42 -07:00

330 lines
12 KiB
C++

//===--- PartialApplyCombiner.cpp -----------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#include "swift/Basic/Assertions.h"
#include "swift/SIL/SILValue.h"
#include "swift/SIL/ScopedAddressUtils.h"
#include "swift/SILOptimizer/Utils/InstOptUtils.h"
#include "swift/SILOptimizer/Utils/OwnershipOptUtils.h"
#include "swift/SILOptimizer/Utils/ValueLifetime.h"
using namespace swift;
namespace {
// Helper class performing the apply{partial_apply(x,y)}(z) -> apply(z,x,y)
// peephole.
class PartialApplyCombiner {
// partial_apply which is being processed.
PartialApplyInst *pai;
// Temporaries created as copies of alloc_stack arguments of
// the partial_apply.
SmallVector<SILValue, 8> tmpCopies;
// Mapping from the original argument of partial_apply to
// the temporary containing its copy.
llvm::DenseMap<SILValue, SILValue> argToTmpCopy;
SILBuilderContext &builderCtxt;
InstModCallbacks &callbacks;
bool copyArgsToTemporaries(ArrayRef<FullApplySite> applies);
void processSingleApply(FullApplySite ai);
public:
PartialApplyCombiner(PartialApplyInst *pai, SILBuilderContext &builderCtxt,
InstModCallbacks &callbacks)
: pai(pai), builderCtxt(builderCtxt), callbacks(callbacks) {}
bool combine();
};
} // end anonymous namespace
/// Copy the original arguments of the partial_apply into newly created
/// temporaries and use these temporaries instead of the original arguments
/// afterwards.
///
/// This is done to "extend" the life-time of original partial_apply arguments,
/// as they may be destroyed/deallocated before the last use by one of the
/// apply instructions.
bool PartialApplyCombiner::copyArgsToTemporaries(
ArrayRef<FullApplySite> applies) {
SmallVector<Operand *, 8> argsToHandle;
// Find args that need extension for a non-stack partial_apply
// A partial_apply [stack]'s argument are not owned by the partial_apply and
// therefore their lifetime must outlive any uses.
if (!pai->isOnStack()) {
getConsumedPartialApplyArgs(pai, argsToHandle,
/*includeTrivialAddrArgs*/ true);
}
// Compute the set of endpoints, which will be used to insert destroys of
// temporaries.
SmallVector<Operand *, 16> paiUses;
// Of course we must include all apply instructions which we want to optimize.
for (FullApplySite ai : applies) {
paiUses.push_back(ai.getCalleeOperand());
}
SmallVector<StoreBorrowInst *, 8> storeBorrowsToHandle;
for (auto arg : pai->getArguments()) {
if (auto *sbi = dyn_cast<StoreBorrowInst>(arg)) {
storeBorrowsToHandle.push_back(sbi);
}
}
if (argsToHandle.empty() && storeBorrowsToHandle.empty()) {
return true;
}
// Also include all destroys in the liverange for the arguments.
// This is needed for later processing in tryDeleteDeadClosure: in case the
// pai gets dead after this optimization, tryDeleteDeadClosure relies on
// that we already copied the pai arguments to extend their lifetimes until
// the pai is finally destroyed.
collectDestroys(pai, paiUses);
ValueLifetimeAnalysis vla(pai,
llvm::ArrayRef(paiUses.begin(), paiUses.end()));
ValueLifetimeAnalysis::Frontier partialApplyFrontier;
// Computing the frontier may fail if the frontier is located on a critical
// edge which we may not split.
if (!vla.computeFrontier(partialApplyFrontier,
ValueLifetimeAnalysis::DontModifyCFG)) {
return false;
}
// We must not introduce copies for move only types.
// TODO: in OSSA, instead of bailing, it's possible to keep the arguments
// alive without the need of copies.
for (Operand *argOp : argsToHandle) {
if (argOp->get()->getType().isMoveOnly())
return false;
}
for (Operand *argOp : argsToHandle) {
SILValue arg = argOp->get();
SILValue tmp = arg;
SILBuilderWithScope builder(pai, builderCtxt);
if (arg->getType().isObject()) {
tmp = builder.emitCopyValueOperation(pai->getLoc(), arg);
} else {
// Copy address-arguments into a stack-allocated temporary.
tmp = builder.createAllocStack(pai->getLoc(), arg->getType());
builder.createCopyAddr(pai->getLoc(), arg, tmp, IsTake_t::IsNotTake,
IsInitialization_t::IsInitialization);
}
argToTmpCopy.insert(std::make_pair(arg, tmp));
// Destroy the argument value (either as SSA value or in the stack-
// allocated temporary) at the end of the partial_apply's lifetime.
endLifetimeAtFrontier(tmp, partialApplyFrontier, builderCtxt, callbacks);
}
DeadEndBlocks deBlocks(pai->getFunction());
for (auto *storeBorrow : storeBorrowsToHandle) {
if (extendStoreBorrow(storeBorrow, paiUses, &deBlocks, callbacks)) {
continue;
}
SILBuilderWithScope builder(pai, builderCtxt);
// Copy address-arguments into a stack-allocated temporary.
auto *asi = builder.createAllocStack(pai->getLoc(), storeBorrow->getType());
builder.createCopyAddr(pai->getLoc(), storeBorrow, asi, IsTake_t::IsNotTake,
IsInitialization_t::IsInitialization);
argToTmpCopy.insert(std::make_pair(storeBorrow, asi));
// Destroy the argument value (either as SSA value or in the stack-
// allocated temporary) at the end of the partial_apply's lifetime.
endLifetimeAtFrontier(asi, partialApplyFrontier, builderCtxt, callbacks);
}
return true;
}
/// Process an apply instruction which uses a partial_apply
/// as its callee.
/// Returns true on success.
void PartialApplyCombiner::processSingleApply(FullApplySite paiAI) {
// The arguments of the final apply instruction.
SmallVector<SILValue, 8> argList;
// First, add the arguments of ther original ApplyInst args.
for (auto Op : paiAI.getArguments())
argList.push_back(Op);
SILBuilderWithScope builder(paiAI.getInstruction(), builderCtxt);
// The thunk that implements the partial apply calls the closure function
// that expects all arguments to be consumed by the function. However, the
// captured arguments are not arguments of *this* apply, so they are not
// pre-incremented. When we combine the partial_apply and this apply into
// a new apply we need to retain all of the closure non-address type
// arguments.
auto destroyloc = RegularLocation::getAutoGeneratedLocation();
auto paramInfo = pai->getSubstCalleeType()->getParameters();
auto partialApplyArgs = pai->getArguments();
for (unsigned i : indices(partialApplyArgs)) {
SILValue arg = partialApplyArgs[i];
if (argToTmpCopy.count(arg))
arg = argToTmpCopy.lookup(arg);
if (paramInfo[paramInfo.size() - partialApplyArgs.size() + i]
.isConsumedInCaller()) {
// Copy the argument as the callee may consume it.
if (arg->getType().isAddress()) {
auto *ASI = builder.createAllocStack(pai->getLoc(), arg->getType());
builder.createCopyAddr(pai->getLoc(), arg, ASI, IsTake_t::IsNotTake,
IsInitialization_t::IsInitialization);
paiAI.insertAfterApplication([&](SILBuilder &builder) {
builder.createDeallocStack(destroyloc, ASI);
});
arg = ASI;
} else {
arg = builder.emitCopyValueOperation(pai->getLoc(), arg);
}
}
// Add the argument of the partial_apply.
argList.push_back(arg);
}
SILValue callee = pai->getCallee();
SubstitutionMap subs = pai->getSubstitutionMap();
if (auto *tai = dyn_cast<TryApplyInst>(paiAI)) {
builder.createTryApply(paiAI.getLoc(), callee, subs, argList,
tai->getNormalBB(), tai->getErrorBB(),
tai->getApplyOptions());
} else if (auto *bai = dyn_cast<BeginApplyInst>(paiAI)) {
auto *newBAI = builder.createBeginApply(paiAI.getLoc(), callee, subs,
argList, bai->getApplyOptions());
callbacks.replaceAllInstUsesPairwiseWith(bai, newBAI);
} else {
auto *apply = cast<ApplyInst>(paiAI);
auto *newAI = builder.createApply(paiAI.getLoc(), callee, subs, argList,
apply->getApplyOptions());
callbacks.replaceValueUsesWith(apply, newAI);
}
// We also need to destroy the partial_apply instruction itself because it is
// consumed by the apply_instruction.
if (!pai->hasCalleeGuaranteedContext()) {
paiAI.insertAfterApplication([&](SILBuilder &builder) {
builder.emitDestroyValueOperation(destroyloc, pai);
});
}
callbacks.deleteInst(paiAI.getInstruction());
}
/// Perform the apply{partial_apply(x,y)}(z) -> apply(z,x,y) peephole
/// by iterating over all uses of the partial_apply and searching
/// for the pattern to transform.
bool PartialApplyCombiner::combine() {
// We need to model @unowned_inner_pointer better before we can do the
// peephole here.
if (llvm::any_of(pai->getSubstCalleeType()->getResults(),
[](SILResultInfo resultInfo) {
return resultInfo.getConvention() ==
ResultConvention::UnownedInnerPointer;
})) {
return false;
}
// Iterate over all uses of the partial_apply
// and look for applies that use it as a callee.
// Worklist of operands.
SmallVector<Operand *, 8> worklist(pai->getUses());
SmallVector<FullApplySite, 4> foundApplySites;
while (!worklist.empty()) {
auto *use = worklist.pop_back_val();
auto *user = use->getUser();
// Recurse through ownership instructions.
if (isa<CopyValueInst>(user) || isa<BeginBorrowInst>(user) ||
isa<MoveValueInst>(user)) {
for (auto *ownershipUse : cast<SingleValueInstruction>(user)->getUses())
worklist.push_back(ownershipUse);
continue;
}
// Recurse through conversions.
if (auto *cfi = dyn_cast<ConvertEscapeToNoEscapeInst>(user)) {
// TODO: Handle argument conversion. All the code in this file needs to be
// cleaned up and generalized. The argument conversion handling in
// optimizeApplyOfConvertFunctionInst should apply to any combine
// involving an apply, not just a specific pattern.
//
// For now, just handle conversion to @noescape, which is irrelevant for
// direct application of the closure.
auto convertCalleeTy = cfi->getType().castTo<SILFunctionType>();
auto escapingCalleeTy = convertCalleeTy->getWithExtInfo(
convertCalleeTy->getExtInfo().withNoEscape(false));
assert(use->get()->getType().castTo<SILFunctionType>() ==
escapingCalleeTy);
(void)escapingCalleeTy;
llvm::copy(cfi->getUses(), std::back_inserter(worklist));
continue;
}
// Look through mark_dependence users of partial_apply [stack].
if (auto *mdi = dyn_cast<MarkDependenceInst>(user)) {
if (mdi->getValue() == use->get() &&
mdi->getValue()->getType().is<SILFunctionType>() &&
mdi->getValue()->getType().castTo<SILFunctionType>()->isNoEscape()) {
llvm::copy(mdi->getUses(), std::back_inserter(worklist));
}
continue;
}
// If this use of a partial_apply is not
// an apply which uses it as a callee, bail.
auto ai = FullApplySite::isa(user);
if (!ai)
continue;
if (ai.getCallee() != use->get())
continue;
// We cannot handle generic apply yet. Bail.
if (ai.hasSubstitutions())
continue;
foundApplySites.push_back(ai);
}
if (foundApplySites.empty())
return false;
if (!copyArgsToTemporaries(foundApplySites))
return false;
for (FullApplySite ai : foundApplySites) {
processSingleApply(ai);
}
return true;
}
//===----------------------------------------------------------------------===//
// Top Level Entrypoint
//===----------------------------------------------------------------------===//
bool swift::tryOptimizeApplyOfPartialApply(PartialApplyInst *pai,
SILBuilderContext &builderCtxt,
InstModCallbacks callbacks) {
PartialApplyCombiner combiner(pai, builderCtxt, callbacks);
return combiner.combine();
}