mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
e4cf74abfa
For the most part, the differences between the diagnostics introduced
by the C++ implementation and the new SwiftIfConfig implementation are
cosmetic, so these are only wording changes.
The one major difference is that we've dropped the warnings about
potential typos in os/arch checks. For example, if one writes:
#if os(bisionos)
// ...
#endif
The C++ implementation will produce a warning "unknown operating system
for build configuration 'os'" with a note asking "did you mean
'visionOS'"? These warnings rely on a static list of known operating
systems and architectures, which is somewhat unfortunate: the whole
point of these checks is that the Swift you're dealing with might not
have support for those operating systems/architectures, so while these
warnings can be helpful in a few cases, they also cause false
positives when porting. Therefore, I chose not to bring them forward.
205 lines
4.8 KiB
Swift
205 lines
4.8 KiB
Swift
// RUN: %target-typecheck-verify-swift -D CONDITION_1
|
|
|
|
postfix operator ++
|
|
postfix func ++ (_: Int) -> Int { 0 }
|
|
|
|
struct OneResult {}
|
|
struct TwoResult {}
|
|
|
|
protocol MyProto {
|
|
func optionalMethod() -> [Int]?
|
|
}
|
|
struct MyStruct {
|
|
var optionalMember: MyProto? { nil }
|
|
func methodOne() -> OneResult { OneResult() }
|
|
func methodTwo() -> TwoResult { TwoResult() }
|
|
}
|
|
|
|
func globalFunc<T>(_ arg: T) -> T { arg }
|
|
|
|
func testBasic(baseExpr: MyStruct) {
|
|
baseExpr
|
|
#if CONDITION_1
|
|
.methodOne() // expected-warning {{result of call to 'methodOne()' is unused}}
|
|
#else
|
|
.methodTwo()
|
|
#endif
|
|
}
|
|
|
|
MyStruct()
|
|
#if CONDITION_1
|
|
.methodOne() // expected-warning {{result of call to 'methodOne()' is unused}}
|
|
#else
|
|
.methodTwo()
|
|
#endif
|
|
|
|
|
|
func testInvalidContent(baseExpr: MyStruct, otherExpr: Int) {
|
|
baseExpr // expected-warning {{expression of type 'MyStruct' is unused}}
|
|
#if CONDITION_1
|
|
{ $0 + 1 } // expected-error {{closure expression is unused}}
|
|
#endif
|
|
|
|
baseExpr // expected-warning {{expression of type 'MyStruct' is unused}}
|
|
#if CONDITION_1
|
|
+ otherExpr // expected-error {{unary operator cannot be separated from its operand}}
|
|
// expected-warning@-1 {{result of operator '+' is unused}}
|
|
#endif
|
|
|
|
baseExpr
|
|
#if CONDITION_1
|
|
.methodOne() // expected-warning {{result of call to 'methodOne()' is unused}}
|
|
|
|
print("debug") // expected-error {{unexpected tokens in '#if' expression body}}
|
|
#endif
|
|
}
|
|
|
|
func testExprKind(baseExpr: MyStruct, idx: Int) {
|
|
baseExpr
|
|
#if CONDITION_1
|
|
.optionalMember?.optionalMethod()![idx]++ // expected-warning {{result of operator '++' is unused}}
|
|
#else
|
|
.otherMethod(arg) {
|
|
//...
|
|
}
|
|
#endif
|
|
|
|
baseExpr
|
|
#if CONDITION_1
|
|
.methodOne() + 12 // expected-error {{unexpected tokens in '#if' expression body}}
|
|
// expected-warning@-1 {{result of call to 'methodOne()' is unused}}
|
|
#endif
|
|
}
|
|
|
|
func emptyElse(baseExpr: MyStruct) {
|
|
baseExpr
|
|
#if CONDITION_1
|
|
.methodOne() // expected-warning {{result of call to 'methodOne()' is unused}}
|
|
#elseif CONDITION_2
|
|
// OK. Do nothing.
|
|
#endif
|
|
|
|
baseExpr
|
|
#if CONDITION_1
|
|
.methodOne() // expected-warning {{result of call to 'methodOne()' is unused}}
|
|
#elseif CONDITION_2
|
|
return // expected-error {{unexpected tokens in '#if' expression body}}
|
|
#endif
|
|
}
|
|
|
|
func consecutiveIfConfig(baseExpr: MyStruct) {
|
|
baseExpr
|
|
#if CONDITION_1
|
|
.methodOne()
|
|
#endif
|
|
#if CONDITION_2
|
|
.methodTwo()
|
|
#endif
|
|
.unknownMethod() // expected-error {{value of type 'OneResult' has no member 'unknownMethod'}}
|
|
}
|
|
|
|
func nestedIfConfig(baseExpr: MyStruct) {
|
|
baseExpr
|
|
#if CONDITION_1
|
|
#if CONDITION_2
|
|
.methodOne()
|
|
#endif
|
|
#if CONDITION_1
|
|
.methodTwo() // expected-warning {{result of call to 'methodTwo()' is unused}}
|
|
#endif
|
|
#else
|
|
.unknownMethod1()
|
|
#if CONDITION_2
|
|
.unknownMethod2()
|
|
#endif
|
|
#endif
|
|
}
|
|
|
|
func ifconfigExprInExpr(baseExpr: MyStruct) {
|
|
globalFunc( // expected-warning {{result of call to 'globalFunc' is unused}}
|
|
baseExpr
|
|
#if CONDITION_1
|
|
.methodOne()
|
|
#else
|
|
.methodTwo()
|
|
#endif
|
|
)
|
|
}
|
|
|
|
func canImportVersioned() {
|
|
#if canImport(A, _version: 2)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _version: 2.2)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _version: 2.2.2)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _version: 2.2.2.2)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _version: 2.2.2.2.2) // expected-warning {{trailing components of version '2.2.2.2' are ignored}}
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _underlyingVersion: 4)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _underlyingVersion: 2.200)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _underlyingVersion: 2.200.1)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _underlyingVersion: 2.200.1.3)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, unknown: 2.2) // expected-error {{second parameter of 'canImport' should be labeled as _version or _underlyingVersion}}
|
|
let a = 1
|
|
#endif
|
|
|
|
|
|
#if canImport(A,)
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, 2.2) // expected-error {{second parameter of 'canImport' should be labeled as _version or _underlyingVersion}}
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, 2.2, 1.1) // expected-error {{'canImport' can take only two parameters}}
|
|
let a = 1
|
|
#endif
|
|
|
|
// expected-error@+1{{'canImport' version check has invalid version ''}}
|
|
#if canImport(A, _version:) // expected-error {{expected expression in list of expressions}}
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _version: "") // expected-error {{'canImport' version check has invalid version '""'}}
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _version: >=2.2) // expected-error {{'canImport' version check has invalid version '>=2.2'}}
|
|
let a = 1
|
|
#endif
|
|
|
|
// expected-error@+1{{'canImport' version check has invalid version '20A301'}}
|
|
#if canImport(A, _version: 20A301) // expected-error {{'A' is not a valid digit in integer literal}}
|
|
let a = 1
|
|
#endif
|
|
|
|
#if canImport(A, _version: "20A301") // expected-error {{'canImport' version check has invalid version '"20A301"'}}
|
|
let a = 1
|
|
#endif
|
|
}
|