mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
2d881bdc9c
With this patch, I'm flipping the polarity of things. The flag `-enable-experimental-feature ManualOwnership` now turns on the diagnostics, but they're all silenced by default. So, you need to add -Wwarning or -Werror to your build settings to turn on the specific diagnostics you care about. These are the diagnostic groups relevant to the feature: - SemanticCopies aka "explicit copies mode" - DynamicExclusivity For example, the build setting `-Werror SemanticCopies` now gives you errors about explicit copies, just as before, but now you can make them just warnings with -Wwarning. To opt-out a declaration from everything when using the feature, use @_noManualOwnership. @_manualOwnership is no longer an attribute as a result. resolves rdar://163372569
72 lines
2.4 KiB
Swift
72 lines
2.4 KiB
Swift
// RUN: %target-swift-frontend %s -emit-sil -verify \
|
|
// RUN: -enable-experimental-feature ManualOwnership \
|
|
// RUN: -Wwarning DynamicExclusivity
|
|
|
|
// REQUIRES: swift_feature_ManualOwnership
|
|
|
|
protocol NutritionInfo {
|
|
var calories: Int { get }
|
|
}
|
|
|
|
public class Food: NutritionInfo {
|
|
var calories = 0
|
|
}
|
|
|
|
public class Donut : Food {
|
|
|
|
let next: Donut? = nil
|
|
|
|
override init() {
|
|
super.init()
|
|
self.calories = 100 // expected-warning {{exclusive access here will be checked at runtime}}
|
|
}
|
|
|
|
convenience init(calories c: Int) {
|
|
self.init()
|
|
self.calories = c // expected-warning {{exclusive access here will be checked at runtime}}
|
|
}
|
|
}
|
|
|
|
extension Int { func greaterThanZero() -> Bool { self > 0 } }
|
|
|
|
var expectedCalories: Array<Int> = [120, 203, 1502]
|
|
|
|
func accessGlobal_map() -> Array<Donut> {
|
|
return expectedCalories.map(Donut.init(calories:)) // expected-warning {{accessing 'expectedCalories' here may incur runtime exclusivity check, because it involves a global variable}}
|
|
}
|
|
|
|
func accessGlobal_member() -> Int {
|
|
return expectedCalories.count // expected-warning {{accessing 'expectedCalories' here may incur runtime exclusivity check, because it involves a global variable}}
|
|
}
|
|
|
|
@_noManualOwnership
|
|
func accessGlobal_member_DISABLED() -> Int {
|
|
return expectedCalories.count
|
|
}
|
|
|
|
var globalDonut: Donut = Donut()
|
|
|
|
func accessGlobalClass() {
|
|
let x = globalDonut.calories // expected-warning {{accessing 'globalDonut' here may incur runtime exclusivity check, because it involves a global variable}}
|
|
// expected-warning@-1 {{exclusive access here will be checked at runtime}}
|
|
|
|
expectedCalories.append(x) // expected-warning {{accessing 'expectedCalories' here may incur runtime exclusivity check, because it involves a global variable}}
|
|
}
|
|
|
|
func accessClassSimple(_ d2: Donut) -> Int {
|
|
let d1 = Donut()
|
|
return d1.calories // expected-warning {{exclusive access here will be checked at runtime}}
|
|
+ d2.calories // expected-warning {{exclusive access here will be checked at runtime}}
|
|
}
|
|
|
|
func accessClassParam_chain(_ donut: Donut) -> Int {
|
|
return donut.next?.next?.calories ?? Int.max
|
|
// expected-warning@-1 {{exclusive access here will be checked at runtime}}
|
|
}
|
|
|
|
func accessClassLocal_chain() -> Int {
|
|
let donut = Donut()
|
|
return donut.next?.next?.calories ?? Int.max
|
|
// expected-warning@-1 {{exclusive access here will be checked at runtime}}
|
|
}
|