mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
3309809429
It used to be done with a library intrinsic which returns the array and an element address pointer. A `mark_dependence` was used to "connect" the two results. But this resulted in completely wrong OSSA after inlining. It just didn't get caught be the verifier because the SIL was obfuscated by address-pointer conversions. Now we don't use the second result (= the element address) of the intrinsic but generate a correct borrow scope from the first (= array) result. Within that borrow scope we project out the element address with a `ref_tail_addr` instruction. This relies on knowledge of the internal Array data structures. However those data structures are baked into the ABI since a long time and will not change.
76 lines
4.0 KiB
Swift
76 lines
4.0 KiB
Swift
|
|
// RUN: %target-swift-emit-silgen -Xllvm -sil-print-types -module-name scalar_to_tuple_args %s | %FileCheck %s
|
|
|
|
func inoutWithDefaults(_ x: inout Int, y: Int = 0, z: Int = 0) {}
|
|
func inoutWithCallerSideDefaults(_ x: inout Int, y: Int = #line) {}
|
|
|
|
func scalarWithDefaults(_ x: Int, y: Int = 0, z: Int = 0) {}
|
|
func scalarWithCallerSideDefaults(_ x: Int, y: Int = #line) {}
|
|
|
|
func tupleWithDefaults(x: (Int, Int), y: Int = 0, z: Int = 0) {}
|
|
|
|
func variadicFirst(_ x: Int...) {}
|
|
func variadicSecond(_ x: Int, _ y: Int...) {}
|
|
|
|
var x = 0
|
|
// CHECK: [[X_ADDR:%.*]] = global_addr @$s20scalar_to_tuple_args1xSivp : $*Int
|
|
// CHECK: [[WRITE:%.*]] = begin_access [modify] [dynamic] [[X_ADDR]] : $*Int
|
|
// CHECK: [[DEFAULT_Y:%.*]] = apply {{.*}} : $@convention(thin) () -> Int
|
|
// CHECK: [[DEFAULT_Z:%.*]] = apply {{.*}} : $@convention(thin) () -> Int
|
|
// CHECK: [[INOUT_WITH_DEFAULTS:%.*]] = function_ref @$s20scalar_to_tuple_args17inoutWithDefaults_1y1zySiz_S2itF
|
|
// CHECK: apply [[INOUT_WITH_DEFAULTS]]([[WRITE]], [[DEFAULT_Y]], [[DEFAULT_Z]])
|
|
inoutWithDefaults(&x)
|
|
|
|
// CHECK: [[LINE_VAL:%.*]] = integer_literal
|
|
// CHECK: [[LINE:%.*]] = apply {{.*}}([[LINE_VAL]]
|
|
// CHECK: [[WRITE:%.*]] = begin_access [modify] [dynamic] [[X_ADDR]] : $*Int
|
|
// CHECK: [[INOUT_WITH_CALLER_DEFAULTS:%.*]] = function_ref @$s20scalar_to_tuple_args27inoutWithCallerSideDefaults_1yySiz_SitF
|
|
// CHECK: apply [[INOUT_WITH_CALLER_DEFAULTS]]([[WRITE]], [[LINE]])
|
|
inoutWithCallerSideDefaults(&x)
|
|
|
|
// CHECK: [[READ:%.*]] = begin_access [read] [dynamic] [[X_ADDR]] : $*Int
|
|
// CHECK: [[X:%.*]] = load [trivial] [[READ]]
|
|
// CHECK: [[DEFAULT_Y:%.*]] = apply {{.*}} : $@convention(thin) () -> Int
|
|
// CHECK: [[DEFAULT_Z:%.*]] = apply {{.*}} : $@convention(thin) () -> Int
|
|
// CHECK: [[SCALAR_WITH_DEFAULTS:%.*]] = function_ref @$s20scalar_to_tuple_args0A12WithDefaults_1y1zySi_S2itF
|
|
// CHECK: apply [[SCALAR_WITH_DEFAULTS]]([[X]], [[DEFAULT_Y]], [[DEFAULT_Z]])
|
|
scalarWithDefaults(x)
|
|
|
|
// CHECK: [[X:%.*]] = load [trivial] [[X_ADDR]]
|
|
// CHECK: [[LINE_VAL:%.*]] = integer_literal
|
|
// CHECK: [[LINE:%.*]] = apply {{.*}}([[LINE_VAL]]
|
|
// CHECK: [[SCALAR_WITH_CALLER_DEFAULTS:%.*]] = function_ref @$s20scalar_to_tuple_args0A22WithCallerSideDefaults_1yySi_SitF
|
|
// CHECK: apply [[SCALAR_WITH_CALLER_DEFAULTS]]([[X]], [[LINE]])
|
|
scalarWithCallerSideDefaults(x)
|
|
|
|
// CHECK: [[READ:%.*]] = begin_access [read] [dynamic] [[X_ADDR]] : $*Int
|
|
// CHECK: [[X1:%.*]] = load [trivial] [[READ]]
|
|
// CHECK: [[READ:%.*]] = begin_access [read] [dynamic] [[X_ADDR]] : $*Int
|
|
// CHECK: [[X2:%.*]] = load [trivial] [[READ]]
|
|
// CHECK: [[DEFAULT_Y:%.*]] = apply {{.*}} : $@convention(thin) () -> Int
|
|
// CHECK: [[DEFAULT_Z:%.*]] = apply {{.*}} : $@convention(thin) () -> Int
|
|
// CHECK: [[TUPLE_WITH_DEFAULTS:%.*]] = function_ref @$s20scalar_to_tuple_args0C12WithDefaults1x1y1zySi_Sit_S2itF
|
|
// CHECK: apply [[TUPLE_WITH_DEFAULTS]]([[X1]], [[X2]], [[DEFAULT_Y]], [[DEFAULT_Z]])
|
|
tupleWithDefaults(x: (x,x))
|
|
|
|
// CHECK: [[ALLOC_ARRAY:%.*]] = apply {{.*}} -> (@owned Array<τ_0_0>, Builtin.RawPointer)
|
|
// CHECK: ([[ARRAY:%.*]], [[MEMORY:%.*]]) = destructure_tuple [[ALLOC_ARRAY]]
|
|
// CHECK: [[BB:%.*]] = begin_borrow [[ARRAY]]
|
|
// CHECK: = struct_extract [[BB]]
|
|
// CHECK: [[ADDR:%.*]] = ref_tail_addr
|
|
// CHECK: [[READ:%.*]] = begin_access [read] [dynamic] [[X_ADDR]] : $*Int
|
|
// CHECK: copy_addr [[READ]] to [init] [[ADDR]]
|
|
// CHECK: [[FIN_FN:%.*]] = function_ref @$ss27_finalizeUninitializedArrayySayxGABnlF
|
|
// CHECK: [[FIN_ARR:%.*]] = apply [[FIN_FN]]<Int>([[ARRAY]])
|
|
// CHECK: [[VARIADIC_FIRST:%.*]] = function_ref @$s20scalar_to_tuple_args13variadicFirstyySid_tF
|
|
// CHECK: apply [[VARIADIC_FIRST]]([[FIN_ARR]])
|
|
variadicFirst(x)
|
|
|
|
// CHECK: [[READ:%.*]] = begin_access [read] [dynamic] [[X_ADDR]] : $*Int
|
|
// CHECK: [[X:%.*]] = load [trivial] [[READ]]
|
|
// CHECK: [[ALLOC_ARRAY:%.*]] = apply {{.*}} -> (@owned Array<τ_0_0>, Builtin.RawPointer)
|
|
// CHECK: ([[ARRAY:%.*]], [[MEMORY:%.*]]) = destructure_tuple [[ALLOC_ARRAY]]
|
|
// CHECK: [[VARIADIC_SECOND:%.*]] = function_ref @$s20scalar_to_tuple_args14variadicSecondyySi_SidtF
|
|
// CHECK: apply [[VARIADIC_SECOND]]([[X]], [[ARRAY]])
|
|
variadicSecond(x)
|