mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
0af0d5fddc
In a previous commit, I banned in the verifier any SILValue from producing ValueOwnershipKind::Any in preparation for this. This change arises out of discussions in between John, Andy, and I around ValueOwnershipKind::Trivial. The specific realization was that this ownership kind was an unnecessary conflation of the a type system idea (triviality) with an ownership idea (@any, an ownership kind that is compatible with any other ownership kind at value merge points and can only create). This caused the ownership model to have to contort to handle the non-payloaded or trivial cases of non-trivial enums. This is unnecessary if we just eliminate the any case and in the verifier separately verify that trivial => @any (notice that we do not verify that @any => trivial). NOTE: This is technically an NFC intended change since I am just replacing Trivial with Any. That is why if you look at the tests you will see that I actually did not need to update anything except removing some @trivial ownership since @any ownership is represented without writing @any in the parsed sil. rdar://46294760
35 lines
1.1 KiB
C++
35 lines
1.1 KiB
C++
//===--- SILUndef.cpp -----------------------------------------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "swift/SIL/SILUndef.h"
|
|
#include "swift/SIL/SILModule.h"
|
|
|
|
using namespace swift;
|
|
|
|
static ValueOwnershipKind getOwnershipKindForUndef(SILType type, SILModule &m) {
|
|
if (type.isTrivial(m))
|
|
return ValueOwnershipKind::Any;
|
|
return ValueOwnershipKind::Owned;
|
|
}
|
|
|
|
SILUndef::SILUndef(SILType type, SILModule &m)
|
|
: ValueBase(ValueKind::SILUndef, type, IsRepresentative::Yes),
|
|
ownershipKind(getOwnershipKindForUndef(type, m)) {}
|
|
|
|
SILUndef *SILUndef::get(SILType ty, SILModule &m) {
|
|
// Unique these.
|
|
SILUndef *&entry = m.UndefValues[ty];
|
|
if (entry == nullptr)
|
|
entry = new (m) SILUndef(ty, m);
|
|
return entry;
|
|
}
|