mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
872a1c8592
We had a bit of back-and-forth over how to handle type-check errors in added expressions. Obviously all added expressions *should* type-check -- but we don't want the compiler (and, by extension, the XPC playground service) crashing when they don't. So the ErrorTypes from failed type-checks must not leak into existing code. In this solution, we use a convenience class (Added) that wraps an expression. It marks expressions we've constructed -- and we're only allowed to type-check Added<Expr*>s. (This isn't fully enforced -- you could still have Added<Expr*>s that refer to existing Expr*s) but adding this and plumbing it through caught most of the problems. I also added checks to various places that weren't checking whether type checking succeeded. In one case where we were emitting a source location for one element in a TupleExpr but not emitting source locations for the others (which caused dumping to assert) I eliminated that source location. Finally I added several test cases. These cases used to crash; one of them works perfectly now and I've XFAILed the other two. <rdar://problem/20444876> Swift SVN r29842
18 lines
586 B
Swift
18 lines
586 B
Swift
// RUN: rm -rf %t && mkdir %t
|
|
// RUN: cp %s %t/main.swift
|
|
// RUN: %target-build-swift -Xfrontend -playground -Xfrontend -debugger-support -o %t/main %S/Inputs/PlaygroundsRuntime.swift %t/main.swift
|
|
// RUN: %target-run %t/main | FileCheck %s
|
|
// REQUIRES: executable_test
|
|
|
|
// FIXME: We need to instrument mutations of objects that are accessed in
|
|
// arbitrary ways, not just successive member references.
|
|
// XFAIL: *
|
|
|
|
struct S {
|
|
var a = [Int]()
|
|
}
|
|
var s = [S()]
|
|
s[0].a.append(3)
|
|
// CHECK: [{{.*}}] $builtin_log[s='[main.S(a: [])]']
|
|
// CHECK-NEXT: [{{.*}}] $builtin_log[a='[3])]']
|