mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
f854547c55
I also removed the -verify-sil-ownership flag in favor of a disable flag -disable-sil-ownership-verifier. I used this on only two tests that still need work to get them to pass with ownership, but whose problems are well understood, small corner cases. I am going to fix them in follow on commits. I detail them below: 1. SILOptimizer/definite_init_inout_super_init.swift. This is a test case where DI is supposed to error. The only problem is that we crash before we error since the code emitting by SILGen to trigger this error does not pass ownership invariants. I have spoken with JoeG about this and he suggested that I fix this earlier in the compiler. Since we do not run the ownership verifier without asserts enabled, this should not affect compiler users. Given that it has triggered DI errors previously I think it is safe to disable ownership here. 2. PrintAsObjC/extensions.swift. In this case, the signature generated by type lowering for one of the thunks here uses an unsafe +0 return value instead of doing an autorelease return. The ownership checker rightly flags this leak. This is going to require either an AST level change or a change to TypeLowering. I think it is safe to turn this off since it is such a corner case that it was found by a test that has nothing to do with it. rdar://43398898
97 lines
5.8 KiB
Swift
97 lines
5.8 KiB
Swift
|
|
// RUN: %target-swift-emit-sil -module-name rethrows -verify %s | %FileCheck %s
|
|
|
|
@discardableResult
|
|
func rethrower(_ fn: () throws -> Int) rethrows -> Int {
|
|
return try fn()
|
|
}
|
|
func thrower() throws -> Int { return 0 }
|
|
func nonthrower() -> Int { return 0 }
|
|
|
|
// CHECK-LABEL: sil hidden @$s8rethrows5test0yyKF : $@convention(thin) () -> @error Error {
|
|
// CHECK: [[THROWER:%.*]] = function_ref @$s8rethrows7throwerSiyKF : $@convention(thin) () -> (Int, @error Error)
|
|
// CHECK: [[T0:%.*]] = thin_to_thick_function [[THROWER]]
|
|
// CHECK: [[CVT:%.*]] = convert_escape_to_noescape [[T0]]
|
|
// CHECK: [[RETHROWER:%.*]] = function_ref @$s8rethrows9rethroweryS2iyKXEKF : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error)
|
|
// CHECK: try_apply [[RETHROWER]]([[CVT]]) : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error), normal [[NORMAL:bb1]], error [[ERROR:bb2]]
|
|
// CHECK: [[NORMAL]]([[RESULT_T0:%.*]] : $Int):
|
|
// FIXME - SR-6979: We should be able to eliminate this strong_release.
|
|
// CHECK-NEXT: strong_release [[T0]]
|
|
// CHECK-NEXT: strong_release [[T0]]
|
|
// CHECK-NEXT: [[T1:%.*]] = tuple ()
|
|
// CHECK-NEXT: return [[T1]]
|
|
// CHECK: [[ERROR]]([[RESULT_T0:%.*]] : $Error):
|
|
// FIXME - SR-6979: We should be able to eliminate this strong_release.
|
|
// CHECK-NEXT: strong_release [[T0]]
|
|
// CHECK-NEXT: strong_release [[T0]]
|
|
// CHECK-NEXT: throw [[RESULT_T0]]
|
|
func test0() throws {
|
|
try rethrower(thrower)
|
|
}
|
|
|
|
// CHECK-LABEL: sil hidden @$s8rethrows5test1yyKF : $@convention(thin) () -> @error Error {
|
|
// CHECK: [[CLOSURE:%.*]] = function_ref @$s8rethrows5test1yyKFSiyKXEfU_ : $@convention(thin) () -> (Int, @error Error)
|
|
// CHECK: [[CVT:%.*]] = convert_function [[CLOSURE]]
|
|
// CHECK: [[T0:%.*]] = thin_to_thick_function [[CVT]]
|
|
// CHECK: [[RETHROWER:%.*]] = function_ref @$s8rethrows9rethroweryS2iyKXEKF : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error)
|
|
// CHECK: try_apply [[RETHROWER]]([[T0]]) : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error), normal [[NORMAL:bb1]], error [[ERROR:bb2]]
|
|
// CHECK: [[NORMAL]]({{%.*}} : $Int):
|
|
// CHECK-NEXT: [[T1:%.*]] = tuple ()
|
|
// CHECK-NEXT: return [[T1]]
|
|
// CHECK: [[ERROR]]([[ERROR:%.*]] : $Error):
|
|
// CHECK-NEXT: throw [[ERROR]]
|
|
// Closure.
|
|
// CHECK-LABEL: sil private @$s8rethrows5test1yyKFSiyKXEfU_ : $@convention(thin) () -> (Int, @error Error) {
|
|
// CHECK: [[THROWER:%.*]] = function_ref @$s8rethrows7throwerSiyKF : $@convention(thin) () -> (Int, @error Error)
|
|
// CHECK: [[T0:%.*]] = thin_to_thick_function [[THROWER]]
|
|
// CHECK: [[CVT:%.*]] = convert_escape_to_noescape [[T0]]
|
|
// CHECK: [[RETHROWER:%.*]] = function_ref @$s8rethrows9rethroweryS2iyKXEKF : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error)
|
|
// CHECK: try_apply [[RETHROWER]]([[CVT]]) : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error), normal [[NORMAL:bb1]], error [[ERROR:bb2]]
|
|
// CHECK: [[NORMAL]]([[RESULT:%.*]] : $Int):
|
|
// CHECK-NEXT: strong_release [[T0]]
|
|
// CHECK-NEXT: strong_release [[T0]]
|
|
// CHECK-NEXT: return [[RESULT]]
|
|
// CHECK: [[ERROR]]([[ERROR:%.*]] : $Error):
|
|
// CHECK-NEXT: strong_release [[T0]]
|
|
// CHECK-NEXT: strong_release [[T0]]
|
|
// CHECK-NEXT: throw [[ERROR]]
|
|
func test1() throws {
|
|
try rethrower { try rethrower(thrower) }
|
|
}
|
|
|
|
// CHECK-LABEL: sil hidden @$s8rethrows5test2yyF : $@convention(thin) () -> () {
|
|
// CHECK: [[NONTHROWER:%.*]] = function_ref @$s8rethrows10nonthrowerSiyF : $@convention(thin) () -> Int
|
|
// CHECK: [[T0:%.*]] = thin_to_thick_function [[NONTHROWER]]
|
|
// CHECK: [[T1:%.*]] = convert_function [[T0]] : $@callee_guaranteed () -> Int to $@callee_guaranteed () -> (Int, @error Error)
|
|
// CHECK: [[T2:%.*]] = convert_escape_to_noescape [[T1]]
|
|
// CHECK: [[RETHROWER:%.*]] = function_ref @$s8rethrows9rethroweryS2iyKXEKF : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error)
|
|
// CHECK: try_apply [[RETHROWER]]([[T2]]) : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error), normal [[NORMAL:bb1]], error [[ERROR:bb2]]
|
|
// CHECK: [[NORMAL]]([[T0:%.*]] : $Int):
|
|
// CHECK-NEXT: strong_release [[T1]]
|
|
// CHECK-NEXT: strong_release [[T1]]
|
|
// CHECK-NEXT: [[RESULT:%.*]] = tuple ()
|
|
// CHECK-NEXT: return [[RESULT]]
|
|
// CHECK: [[ERROR]]([[T0:%.*]] : $Error):
|
|
// CHECK-NEXT: strong_release [[T1]]
|
|
// CHECK-NEXT: unreachable
|
|
func test2() {
|
|
rethrower(nonthrower)
|
|
}
|
|
|
|
// CHECK-LABEL: sil hidden @$s8rethrows5test3yyF : $@convention(thin) () -> () {
|
|
// CHECK: [[CLOSURE:%.*]] = function_ref @$s8rethrows5test3yyFSiyXEfU_ : $@convention(thin) () -> Int
|
|
// CHECK: [[CVT:%.*]] = convert_function [[CLOSURE]] : $@convention(thin) () -> Int to $@convention(thin) @noescape () -> Int
|
|
// CHECK: [[T0:%.*]] = thin_to_thick_function [[CVT]]
|
|
// CHECK: [[T1:%.*]] = convert_function [[T0]] : $@noescape @callee_guaranteed () -> Int to $@noescape @callee_guaranteed () -> (Int, @error Error)
|
|
// CHECK: [[RETHROWER:%.*]] = function_ref @$s8rethrows9rethroweryS2iyKXEKF : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error)
|
|
// CHECK: try_apply [[RETHROWER]]([[T1]]) : $@convention(thin) (@noescape @callee_guaranteed () -> (Int, @error Error)) -> (Int, @error Error), normal [[NORMAL:bb1]], error [[ERROR:bb2]]
|
|
// CHECK: [[NORMAL]]({{%.*}} : $Int):
|
|
// CHECK-NEXT: [[RESULT:%.*]] = tuple ()
|
|
// CHECK-NEXT: return [[RESULT]]
|
|
// CHECK: [[ERROR]]([[ERROR:%.*]] : $Error):
|
|
// CHECK-NEXT: unreachable
|
|
// CHECK-LABEL: // end sil function '$s8rethrows5test3yyF'
|
|
func test3() {
|
|
rethrower { rethrower(nonthrower) }
|
|
}
|