mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
16d5716e71
This is a large patch; I couldn't split it up further while still keeping things working. There are four things being changed at once here: - Places that call SILType::isAddressOnly()/isLoadable() now call the SILFunction overload and not the SILModule one. - SILFunction's overloads of getTypeLowering() and getLoweredType() now pass the function's resilience expansion down, instead of hardcoding ResilienceExpansion::Minimal. - Various other places with '// FIXME: Expansion' now use a better resilience expansion. - A few tests were updated to reflect SILGen's improved code generation, and some new tests are added to cover more code paths that previously were uncovered and only manifested themselves as standard library build failures while I was working on this change.
78 lines
3.4 KiB
Swift
78 lines
3.4 KiB
Swift
// RUN: %target-swift-frontend -O -module-name=test -enable-library-evolution -emit-sil -primary-file %s | %FileCheck %s
|
|
|
|
// Check if GlobalOpt generates the optimal getter for a static property with a resilient type.
|
|
// The (resilient) getter should just return the literal (and not lazily initialize a global variable).
|
|
|
|
// CHECK-LABEL: sil @$s4test15ResilientStructV9staticValACvgZ :
|
|
// CHECK: bb0(%0 : $*ResilientStruct{{.*}}):
|
|
// CHECK: [[L:%[0-9]+]] = integer_literal {{.*}}, 27
|
|
// CHECK: [[I:%[0-9]+]] = struct $Int ([[L]] : {{.*}})
|
|
// CHECK: [[S:%[0-9]+]] = struct $ResilientStruct ([[I]] : $Int)
|
|
// CHECK: store [[S]] to %0
|
|
// CHECK: return
|
|
|
|
public struct ResilientStruct {
|
|
var rawValue: Int
|
|
|
|
public static let staticVal = ResilientStruct(rawValue: 27)
|
|
|
|
@_optimize(none)
|
|
public func method() {}
|
|
}
|
|
|
|
public func cannotConvertToValueUse() {
|
|
// Previously we could not optimize this because the method takes the
|
|
// resilient value as @in_guaranteed. But now SILGen produces better
|
|
// code for us up-front, so now its optimized anyway.
|
|
ResilientStruct.staticVal.method()
|
|
}
|
|
|
|
@inlinable public func cannotConvertToValueUseAlt() {
|
|
// SILGen still produces address-only code in the inlinable case.
|
|
// We also optimize this correctly, but with a slightly different
|
|
// pattern.
|
|
ResilientStruct.staticVal.method()
|
|
}
|
|
|
|
// CHECK-LABEL: sil @$s4test23cannotConvertToValueUseyyF : $@convention(thin) () -> ()
|
|
// CHECK: [[INT:%.*]] = integer_literal $Builtin.Int{{32|64}}, 27
|
|
// CHECK: [[S1:%.*]] = struct $Int ([[INT]] : $Builtin.Int{{32|64}})
|
|
// CHECK: [[S2:%.*]] = struct $ResilientStruct ([[S1]] : $Int)
|
|
// CHECK: [[TMP:%.*]] = alloc_stack $ResilientStruct
|
|
// CHECK: store [[S2]] to [[TMP]] : $*ResilientStruct
|
|
// CHECK: [[METHOD:%.*]] = function_ref @$s4test15ResilientStructV6methodyyF : $@convention(method) (@in_guaranteed ResilientStruct) -> ()
|
|
// CHECK: apply [[METHOD]]([[TMP]]) : $@convention(method) (@in_guaranteed ResilientStruct) -> ()
|
|
// CHECK: [[RESULT:%.*]] = tuple ()
|
|
// CHECK: return [[RESULT]] : $()
|
|
|
|
// CHECK-LABEL: sil @$s4test26cannotConvertToValueUseAltyyF : $@convention(thin) () -> ()
|
|
// CHECK: [[TMP:%.*]] = alloc_stack $ResilientStruct
|
|
// CHECK: [[INT:%.*]] = integer_literal $Builtin.Int{{32|64}}, 27
|
|
// CHECK: [[S1:%.*]] = struct $Int ([[INT]] : $Builtin.Int{{32|64}})
|
|
// CHECK: [[S2:%.*]] = struct $ResilientStruct ([[S1]] : $Int)
|
|
// CHECK: store [[S2]] to [[TMP]] : $*ResilientStruct
|
|
// CHECK: [[METHOD:%.*]] = function_ref @$s4test15ResilientStructV6methodyyF : $@convention(method) (@in_guaranteed ResilientStruct) -> ()
|
|
// CHECK: apply [[METHOD]]([[TMP]]) : $@convention(method) (@in_guaranteed ResilientStruct) -> ()
|
|
// CHECK: [[RESULT:%.*]] = tuple ()
|
|
// CHECK: return [[RESULT]] : $()
|
|
|
|
internal struct WrapperStruct {
|
|
var inner: ResilientStruct = .staticVal
|
|
|
|
init() {}
|
|
}
|
|
|
|
func returnWrapperStruct() -> WrapperStruct {
|
|
return WrapperStruct()
|
|
}
|
|
|
|
// CHECK-LABEL: sil hidden @$s4test19returnWrapperStructAA0cD0VyF : $@convention(thin) () -> @out WrapperStruct
|
|
// CHECK: bb0(%0 : $*WrapperStruct):
|
|
// CHECK: [[INT:%.*]] = integer_literal $Builtin.Int{{32|64}}, 27
|
|
// CHECK: [[S1:%.*]] = struct $Int ([[INT]] : $Builtin.Int{{32|64}})
|
|
// CHECK: [[S2:%.*]] = struct $ResilientStruct ([[S1]] : $Int)
|
|
// CHECK: [[S3:%.*]] = struct $WrapperStruct ([[S2]] : $ResilientStruct)
|
|
// CHECK: store [[S3]] to %0 : $*WrapperStruct
|
|
// CHECK: [[RESULT:%.*]] = tuple ()
|
|
// CHECK: return [[RESULT]] : $()
|