mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
72f16df99d
Previously, completing inside non single expression body might cause a
crash if you had done any completion with single expression in the same
body.
e.g.
func test() {
test(#^HERE^#)
}
after that:
func test() {
test(arg)
if #^HERE^#
}
That was because the `hasSingleExpressionBody` wasn't cleared when
reusing the function for subsequent completions.
This patch just clears it whenever a new parsed body is set to a
function.
rdar://75358153
48 lines
1.2 KiB
Swift
48 lines
1.2 KiB
Swift
// BEGIN t1.swift
|
|
enum E {
|
|
case foo, bar
|
|
}
|
|
func foo(_ arg: E) {}
|
|
func test(val: E) {
|
|
foo(.bar)
|
|
}
|
|
|
|
// BEGIN t2.swift
|
|
enum E {
|
|
case foo, bar
|
|
}
|
|
func foo(_ arg: E) {}
|
|
func test(val: E) {
|
|
foo(.bar)
|
|
if v
|
|
}
|
|
|
|
// BEGIN dummy.swift
|
|
|
|
// rdar://75358153
|
|
// Previously, completing inside single expression body, then completing inside
|
|
// *non* single expression body in the same function caused a crash because the
|
|
// "has single expression" flag didn't cleard. This file tests the scenario not
|
|
// to regress again.
|
|
|
|
// RUN: %empty-directory(%t)
|
|
// RUN: %{python} %utils/split_file.py -o %t %s
|
|
|
|
// RUN: %sourcekitd-test \
|
|
// RUN: -req=complete -pos=6:8 -text-input %t/t1.swift %t/t.swift -- %t/t.swift == \
|
|
// RUN: -req=complete -pos=7:6 -text-input %t/t2.swift %t/t.swift -- %t/t.swift \
|
|
// RUN: | %FileCheck %s
|
|
|
|
// CHECK-LABEL: key.results: [
|
|
// CHECK-DAG: key.description: "bar",
|
|
// CHECK-DAG: key.description: "foo",
|
|
// CHECK-DAG: key.description: "hash(self: E)",
|
|
// CHECK: ]
|
|
// CHECK-NOT: key.reusingastcontext: 1
|
|
|
|
// CHECK-LABEL: key.results: [
|
|
// CHECK-DAG: key.description: "val",
|
|
// CHECK-DAG: key.description: "foo(arg: E)",
|
|
// CHECK: ],
|
|
// CHECK: key.reusingastcontext: 1
|