mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
- Clear the 'serialized' flag on witness tables and vtables after serialization, not just functions. This fixes SIL verifier failures if post-serialization SIL is printed out and parsed back in. - Clear the 'serialized' flag when deserializing functions, witness tables and vtables in a module that has already been serialized. This fixes SIL verifier failures if we deserialize more declarations after serializing SIL. We were seeing SIL verifier failures on bots that run the tests with the stdlib built with non-standard flags. Unfortunately I don't have a reduced test case that would fail in PR testing without these fixes. Fixes <rdar://problem/36682929>.
78 lines
2.9 KiB
C++
78 lines
2.9 KiB
C++
//===--- SILVTable.cpp - Defines the SILVTable class ----------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines the SILVTable class, which is used to map dynamically
|
|
// dispatchable class methods and properties to their concrete implementations
|
|
// for a dynamic type. This information (FIXME) will be used by IRGen to lay
|
|
// out class vtables, and can be used by devirtualization passes to lower
|
|
// class_method instructions to static function_refs.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "swift/SIL/SILVTable.h"
|
|
#include "swift/SIL/SILModule.h"
|
|
|
|
using namespace swift;
|
|
|
|
SILVTable *SILVTable::create(SILModule &M, ClassDecl *Class,
|
|
IsSerialized_t Serialized,
|
|
ArrayRef<Entry> Entries) {
|
|
// SILVTable contains one element declared in Entries. We must allocate
|
|
// space for it, because its default ctor will write to it.
|
|
unsigned NumTailElements = std::max((unsigned)Entries.size(), 1U)-1;
|
|
void *buf = M.allocate(sizeof(SILVTable) + sizeof(Entry) * NumTailElements,
|
|
alignof(SILVTable));
|
|
SILVTable *vt = ::new (buf) SILVTable(Class, Serialized, Entries);
|
|
M.vtables.push_back(vt);
|
|
M.VTableMap[Class] = vt;
|
|
// Update the Module's cache with new vtable + vtable entries:
|
|
for (const Entry &entry : Entries) {
|
|
M.VTableEntryCache.insert({{vt, entry.Method}, entry});
|
|
}
|
|
return vt;
|
|
}
|
|
|
|
Optional<SILVTable::Entry>
|
|
SILVTable::getEntry(SILModule &M, SILDeclRef method) const {
|
|
SILDeclRef m = method;
|
|
do {
|
|
auto entryIter = M.VTableEntryCache.find({this, m});
|
|
if (entryIter != M.VTableEntryCache.end()) {
|
|
return (*entryIter).second;
|
|
}
|
|
} while ((m = m.getOverridden()));
|
|
return None;
|
|
}
|
|
|
|
void SILVTable::removeFromVTableCache(Entry &entry) {
|
|
SILModule &M = entry.Implementation->getModule();
|
|
M.VTableEntryCache.erase({this, entry.Method});
|
|
}
|
|
|
|
SILVTable::SILVTable(ClassDecl *c, IsSerialized_t serialized,
|
|
ArrayRef<Entry> entries)
|
|
: Class(c), Serialized(serialized), NumEntries(entries.size()) {
|
|
memcpy(Entries, entries.begin(), sizeof(Entry) * NumEntries);
|
|
|
|
// Bump the reference count of functions referenced by this table.
|
|
for (const Entry &entry : getEntries()) {
|
|
entry.Implementation->incrementRefCount();
|
|
}
|
|
}
|
|
|
|
SILVTable::~SILVTable() {
|
|
// Drop the reference count of functions referenced by this table.
|
|
for (const Entry &entry : getEntries()) {
|
|
entry.Implementation->decrementRefCount();
|
|
}
|
|
}
|