mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
814fb42554
when two objc async functions are composed with each other, i.e., f(g()), then the clean-ups for g() would get emitted at an unexpected time, namely, during the suspension for the call to f(). This means that using a clean-up to emit the executor-hop breadcrumb was incorrect. The hop could appear between a get_async continuation and its matching await_continuation, which is an unsupported nested suspension. This commit fixes that by removing the use of the breadcrumb clean-up in favor of providing that breadcrumb directly to the result plan, so that it may be emitted later on when the result plan sees fit. Fixes rdar://91502776
108 lines
3.5 KiB
C++
108 lines
3.5 KiB
C++
//===--- ResultPlan.h -------------------------------------------*- C++ -*-===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef SWIFT_SILGEN_RESULTPLAN_H
|
|
#define SWIFT_SILGEN_RESULTPLAN_H
|
|
|
|
#include "Callee.h"
|
|
#include "ExecutorBreadcrumb.h"
|
|
#include "ManagedValue.h"
|
|
#include "swift/AST/Types.h"
|
|
#include "swift/Basic/LLVM.h"
|
|
#include "swift/SIL/SILLocation.h"
|
|
#include <memory>
|
|
|
|
namespace swift {
|
|
|
|
class CanType;
|
|
class SILValue;
|
|
|
|
namespace Lowering {
|
|
|
|
class AbstractionPattern;
|
|
class Initialization;
|
|
class RValue;
|
|
class SILGenFunction;
|
|
class SGFContext;
|
|
class CalleeTypeInfo;
|
|
|
|
/// An abstract class for working with results.of applies.
|
|
class ResultPlan {
|
|
public:
|
|
virtual RValue finish(SILGenFunction &SGF, SILLocation loc, CanType substType,
|
|
ArrayRef<ManagedValue> &directResults,
|
|
SILValue bridgedForeignError) = 0;
|
|
virtual ~ResultPlan() = default;
|
|
|
|
/// Defers the emission of the given breadcrumb until \p finish is invoked.
|
|
virtual void deferExecutorBreadcrumb(ExecutorBreadcrumb &&breadcrumb) {
|
|
llvm_unreachable("this ResultPlan does not handle deferred breadcrumbs!");
|
|
}
|
|
|
|
virtual void
|
|
gatherIndirectResultAddrs(SILGenFunction &SGF, SILLocation loc,
|
|
SmallVectorImpl<SILValue> &outList) const = 0;
|
|
|
|
virtual Optional<std::pair<ManagedValue, ManagedValue>>
|
|
emitForeignErrorArgument(SILGenFunction &SGF, SILLocation loc) {
|
|
return None;
|
|
}
|
|
|
|
virtual ManagedValue emitForeignAsyncCompletionHandler(
|
|
SILGenFunction &SGF, AbstractionPattern origFormalType, SILLocation loc) {
|
|
return {};
|
|
}
|
|
};
|
|
|
|
using ResultPlanPtr = std::unique_ptr<ResultPlan>;
|
|
|
|
/// The class for building result plans.
|
|
struct ResultPlanBuilder {
|
|
SILGenFunction &SGF;
|
|
SILLocation loc;
|
|
const CalleeTypeInfo &calleeTypeInfo;
|
|
|
|
/// A list of all of the results that we are tracking in reverse order. The
|
|
/// reason that it is in reverse order is to allow us to simply traverse the
|
|
/// list by popping values off the back.
|
|
SmallVector<SILResultInfo, 8> allResults;
|
|
|
|
ResultPlanBuilder(SILGenFunction &SGF, SILLocation loc,
|
|
const CalleeTypeInfo &calleeTypeInfo)
|
|
: SGF(SGF), loc(loc), calleeTypeInfo(calleeTypeInfo),
|
|
// We reverse the order so we can pop values off the back.
|
|
allResults(llvm::reverse(calleeTypeInfo.substFnType->getResults())) {}
|
|
|
|
ResultPlanPtr build(Initialization *emitInto, AbstractionPattern origType,
|
|
CanType substType);
|
|
ResultPlanPtr buildForTuple(Initialization *emitInto,
|
|
AbstractionPattern origType,
|
|
CanTupleType substType);
|
|
|
|
static ResultPlanPtr computeResultPlan(SILGenFunction &SGF,
|
|
const CalleeTypeInfo &calleeTypeInfo,
|
|
SILLocation loc,
|
|
SGFContext evalContext);
|
|
|
|
~ResultPlanBuilder() {
|
|
assert(allResults.empty() && "didn't consume all results!");
|
|
}
|
|
|
|
private:
|
|
ResultPlanPtr buildTopLevelResult(Initialization *init, SILLocation loc);
|
|
};
|
|
|
|
} // end namespace Lowering
|
|
} // end namespace swift
|
|
|
|
#endif
|