mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
ff42f2ee79
Currently, we only get warnings for using unsafe types in expressions but not in the function signature. The tests did not use the std::string object in the function body. As a result, we regressed and std::string was considered unsafe. The reason is that the annotation only mode for calculating escapability of a type did not do what we intended. std::basic_string is conditionally escapable if the template argument is escapable. We considered 'char' to have unknown escapability in annotation only mode. The annotation only mode was introduced to avoid suddenly importing certain types as not escapable when they have pointer fields and break backward compatibility. The solution is to make annotation only mode to still consider char and co as escapable types and only fall back to unknown when the inference otherwise would have deduced non-escapable (for unannotated typed).