mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
Our libcache implementation of swift::sys::Cache was broken for ref-counted values (which are used by e.g. the SourceKit ASTManager). It would always `retain(value)` in `set(key, value)`, but under the hood libcache shares values, so we would only get one `release(value)` if the same value was used across multiple keys, or if the same value *and* key were set multiple times. This was causing us to never release ASTs cached by SourceKit even when the underlying libcache purged itself under memory pressure. rdar://problem/21619189
187 lines
4.4 KiB
C++
187 lines
4.4 KiB
C++
//===--- CacheTest.cpp ----------------------------------------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "swift/Basic/Cache.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
#if defined(__APPLE__)
|
|
#define USES_LIBCACHE 1
|
|
#else
|
|
#define USES_LIBCACHE 0
|
|
#endif
|
|
|
|
namespace {
|
|
struct Counter {
|
|
mutable int enter = 0;
|
|
mutable int exit = 0;
|
|
};
|
|
}
|
|
|
|
namespace swift {
|
|
namespace sys {
|
|
template <>
|
|
struct CacheValueInfo<Counter>{
|
|
static void *enterCache(const Counter &value) {
|
|
return const_cast<Counter *>(&value);
|
|
}
|
|
static void retain(void *ptr) {
|
|
static_cast<Counter*>(ptr)->enter+= 1;
|
|
}
|
|
static void release(void *ptr) {
|
|
static_cast<Counter*>(ptr)->exit += 1;
|
|
}
|
|
static const Counter &getFromCache(void *ptr) {
|
|
return *static_cast<Counter *>(ptr);
|
|
}
|
|
static size_t getCost(const Counter &value) {
|
|
return 0;
|
|
}
|
|
};
|
|
}
|
|
}
|
|
|
|
namespace {
|
|
struct RefCntToken : llvm::RefCountedBase<RefCntToken> {
|
|
bool &freed;
|
|
RefCntToken(bool &freed) : freed(freed) {}
|
|
~RefCntToken() { freed = true; }
|
|
};
|
|
}
|
|
|
|
TEST(Cache, sameKey) {
|
|
Counter c1, c2;
|
|
swift::sys::Cache<const char *, Counter> cache(__func__);
|
|
cache.set("a", c1);
|
|
EXPECT_EQ(1, c1.enter);
|
|
EXPECT_EQ(0, c1.exit);
|
|
|
|
cache.set("a", c2);
|
|
EXPECT_EQ(1, c1.enter);
|
|
EXPECT_EQ(1, c1.exit);
|
|
EXPECT_EQ(1, c2.enter);
|
|
EXPECT_EQ(0, c2.exit);
|
|
}
|
|
|
|
TEST(Cache, sameValue) {
|
|
Counter c;
|
|
swift::sys::Cache<const char *, Counter> cache(__func__);
|
|
cache.set("a", c);
|
|
EXPECT_EQ(1, c.enter);
|
|
EXPECT_EQ(0, c.exit);
|
|
|
|
cache.set("b", c);
|
|
#if USES_LIBCACHE
|
|
EXPECT_EQ(1, c.enter); // value is shared.
|
|
#else
|
|
EXPECT_EQ(2, c.enter);
|
|
#endif
|
|
EXPECT_EQ(0, c.exit);
|
|
|
|
cache.remove("a");
|
|
#if USES_LIBCACHE
|
|
EXPECT_EQ(1, c.enter); // value is shared.
|
|
EXPECT_EQ(0, c.exit);
|
|
#else
|
|
EXPECT_EQ(2, c.enter);
|
|
EXPECT_EQ(1, c.exit);
|
|
#endif
|
|
|
|
cache.remove("b");
|
|
EXPECT_EQ(c.enter, c.exit);
|
|
}
|
|
|
|
TEST(Cache, sameKeyValue) {
|
|
Counter c;
|
|
swift::sys::Cache<const char *, Counter> cache(__func__);
|
|
cache.set("a", c);
|
|
EXPECT_EQ(1, c.enter);
|
|
EXPECT_EQ(0, c.exit);
|
|
|
|
cache.set("a", c);
|
|
EXPECT_EQ(1, c.enter);
|
|
EXPECT_EQ(0, c.exit);
|
|
|
|
cache.remove("a");
|
|
EXPECT_EQ(1, c.enter);
|
|
EXPECT_EQ(1, c.exit);
|
|
}
|
|
|
|
TEST(Cache, sameKeyIntrusiveRefCountPter) {
|
|
bool freed1 = false;
|
|
bool freed2 = false;
|
|
swift::sys::Cache<const char *, llvm::IntrusiveRefCntPtr<RefCntToken>> cache(__func__);
|
|
{
|
|
llvm::IntrusiveRefCntPtr<RefCntToken> c1(new RefCntToken(freed1));
|
|
llvm::IntrusiveRefCntPtr<RefCntToken> c2(new RefCntToken(freed2));
|
|
cache.set("a", c1);
|
|
cache.set("a", c2);
|
|
}
|
|
EXPECT_TRUE(freed1);
|
|
EXPECT_FALSE(freed2);
|
|
cache.remove("a");
|
|
EXPECT_TRUE(freed2);
|
|
}
|
|
|
|
TEST(Cache, sameValueIntrusiveRefCountPter) {
|
|
bool freed = false;
|
|
swift::sys::Cache<const char *, llvm::IntrusiveRefCntPtr<RefCntToken>> cache(__func__);
|
|
{
|
|
llvm::IntrusiveRefCntPtr<RefCntToken> c(new RefCntToken(freed));
|
|
cache.set("a", c);
|
|
EXPECT_FALSE(freed);
|
|
|
|
cache.set("b", c);
|
|
EXPECT_FALSE(freed);
|
|
|
|
cache.remove("a");
|
|
EXPECT_FALSE(freed);
|
|
|
|
cache.remove("b");
|
|
EXPECT_FALSE(freed);
|
|
}
|
|
EXPECT_TRUE(freed);
|
|
}
|
|
|
|
TEST(Cache, sameKeyValueIntrusiveRefCountPter) {
|
|
bool freed = false;
|
|
swift::sys::Cache<const char *, llvm::IntrusiveRefCntPtr<RefCntToken>> cache(__func__);
|
|
{
|
|
llvm::IntrusiveRefCntPtr<RefCntToken> c(new RefCntToken(freed));
|
|
cache.set("a", c);
|
|
EXPECT_FALSE(freed);
|
|
cache.set("a", c);
|
|
EXPECT_FALSE(freed);
|
|
}
|
|
EXPECT_FALSE(freed);
|
|
cache.remove("a");
|
|
EXPECT_TRUE(freed);
|
|
}
|
|
|
|
TEST(Cache, copyValue) {
|
|
struct S {
|
|
int ident, copy;
|
|
S(int ident) : ident(ident), copy(0) {}
|
|
S(const S &other) : ident(other.ident), copy(other.copy+1) {}
|
|
S(S &&other) : ident(other.ident), copy(other.copy) {}
|
|
};
|
|
swift::sys::Cache<const char *, struct S> cache(__func__);
|
|
S s{0};
|
|
EXPECT_EQ(0, s.ident);
|
|
EXPECT_EQ(0, s.copy);
|
|
cache.set("a", s);
|
|
EXPECT_EQ(0, cache.get("a")->ident);
|
|
EXPECT_EQ(2, cache.get("a")->copy); // return by value causes 2nd copy
|
|
cache.set("b", *cache.get("a"));
|
|
EXPECT_EQ(0, cache.get("b")->ident);
|
|
EXPECT_EQ(4, cache.get("b")->copy); // return by value causes 2nd copy
|
|
}
|