mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
8770c7f826
This PR refactors the ASTDumper to make it more structured, less mistake-prone, and more amenable to future changes. For example:
```cpp
// Before:
void visitUnresolvedDotExpr(UnresolvedDotExpr *E) {
printCommon(E, "unresolved_dot_expr")
<< " field '" << E->getName() << "'";
PrintWithColorRAII(OS, ExprModifierColor)
<< " function_ref=" << getFunctionRefKindStr(E->getFunctionRefKind());
if (E->getBase()) {
OS << '\n';
printRec(E->getBase());
}
PrintWithColorRAII(OS, ParenthesisColor) << ')';
}
// After:
void visitUnresolvedDotExpr(UnresolvedDotExpr *E, StringRef label) {
printCommon(E, "unresolved_dot_expr", label);
printFieldQuoted(E->getName(), "field");
printField(E->getFunctionRefKind(), "function_ref", ExprModifierColor);
if (E->getBase()) {
printRec(E->getBase());
}
printFoot();
}
```
* Values are printed through calls to base class methods, rather than direct access to the underlying `raw_ostream`.
* These methods tend to reduce the chances of bugs like missing/extra spaces or newlines, too much/too little indentation, etc.
* More values are quoted, and unprintable/non-ASCII characters in quoted values are escaped before printing.
* Infrastructure to label child nodes now exists.
* Some weird breaks from the normal "style", like `PatternBindingDecl`'s original and processed initializers, have been brought into line.
* Some types that previously used ad-hoc dumping functions, like conformances and substitution maps, are now structured similarly to the dumper classes.
* I've fixed the odd dumping bug along the way. For example, distributed actors were only marked `actor`, not `distributed actor`.
This PR doesn't change the overall style of AST dumps; they're still pseudo-S-expressions. But the logic that implements this style is now isolated into a relatively small base class, making it feasible to introduce e.g. JSON dumping in the future.
23 lines
1007 B
Swift
23 lines
1007 B
Swift
// RUN: %target-swift-frontend %s -typecheck -debug-constraints -swift-version 4 2>%t.err
|
|
// RUN: %FileCheck %s < %t.err
|
|
|
|
// SE-0213. `UInt32(0)` and similar expressions that get transformed into
|
|
// `0 as <#Type#>` should get literal bound early via equality constraint.
|
|
|
|
// CHECK: ---Constraint solving at [{{.*}}:12:1 - line:12:13]---
|
|
// CHECK: (integer_literal_expr type="[[LITERAL_VAR:\$T[0-9]+]]" {{.*}}
|
|
// CHECK: Type Variables:
|
|
// CHECK: [[LITERAL_VAR]] as UInt32 {{.*}}
|
|
// CHECK-NOT: disjunction (remembered) \[\[locator@{{.*}} [Coerce@{{.*}}\]\]]:
|
|
_ = UInt32(0)
|
|
|
|
// CHECK: ---Constraint solving at [{{.*}}22:1 - line:22:13]---
|
|
// CHECK: (coerce_expr implicit type="[[CAST_TYPE:\$T[0-9]+]]" {{.*}}
|
|
// CHECK-NEXT: (nil_literal_expr type="[[LITERAL_VAR:\$T[0-9]+]]" {{.*}}
|
|
// CHECK: Type Variables:
|
|
// CHECK: [[LITERAL_VAR]] as Int? {{.*}}
|
|
// CHECK: disjunction (remembered) {{.*}}
|
|
// CHECK-NEXT: > [favored] [[CAST_TYPE]] bind Int?
|
|
// CHECK-NEXT: > [[CAST_TYPE]] bind Int
|
|
_ = Int!(nil)
|