mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
6714f4b301
The latter example NIODefaultSerialEventLoopExecutor when the type is more available than the enqueue implementation provided via an extrension would issue a warning that that this enqueue(ExecutorJob) would not be used which is not true. We need to filter out all "default impls" from the stdlib as we issue this warning. We also put a note on the offending declaration that one can remove now, to ease getting rid of warnings when possible Resolves rdar://115166475
76 lines
3.4 KiB
Swift
76 lines
3.4 KiB
Swift
// RUN: %target-swift-frontend -enable-experimental-move-only %s -emit-sil -o /dev/null -verify
|
|
// RUN: %target-swift-frontend -enable-experimental-move-only %s -emit-sil -o /dev/null -verify -strict-concurrency=targeted
|
|
// RUN: %target-swift-frontend -enable-experimental-move-only %s -emit-sil -o /dev/null -verify -strict-concurrency=complete
|
|
// RUN: %target-swift-frontend -enable-experimental-move-only %s -emit-sil -o /dev/null -verify -strict-concurrency=complete -enable-experimental-feature SendNonSendable
|
|
|
|
// REQUIRES: concurrency
|
|
// REQUIRES: OS=macosx
|
|
// REQUIRES: asserts
|
|
|
|
// rdar://106849189 move-only types should be supported in freestanding mode
|
|
// UNSUPPORTED: freestanding
|
|
|
|
/// Such a type may be encountered since Swift 5.5 (5.1 backdeployed) if someone implemented the
|
|
/// not documented, but public Executor types back then already. Allow these to be implemented
|
|
/// without warnings.
|
|
@available(SwiftStdlib 5.1, *)
|
|
final class OldExecutorOldStdlib: SerialExecutor {
|
|
func enqueue(_ job: UnownedJob) {}
|
|
|
|
func asUnownedSerialExecutor() -> UnownedSerialExecutor {
|
|
UnownedSerialExecutor(ordinary: self)
|
|
}
|
|
}
|
|
|
|
/// We warn on the ExecutorJob witness if the type has a broader
|
|
/// availability, since in this case the UnownedJob version needs to exist.
|
|
@available(SwiftStdlib 5.1, *)
|
|
final class BothExecutorOldStdlib: SerialExecutor {
|
|
func enqueue(_ job: UnownedJob) {} // expected-note{{'enqueue' declared here}}
|
|
|
|
@available(SwiftStdlib 5.9, *)
|
|
func enqueue(_ job: __owned ExecutorJob) {} // expected-warning{{'Executor.enqueue(ExecutorJob)' will never be used, due to the presence of 'enqueue(UnownedJob)'}}
|
|
|
|
func asUnownedSerialExecutor() -> UnownedSerialExecutor {
|
|
UnownedSerialExecutor(ordinary: self)
|
|
}
|
|
}
|
|
|
|
/// Meanwhile, we warn on the UnownedJob overload if the availability is new enough
|
|
/// that it can be dropped.
|
|
@available(SwiftStdlib 5.9, *)
|
|
final class BothExecutorNewStdlib: SerialExecutor {
|
|
func enqueue(_ job: UnownedJob) {} // expected-warning{{'Executor.enqueue(UnownedJob)' is deprecated as a protocol requirement; conform type 'BothExecutorNewStdlib' to 'Executor' by implementing 'func enqueue(ExecutorJob)' instead}}
|
|
|
|
func enqueue(_ job: __owned ExecutorJob) {}
|
|
|
|
func asUnownedSerialExecutor() -> UnownedSerialExecutor {
|
|
UnownedSerialExecutor(ordinary: self)
|
|
}
|
|
}
|
|
|
|
@available(SwiftStdlib 5.9, *)
|
|
final class TripleExecutor: SerialExecutor {
|
|
func enqueue(_ job: UnownedJob) {} // expected-warning{{'Executor.enqueue(UnownedJob)' is deprecated as a protocol requirement; conform type 'TripleExecutor' to 'Executor' by implementing 'func enqueue(ExecutorJob)' instead}}
|
|
|
|
// expected-warning@+2{{'Job' is deprecated: renamed to 'ExecutorJob'}}
|
|
// expected-note@+1{{use 'ExecutorJob' instead}}
|
|
func enqueue(_ job: __owned Job) {} // expected-warning{{'Executor.enqueue(Job)' is deprecated as a protocol requirement; conform type 'TripleExecutor' to 'Executor' by implementing 'func enqueue(ExecutorJob)' instead}}
|
|
|
|
func enqueue(_ job: consuming ExecutorJob) {}
|
|
|
|
func asUnownedSerialExecutor() -> UnownedSerialExecutor {
|
|
UnownedSerialExecutor(ordinary: self)
|
|
}
|
|
}
|
|
|
|
/// Implementing the new signature on 5.9 platforms is good, no warnings
|
|
@available(SwiftStdlib 5.9, *)
|
|
final class NewExecutorNewStdlib: SerialExecutor {
|
|
func enqueue(_ job: __owned ExecutorJob) {}
|
|
|
|
func asUnownedSerialExecutor() -> UnownedSerialExecutor {
|
|
UnownedSerialExecutor(ordinary: self)
|
|
}
|
|
}
|