mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
9e562881fe
Replaces generic `expression is 'async' but is not marked with 'await` diagnostic with a tailed one for cases where there is an access to an actor-isolated value outside of its actor without `await` keyword. This makes the diagnostics for async and sync contexts consistent and actually identifies a problem instead of simply pointing out the solution. Resolves: rdar://151720646
51 lines
1.3 KiB
Swift
51 lines
1.3 KiB
Swift
// RUN: %target-swift-frontend -typecheck -target %target-swift-5.1-abi-triple -enable-experimental-async-top-level -swift-version 5 %s -verify
|
|
|
|
// enable-experimental-async-top-level is passed and an await is used in the
|
|
// top-level, so the top-level code is a concurrent context. Variables are
|
|
// declared with `@_predatesConcurrency @MainActor`, and the top-level is run on
|
|
// the main actor.
|
|
|
|
var a = 10 // expected-note {{mutation of this var is only permitted within the actor}}
|
|
|
|
func nonIsolatedSync() {
|
|
// Okay because `a` is '@_predatesConcurrency'
|
|
print(a)
|
|
a = a + 10
|
|
}
|
|
|
|
@MainActor
|
|
func isolatedSync() {
|
|
print(a)
|
|
a = a + 10
|
|
}
|
|
|
|
func nonIsolatedAsync() async {
|
|
await print(a)
|
|
a = a + 10
|
|
// expected-warning@-1:5 {{main actor-isolated var 'a' can not be mutated from a nonisolated context}}
|
|
// expected-warning@-2:9 {{main actor-isolated var 'a' cannot be accessed from outside of the actor}}{{9-9=await }}
|
|
// expected-note@-3 {{consider declaring an isolated method on 'MainActor' to perform the mutation}}
|
|
}
|
|
|
|
@MainActor
|
|
func isolatedAsync() async {
|
|
print(a)
|
|
a = a + 10
|
|
}
|
|
|
|
nonIsolatedSync()
|
|
isolatedSync()
|
|
await nonIsolatedAsync()
|
|
await isolatedAsync()
|
|
|
|
print(a)
|
|
|
|
if a > 10 {
|
|
nonIsolatedSync()
|
|
isolatedSync()
|
|
await nonIsolatedAsync()
|
|
await isolatedAsync()
|
|
|
|
print(a)
|
|
}
|