Files
swift-mirror/lib/SILOptimizer/Analysis/AccessedStorageAnalysis.cpp
Andrew Trick 6ecbeefd50 Add AccessedStorage::Tail access kind and remove more checks.
Distinguish ref_tail_addr storage from the other storage classes.

We didn't have this originally because be don't expect a begin_access
to directly operate on tail storage. It could occur after inlining, at
least with static access markers. More importantly it helps ditinguish
regular formal accesses from other unidentified access, so we probably
should have always had this.

At any rate, it's particularly important when AccessedStorage is
generalized to arbitrary memory access.

The immediate motivation is to add an AccessPath utility, which will
need to distinguish tail storage.

In the process, rewrite AccessedStorage::isDistinct. This could have a
large positive impact on exclusivity performance.
2020-07-20 16:42:53 -07:00

389 lines
15 KiB
C++

//===--- AccessedStorageAnalysis.cpp - Accessed Storage Analysis ---------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#define DEBUG_TYPE "sil-sea"
#include "swift/SILOptimizer/Analysis/AccessedStorageAnalysis.h"
#include "swift/SILOptimizer/Analysis/BasicCalleeAnalysis.h"
#include "swift/SILOptimizer/Analysis/FunctionOrder.h"
#include "swift/SILOptimizer/PassManager/PassManager.h"
using namespace swift;
// -----------------------------------------------------------------------------
// MARK: Accessing the results.
// -----------------------------------------------------------------------------
bool AccessedStorageResult::hasNoNestedConflict(
const AccessedStorage &otherStorage) const {
assert(otherStorage.isUniquelyIdentified());
assert(!hasUnidentifiedAccess());
return getStorageAccessInfo(otherStorage).hasNoNestedConflict();
}
bool AccessedStorageResult::mayConflictWith(
SILAccessKind otherAccessKind, const AccessedStorage &otherStorage) const {
if (hasUnidentifiedAccess()
&& accessKindMayConflict(otherAccessKind,
unidentifiedAccess.getValue())) {
return true;
}
for (auto &storageAccess : storageAccessSet) {
assert(storageAccess && "FunctionAccessedStorage mapped invalid storage.");
if (!accessKindMayConflict(otherAccessKind, storageAccess.getAccessKind()))
continue;
if (!otherStorage.isDistinctFrom(storageAccess))
return true;
}
return false;
}
StorageAccessInfo AccessedStorageResult::getStorageAccessInfo(
const AccessedStorage &otherStorage) const {
// Construct a fake StorageAccessInfo to do a hash lookup for the real
// StorageAccessInfo. The DenseSet key is limited to the AccessedStorage base
// class members.
StorageAccessInfo storageKey(otherStorage, SILAccessKind::Read, false);
auto iter = storageAccessSet.find(storageKey);
assert(iter != storageAccessSet.end());
return *iter;
}
// -----------------------------------------------------------------------------
// MARK: Constructing the results.
// -----------------------------------------------------------------------------
static bool updateAccessKind(SILAccessKind &LHS, SILAccessKind RHS) {
bool changed = false;
// Assume we don't track Init/Deinit.
if (LHS == SILAccessKind::Read && RHS == SILAccessKind::Modify) {
LHS = RHS;
changed = true;
}
return changed;
}
static bool updateOptionalAccessKind(Optional<SILAccessKind> &LHS,
Optional<SILAccessKind> RHS) {
if (RHS == None)
return false;
if (LHS == None) {
LHS = RHS;
return true;
}
return updateAccessKind(LHS.getValue(), RHS.getValue());
}
bool StorageAccessInfo::mergeFrom(const StorageAccessInfo &RHS) {
bool changed = false;
SILAccessKind accessKind = getAccessKind();
assert(accessKind == SILAccessKind::Read
|| accessKind == SILAccessKind::Modify && "uninitialized info");
if (updateAccessKind(accessKind, RHS.getAccessKind())) {
setAccessKind(accessKind);
changed = true;
}
if (hasNoNestedConflict() && !RHS.hasNoNestedConflict()) {
setNoNestedConflict(false);
changed = true;
}
return changed;
}
bool AccessedStorageResult::updateUnidentifiedAccess(SILAccessKind accessKind) {
if (unidentifiedAccess == None) {
unidentifiedAccess = accessKind;
return true;
}
return updateAccessKind(unidentifiedAccess.getValue(), accessKind);
}
// Merge the given AccessedStorageResult in `other` into this
// AccessedStorageResult. Use the given `transformStorage` to map `other`
// AccessedStorage into this context. If `other` is from a callee, argument
// substitution will be performed if possible. However, there's no guarantee
// that the merged access values will belong to this region.
//
// Return true if these results changed, requiring further propagation through
// the call graph.
bool AccessedStorageResult::mergeAccesses(
const AccessedStorageResult &other,
std::function<StorageAccessInfo(const StorageAccessInfo &)>
transformStorage) {
// The cost of BottomUpIPAnalysis can be quadratic for large recursive call
// graphs. That cost is multiplied by the size of storageAccessSet. Slowdowns
// can occur ~1000 elements. 200 is large enough to cover "normal" code,
// while ensuring compile time isn't affected.
if (storageAccessSet.size() > 200) {
setWorstEffects();
return true;
}
// To save compile time, if this storage already has worst-case effects, avoid
// growing its storageAccessSet.
if (hasWorstEffects())
return false;
// When `this` == `other` (for self-recursion), insertion in DenseMap
// invalidates the iterator. We still need to propagate and merge in that case
// because arguments can be recursively dependent. The alternative would be
// treating all self-recursion conservatively.
const AccessedStorageResult *otherRegionAccesses = &other;
AccessedStorageResult regionAccessCopy;
if (this == &other) {
regionAccessCopy = other;
otherRegionAccesses = &regionAccessCopy;
}
bool changed = false;
// Nondeterminstically iterate for the sole purpose of inserting into another
// unordered set.
for (auto &rawStorageInfo : otherRegionAccesses->storageAccessSet) {
const StorageAccessInfo &otherStorageInfo =
transformStorage(rawStorageInfo);
// If transformStorage() returns invalid storage object for local storage,
// that should not be merged with the caller.
if (!otherStorageInfo)
continue;
if (otherStorageInfo.getKind() == AccessedStorage::Unidentified) {
changed |= updateUnidentifiedAccess(otherStorageInfo.getAccessKind());
continue;
}
// Attempt to add identified AccessedStorage to this map.
auto result = insertStorageAccess(otherStorageInfo);
if (result.second) {
// A new AccessedStorage key was added to this map.
changed = true;
continue;
}
// Merge StorageAccessInfo into already-mapped AccessedStorage.
changed |= result.first->mergeFrom(otherStorageInfo);
}
if (other.unidentifiedAccess != None)
changed |= updateUnidentifiedAccess(other.unidentifiedAccess.getValue());
return changed;
}
bool AccessedStorageResult::mergeFrom(const AccessedStorageResult &other) {
// Merge accesses from other. Both `this` and `other` are either from the same
// function or are both callees of the same call site, so their parameters
// indices coincide. transformStorage is the identity function.
return mergeAccesses(other, [](const StorageAccessInfo &s) { return s; });
}
/// Returns the argument of the full apply or partial apply corresponding to the
/// callee's parameter index, or returns an invalid SILValue if the applied
/// closure cannot be found. This walks up the apply chain starting at the given
/// `fullApply` to find the applied argument.
static SILValue getCallerArg(FullApplySite fullApply, unsigned paramIndex) {
if (paramIndex < fullApply.getNumArguments())
return fullApply.getArgument(paramIndex);
SILValue callee = fullApply.getCalleeOrigin();
auto *PAI = dyn_cast<PartialApplyInst>(callee);
if (!PAI)
return SILValue();
unsigned appliedIndex =
paramIndex - ApplySite(PAI).getCalleeArgIndexOfFirstAppliedArg();
if (appliedIndex < PAI->getNumArguments())
return PAI->getArgument(appliedIndex);
// This must be a chain of partial_applies. We don't expect this in practice,
// so handle it conservatively.
return SILValue();
}
/// Transform AccessedStorage from a callee into the caller context. If this is
/// uniquely identified local storage, then return an invalid storage object.
///
/// For correctness, AccessEnforcementOpts relies on all Argument access to
/// either be mapped into the caller's context or marked as an unidentified
/// access at the call site.
///
/// Note: This does *not* map the storage index into the caller function's index
/// range. (When the storage value doesn't need to be remapped, it returns the
/// original storage value.) It's simpler to set the storage index later when it
/// is actually added to the function's storageAccessSet.
static StorageAccessInfo
transformCalleeStorage(const StorageAccessInfo &storage,
FullApplySite fullApply) {
switch (storage.getKind()) {
case AccessedStorage::Box:
case AccessedStorage::Stack:
// Do not merge local storage.
return StorageAccessInfo(AccessedStorage(), storage);
case AccessedStorage::Global:
// Global accesses is universal.
return storage;
case AccessedStorage::Class:
case AccessedStorage::Tail: {
// If the object's value is an argument, translate it into a value on the
// caller side.
SILValue obj = storage.getObject();
if (auto *arg = dyn_cast<SILFunctionArgument>(obj)) {
SILValue argVal = getCallerArg(fullApply, arg->getIndex());
if (argVal) {
unsigned idx = (storage.getKind() == AccessedStorage::Class)
? storage.getPropertyIndex()
: AccessedStorage::TailIndex;
// Remap this storage info. The argument source value is now the new
// object. The old storage info is inherited.
return StorageAccessInfo(AccessedStorage::forClass(argVal, idx),
storage);
}
}
// Otherwise, continue to reference the value in the callee because we don't
// have any better placeholder for a callee-defined object.
return storage;
}
case AccessedStorage::Argument: {
// Transitively search for the storage base in the caller.
SILValue argVal = getCallerArg(fullApply, storage.getParamIndex());
if (argVal) {
// Remap the argument source value and inherit the old storage info.
auto calleeStorage = findAccessedStorage(argVal);
if (calleeStorage)
return StorageAccessInfo(calleeStorage, storage);
}
// If the argument can't be transformed, demote it to an unidentified
// access.
//
// This is an untested bailout. It is only reachable if the call graph
// contains an edge that getCallerArg is unable to analyze OR if
// findAccessedStorage returns an invalid SILValue, which won't
// pass SIL verification.
//
// FIXME: In case argVal is invalid, support Unidentified access for invalid
// values. This would also be useful for partially invalidating results.
return StorageAccessInfo(
AccessedStorage(argVal, AccessedStorage::Unidentified), storage);
}
case AccessedStorage::Nested:
llvm_unreachable("Unexpected nested access");
case AccessedStorage::Yield:
// Continue to hold on to yields from the callee because we don't have
// any better placeholder in the callee.
return storage;
case AccessedStorage::Unidentified:
// For unidentified storage, continue to reference the value in the callee
// because we don't have any better placeholder for a callee-defined object.
return storage;
}
llvm_unreachable("unhandled kind");
}
bool AccessedStorageResult::mergeFromApply(
const AccessedStorageResult &calleeAccess, FullApplySite fullApply) {
// Merge accesses from calleeAccess. Transform any Argument type
// AccessedStorage into the caller context to be added to `this` storage map.
return mergeAccesses(calleeAccess, [&fullApply](const StorageAccessInfo &s) {
return transformCalleeStorage(s, fullApply);
});
}
template <typename B>
void AccessedStorageResult::visitBeginAccess(B *beginAccess) {
if (beginAccess->getEnforcement() != SILAccessEnforcement::Dynamic)
return;
const AccessedStorage &storage =
findAccessedStorage(beginAccess->getSource());
if (storage.getKind() == AccessedStorage::Unidentified) {
// This also catches invalid storage.
updateOptionalAccessKind(unidentifiedAccess, beginAccess->getAccessKind());
return;
}
StorageAccessInfo storageAccess(storage, beginAccess);
auto result = insertStorageAccess(storageAccess);
if (!result.second)
result.first->mergeFrom(storageAccess);
}
void AccessedStorageResult::analyzeInstruction(SILInstruction *I) {
assert(!FullApplySite::isa(I) && "caller should merge");
if (auto *BAI = dyn_cast<BeginAccessInst>(I))
visitBeginAccess(BAI);
else if (auto *BUAI = dyn_cast<BeginUnpairedAccessInst>(I))
visitBeginAccess(BUAI);
}
void StorageAccessInfo::print(raw_ostream &os) const {
os << " [" << getSILAccessKindName(getAccessKind()) << "] ";
if (hasNoNestedConflict())
os << "[no_nested_conflict] ";
AccessedStorage::print(os);
}
void StorageAccessInfo::dump() const { print(llvm::dbgs()); }
void AccessedStorageResult::print(raw_ostream &os) const {
for (auto &storageAccess : storageAccessSet)
storageAccess.print(os);
if (unidentifiedAccess != None) {
os << " unidentified accesses: "
<< getSILAccessKindName(unidentifiedAccess.getValue()) << "\n";
}
}
void AccessedStorageResult::dump() const { print(llvm::dbgs()); }
// -----------------------------------------------------------------------------
// MARK: FunctionAccessedStorage, implementation of
// GenericFunctionEffectAnalysis.
// -----------------------------------------------------------------------------
bool FunctionAccessedStorage::summarizeFunction(SILFunction *F) {
assert(accessResult.isEmpty() && "expected uninitialized results.");
if (F->isDefinition())
return false;
// If the function definition is unavailable, set unidentifiedAccess to a
// conservative value, since analyzeInstruction will never be called.
//
// If FunctionSideEffects can be summarized, use that information.
FunctionSideEffects functionSideEffects;
if (!functionSideEffects.summarizeFunction(F)) {
setWorstEffects();
// May as well consider this a successful summary since there are no
// instructions to visit anyway.
return true;
}
bool mayRead = functionSideEffects.getGlobalEffects().mayRead();
bool mayWrite = functionSideEffects.getGlobalEffects().mayWrite();
for (auto &paramEffects : functionSideEffects.getParameterEffects()) {
mayRead |= paramEffects.mayRead();
mayWrite |= paramEffects.mayWrite();
}
if (mayWrite)
accessResult.setUnidentifiedAccess(SILAccessKind::Modify);
else if (mayRead)
accessResult.setUnidentifiedAccess(SILAccessKind::Read);
// If function side effects is "readnone" then this result will have an empty
// storageAccessSet and unidentifiedAccess == None.
return true;
}
SILAnalysis *swift::createAccessedStorageAnalysis(SILModule *) {
return new AccessedStorageAnalysis();
}