mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
Reload oldPriority each time through the compare_exchange loop. Without this, we might race with another escalating thread and end up trying to set a priority that's lower or equal to the priority set by the other thread. This results in an assertion failure when asserts are enabled, or attempt to lower the priority of the task when asserts are not enabled. rdar://147888768
1254 lines
47 KiB
C++
1254 lines
47 KiB
C++
//===--- TaskStatus.cpp - Asynchronous task status tracking ---------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2020 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Routines for maintaining and interacting with the current state of a
|
|
// task, including tracking child tasks, deadlines, and cancellation.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "swift/ABI/TaskStatus.h"
|
|
#include "../CompatibilityOverride/CompatibilityOverride.h"
|
|
#include "TaskPrivate.h"
|
|
#include "swift/Runtime/AtomicWaitQueue.h"
|
|
#include "swift/Runtime/Concurrency.h"
|
|
#include "swift/Runtime/ExistentialContainer.h"
|
|
#include "swift/Threading/Mutex.h"
|
|
#include "swift/Threading/Thread.h"
|
|
#include <atomic>
|
|
|
|
using namespace swift;
|
|
|
|
inline TaskStatusRecord *
|
|
ActiveTaskStatus::getStatusRecordParent(TaskStatusRecord *ptr) {
|
|
return ptr->getParent();
|
|
}
|
|
|
|
/**************************************************************************/
|
|
/************************* RECORD LOCK MANAGEMENT *************************/
|
|
/**************************************************************************/
|
|
|
|
/// A lock used to protect management of task-specific status
|
|
/// record locks.
|
|
static LazyMutex StatusRecordLockLock;
|
|
|
|
namespace {
|
|
|
|
/// A lock record which can be used to protect a task's active
|
|
/// status records.
|
|
///
|
|
/// For the most part, the active task status records of a task are
|
|
/// only accessed by the task itself. If that were always true,
|
|
/// no synchronization would be required to change them. However,
|
|
/// cancellation and escalation can occur asynchronously, and they
|
|
/// must be able to inspect the status records without worrying about
|
|
/// their concurrent modification or destruction of the records.
|
|
/// Therefore, these operations freeze the active status records
|
|
/// for their duration. They do this by (1) setting a bit in the
|
|
/// task's `Status` field state which says that the records are
|
|
/// locked and (2) creating a lock record as the new innermost
|
|
/// status record. When the operation is complete, it removes this
|
|
/// record and clears the lock bit, then notifies the lock record that
|
|
/// the locking operation is complete.
|
|
///
|
|
/// Note that this status record lock only protects concurrent
|
|
/// modifications/access from *other* threads which may be trying to
|
|
/// inspect/modify a task's status records. A thread which already
|
|
/// owns the StatusRecordLock may recursively take it and modify
|
|
/// the status record list.
|
|
///
|
|
/// When a task wants to iterate task status records, but
|
|
/// it sees that the locked bit is set in the `Status` field, it
|
|
/// must acquire the global status-record lock, find this record
|
|
/// (which should be the innermost record), and wait for an unlock if
|
|
/// the task is not the lock owner. If it already owns the
|
|
/// status record lock, it may proceed.
|
|
///
|
|
class StatusRecordLockRecord
|
|
: public AtomicWaitQueue<StatusRecordLockRecord, LazyMutex>,
|
|
public TaskStatusRecord {
|
|
Thread Owner;
|
|
public:
|
|
|
|
StatusRecordLockRecord(TaskStatusRecord *parent)
|
|
: TaskStatusRecord(TaskStatusRecordKind::Private_RecordLock, parent) {
|
|
// When we create a lock record, we always take it pre-locked
|
|
Owner = Thread::current();
|
|
}
|
|
|
|
void updateForNewArguments(TaskStatusRecord *parent) {
|
|
Parent = parent;
|
|
}
|
|
|
|
static bool classof(const TaskStatusRecord *record) {
|
|
return record->getKind() == TaskStatusRecordKind::Private_RecordLock;
|
|
}
|
|
|
|
bool isStatusRecordLockedBySelf() {
|
|
return Owner == Thread::current();
|
|
}
|
|
|
|
};
|
|
}
|
|
|
|
/// If the status record is already self locked, returns true
|
|
///
|
|
/// If the status record is not self locked, then wait for the owner to unlock
|
|
/// before we return. We still have to retry getting the lock ourselves and may
|
|
/// still run into a race here.
|
|
static bool waitForStatusRecordUnlockIfNotSelfLocked(AsyncTask *task,
|
|
ActiveTaskStatus &status) {
|
|
StatusRecordLockRecord::Waiter waiter(StatusRecordLockLock);
|
|
|
|
while (true) {
|
|
assert(status.isStatusRecordLocked());
|
|
bool selfLocked = false;
|
|
|
|
bool waited = waiter.tryReloadAndWait([&]() -> StatusRecordLockRecord* {
|
|
// Pairs with the store_release in installation of lock record in
|
|
// withStatusRecordLock so that lock record contents are visible due to
|
|
// load-through HW address dependency
|
|
status = task->_private()._status().load(SWIFT_MEMORY_ORDER_CONSUME);
|
|
_swift_tsan_consume(task);
|
|
|
|
if (!status.isStatusRecordLocked())
|
|
return nullptr;
|
|
|
|
auto record = cast<StatusRecordLockRecord>(status.getInnermostRecord());
|
|
// We can safely look inside the record now
|
|
if (record->isStatusRecordLockedBySelf()) {
|
|
selfLocked = true;
|
|
return nullptr;
|
|
}
|
|
return record;
|
|
});
|
|
|
|
if (!waited)
|
|
return selfLocked;
|
|
|
|
// Reload the status before trying to relock
|
|
status = task->_private()._status().load(SWIFT_MEMORY_ORDER_CONSUME);
|
|
_swift_tsan_consume(task);
|
|
if (!status.isStatusRecordLocked())
|
|
return false;
|
|
}
|
|
}
|
|
|
|
/// Wait for a task's status record lock to be unlocked. This asserts that the
|
|
/// lock is not owned by self as that would result in a deadlock.
|
|
///
|
|
/// When this function returns, `status` will have been updated
|
|
/// to the last value read and `isStatusRecordLocked()` will be false.
|
|
/// Of course, another thread may still be concurrently trying
|
|
/// to acquire the record lock.
|
|
static void waitForStatusRecordUnlock(AsyncTask *task,
|
|
ActiveTaskStatus &status) {
|
|
// Acquire the lock.
|
|
StatusRecordLockRecord::Waiter waiter(StatusRecordLockLock);
|
|
|
|
while (true) {
|
|
assert(status.isStatusRecordLocked());
|
|
|
|
bool waited = waiter.tryReloadAndWait([&]() -> StatusRecordLockRecord* {
|
|
// Pairs with the store_release in installation of lock record in
|
|
// withStatusRecordLock so that lock record contents are visible due to
|
|
// load-through HW address dependency
|
|
status = task->_private()._status().load(SWIFT_MEMORY_ORDER_CONSUME);
|
|
_swift_tsan_consume(task);
|
|
if (!status.isStatusRecordLocked())
|
|
return nullptr;
|
|
|
|
// The innermost entry should be a record lock record; Verify that we are
|
|
// not the owner and then wait for it to be unlocked.
|
|
auto record = cast<StatusRecordLockRecord>(status.getInnermostRecord());
|
|
if (record->isStatusRecordLockedBySelf()) {
|
|
swift_Concurrency_fatalError(0, "Waiting on a status record lock that is owned by self");
|
|
}
|
|
return record;
|
|
});
|
|
if (!waited)
|
|
return;
|
|
|
|
// Reload the status before trying to relock.
|
|
status = task->_private()._status().load(SWIFT_MEMORY_ORDER_CONSUME);
|
|
_swift_tsan_consume(task);
|
|
if (!status.isStatusRecordLocked())
|
|
return;
|
|
}
|
|
}
|
|
|
|
/// This function grabs the status record lock of the input task and invokes
|
|
/// `fn` while holding the StatusRecordLock of the input task.
|
|
///
|
|
/// If the client of withStatusRecordLock has already loaded the status of the
|
|
/// task, they may pass it into this function to avoid a double-load.
|
|
///
|
|
/// The input `fn` is invoked once while holding the status record lock.
|
|
///
|
|
/// The optional `statusUpdate` is invoked while releasing the StatusRecordLock
|
|
/// from the ActiveTaskStatus so that callers may make additional modifications
|
|
/// to ActiveTaskStatus flags. `statusUpdate` can be called multiple times in a
|
|
/// RMW loop and so much be idempotent.
|
|
static bool withStatusRecordLock(AsyncTask *task, ActiveTaskStatus status,
|
|
llvm::function_ref<void(ActiveTaskStatus)>fn,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)> statusUpdate = nullptr) {
|
|
|
|
StatusRecordLockRecord::Worker worker(StatusRecordLockLock);
|
|
|
|
TaskStatusRecord *oldRecord;
|
|
StatusRecordLockRecord *lockingRecord;
|
|
|
|
// Take the lock record
|
|
bool installedLockRecord = false;
|
|
while (true) {
|
|
if (status.isStatusRecordLocked() &&
|
|
waitForStatusRecordUnlockIfNotSelfLocked(task, status)) {
|
|
// Top record is status record lock and we own it.
|
|
SWIFT_TASK_DEBUG_LOG("[StatusRecordLock] Lock for task %p is already owned by thread", task);
|
|
break;
|
|
}
|
|
|
|
// Make (or reconfigure) a lock record
|
|
oldRecord = status.getInnermostRecord();
|
|
lockingRecord = worker.createQueue(oldRecord);
|
|
|
|
// Publish the lock record
|
|
// * We need an acquire to pair with release of someone else who might have
|
|
// unlocked
|
|
// * We need a store release to publish the lock record contents
|
|
ActiveTaskStatus newStatus = status.withLockingRecord(lockingRecord);
|
|
if (task->_private()._status().compare_exchange_weak(status, newStatus,
|
|
/*success*/ std::memory_order_acq_rel,
|
|
/*failure*/ std::memory_order_relaxed)) {
|
|
_swift_tsan_acquire(task);
|
|
_swift_tsan_release(task);
|
|
|
|
status = newStatus;
|
|
|
|
status.traceStatusChanged(task, false);
|
|
worker.flagQueueIsPublished(lockingRecord);
|
|
installedLockRecord = true;
|
|
|
|
// We've locked the status
|
|
assert(worker.isWorkerThread());
|
|
break;
|
|
}
|
|
}
|
|
|
|
// Call the function.
|
|
fn(status);
|
|
|
|
// Release lock record if we installed it earlier and restore the old record
|
|
// at the top.
|
|
while (true) {
|
|
auto newStatus = status;
|
|
|
|
assert(status.isStatusRecordLocked());
|
|
if (installedLockRecord) {
|
|
newStatus = status.withoutLockingRecord();
|
|
}
|
|
|
|
// If the caller of the function wanted to modify something, let them.
|
|
if (statusUpdate) {
|
|
statusUpdate(status, newStatus);
|
|
}
|
|
|
|
// We are releasing the status record lock, all modifications done while
|
|
// holding the lock should now be published to anyone else who is waiting to
|
|
// acquire the lock next
|
|
_swift_tsan_release(task);
|
|
if (task->_private()._status().compare_exchange_weak(status, newStatus,
|
|
/*success*/ std::memory_order_release,
|
|
/*failure*/ std::memory_order_relaxed)) {
|
|
newStatus.traceStatusChanged(task, false);
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (installedLockRecord) {
|
|
// Unblock any waiters.
|
|
worker.finishAndUnpublishQueue([]{});
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
/// A convenience version of the above for contexts that haven't already
|
|
/// done the load.
|
|
template <class Fn>
|
|
static bool withStatusRecordLock(
|
|
AsyncTask *task, Fn &&fn,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)> statusUpdate = nullptr) {
|
|
ActiveTaskStatus status = task->_private()._status().load(std::memory_order_relaxed);
|
|
return withStatusRecordLock(task, status, [&](ActiveTaskStatus taskStatus) {
|
|
fn(taskStatus);
|
|
}, /*statusUpdate=*/statusUpdate);
|
|
}
|
|
|
|
/**************************************************************************/
|
|
/*************************** RECORD MANAGEMENT ****************************/
|
|
/**************************************************************************/
|
|
|
|
SWIFT_CC(swift)
|
|
bool swift::addStatusRecord(AsyncTask *task, TaskStatusRecord *newRecord,
|
|
ActiveTaskStatus& oldStatus,
|
|
llvm::function_ref<bool(ActiveTaskStatus, ActiveTaskStatus&)> shouldAddRecord) {
|
|
|
|
SWIFT_TASK_DEBUG_LOG("Adding %p record to task %p", newRecord, task);
|
|
while (true) {
|
|
// Wait for any active lock to be released.
|
|
if (oldStatus.isStatusRecordLocked()) {
|
|
bool selfLocked = waitForStatusRecordUnlockIfNotSelfLocked(task, oldStatus);
|
|
static_cast<void>(selfLocked);
|
|
assert(!selfLocked);
|
|
}
|
|
|
|
// Reset the parent of the new record.
|
|
newRecord->resetParent(oldStatus.getInnermostRecord());
|
|
|
|
ActiveTaskStatus newStatus = oldStatus.withInnermostRecord(newRecord);
|
|
if (shouldAddRecord(oldStatus, newStatus)) {
|
|
// We have to use a release on success to make the initialization of
|
|
// the new record visible to an asynchronous thread trying to modify the
|
|
// status records.
|
|
_swift_tsan_release(task);
|
|
if (task->_private()._status().compare_exchange_weak(oldStatus, newStatus,
|
|
/*success*/ std::memory_order_release,
|
|
/*failure*/ std::memory_order_relaxed)) {
|
|
newStatus.traceStatusChanged(task, false);
|
|
return true;
|
|
} else {
|
|
// Retry
|
|
}
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
bool swift::addStatusRecord(AsyncTask *task, TaskStatusRecord *newRecord,
|
|
llvm::function_ref<bool(ActiveTaskStatus, ActiveTaskStatus&)> shouldAddRecord) {
|
|
auto oldStatus = task->_private()._status().load(std::memory_order_relaxed);
|
|
|
|
return addStatusRecord(task, newRecord, oldStatus, shouldAddRecord);
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
bool swift::addStatusRecordToSelf(TaskStatusRecord *record,
|
|
llvm::function_ref<bool(ActiveTaskStatus, ActiveTaskStatus&)> testAddRecord) {
|
|
return addStatusRecord(swift_task_getCurrent(), record, testAddRecord);
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
bool swift::addStatusRecordToSelf(TaskStatusRecord *record, ActiveTaskStatus &status,
|
|
llvm::function_ref<bool(ActiveTaskStatus, ActiveTaskStatus&)> testAddRecord) {
|
|
return addStatusRecord(swift_task_getCurrent(), record, status, testAddRecord);
|
|
}
|
|
|
|
static void removeStatusRecordLocked(ActiveTaskStatus status, TaskStatusRecord *record) {
|
|
bool removedRecord = false;
|
|
auto cur = status.getInnermostRecord();
|
|
assert(cur->getKind() == TaskStatusRecordKind::Private_RecordLock);
|
|
|
|
// Cut the record out.
|
|
while (cur != nullptr) {
|
|
auto next = cur->getParent();
|
|
if (next == record) {
|
|
cur->resetParent(record->getParent());
|
|
removedRecord = true;
|
|
break;
|
|
}
|
|
cur = next;
|
|
}
|
|
static_cast<void>(removedRecord);
|
|
assert(removedRecord);
|
|
}
|
|
|
|
// For when we are trying to remove a record and also optionally trying to
|
|
// modify some flags in the ActiveTaskStatus at the same time.
|
|
SWIFT_CC(swift)
|
|
void swift::removeStatusRecord(AsyncTask *task, TaskStatusRecord *record,
|
|
ActiveTaskStatus& oldStatus,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)>fn) {
|
|
|
|
SWIFT_TASK_DEBUG_LOG("remove status record = %p, from task = %p",
|
|
record, task);
|
|
|
|
if (oldStatus.isStatusRecordLocked() &&
|
|
waitForStatusRecordUnlockIfNotSelfLocked(task, oldStatus)) {
|
|
SWIFT_TASK_DEBUG_LOG("[StatusRecordLock] Lock for task %p is already owned by thread", task);
|
|
// Case 1: Top record is status record lock and this thread owns it.
|
|
//
|
|
// Since we have the lock, we can just remove the record we care about which
|
|
// should be in the list somewhere and then modify the flags
|
|
removeStatusRecordLocked(oldStatus, record);
|
|
|
|
if (fn) {
|
|
// Client wants to modify the flags on the status - do it in a loop to
|
|
// make sure we handle other concurrent updates.
|
|
while (true) {
|
|
auto newStatus = oldStatus;
|
|
fn(oldStatus, newStatus);
|
|
|
|
// We should still remain status record locked no matter what since we
|
|
// came in with the lock already
|
|
assert(newStatus.isStatusRecordLocked());
|
|
|
|
if (task->_private()._status().compare_exchange_weak(oldStatus, newStatus,
|
|
/*success*/ std::memory_order_relaxed,
|
|
/*failure*/ std::memory_order_relaxed)) {
|
|
newStatus.traceStatusChanged(task, false);
|
|
return;
|
|
}
|
|
}
|
|
} else {
|
|
// Client doesn't have any other flags to change on status, we came in
|
|
// self-locked and leave with the lock held. No other flags changed.
|
|
return;
|
|
}
|
|
}
|
|
|
|
assert(!oldStatus.isStatusRecordLocked());
|
|
|
|
while (true) {
|
|
// We raced with some *other* thread which concurrently locked this task.
|
|
if (oldStatus.isStatusRecordLocked()) {
|
|
waitForStatusRecordUnlock(task, oldStatus);
|
|
}
|
|
|
|
// Case 2: No status record lock, see if the record we are trying to pop off
|
|
// is the topmost record and if so, just get it out and modify the status
|
|
// flags if needed
|
|
if (oldStatus.getInnermostRecord() == record) {
|
|
auto newStatus = oldStatus.withInnermostRecord(record->getParent());
|
|
|
|
if (fn) {
|
|
fn(oldStatus, newStatus);
|
|
}
|
|
|
|
if (task->_private()._status().compare_exchange_weak(oldStatus, newStatus,
|
|
/*success*/ std::memory_order_relaxed,
|
|
/*failure*/ std::memory_order_relaxed)) {
|
|
newStatus.traceStatusChanged(task, false);
|
|
return;
|
|
}
|
|
// Restart the loop again - someone else modified status concurrently
|
|
continue;
|
|
}
|
|
|
|
// Case 3: If the record is not the innermost record, we need to acquire the
|
|
// status record lock; there's no way to splice the record list safely
|
|
// otherwise
|
|
break;
|
|
}
|
|
|
|
withStatusRecordLock(task, oldStatus, [&](ActiveTaskStatus status) {
|
|
removeStatusRecordLocked(status, record);
|
|
}, fn);
|
|
|
|
}
|
|
|
|
// For when we are trying to remove a record and also optionally trying to
|
|
// modify some flags in the ActiveTaskStatus at the same time.
|
|
SWIFT_CC(swift)
|
|
void swift::removeStatusRecordWhere(
|
|
AsyncTask *task,
|
|
ActiveTaskStatus& oldStatus,
|
|
llvm::function_ref<bool(ActiveTaskStatus, TaskStatusRecord*)> condition,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)> updateStatus) {
|
|
assert(condition && "condition is required");
|
|
SWIFT_TASK_DEBUG_LOG("remove status record where(), from task = %p",
|
|
task);
|
|
|
|
if (oldStatus.isStatusRecordLocked() &&
|
|
waitForStatusRecordUnlockIfNotSelfLocked(task, oldStatus)) {
|
|
SWIFT_TASK_DEBUG_LOG("[StatusRecordLock] Lock for task %p is already owned by thread", task);
|
|
// Case 1: Top record is status record lock and this thread owns it.
|
|
//
|
|
// Since we have the lock, we can just remove the record we care about which
|
|
// should be in the list somewhere and then modify the flags
|
|
for (auto cur : oldStatus.records()) {
|
|
if (condition(oldStatus, cur)) {
|
|
removeStatusRecordLocked(oldStatus, cur);
|
|
}
|
|
}
|
|
|
|
if (updateStatus) {
|
|
// Client wants to modify the flags on the status - do it in a loop to
|
|
// make sure we handle other concurrent updates.
|
|
while (true) {
|
|
auto newStatus = oldStatus;
|
|
updateStatus(oldStatus, newStatus);
|
|
|
|
// We should still remain status record locked no matter what since we
|
|
// came in with the lock already
|
|
assert(newStatus.isStatusRecordLocked());
|
|
|
|
if (task->_private()._status().compare_exchange_weak(oldStatus, newStatus,
|
|
/*success*/ std::memory_order_relaxed,
|
|
/*failure*/ std::memory_order_relaxed)) {
|
|
newStatus.traceStatusChanged(task, false);
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
assert(!oldStatus.isStatusRecordLocked());
|
|
// Case 2: Since we're expected to look at more than jut the innermost record,
|
|
// we need to acquire the status record lock; there's no way to splice the
|
|
// record list safely otherwise
|
|
withStatusRecordLock(task, oldStatus, [&](ActiveTaskStatus status) {
|
|
for (auto curr : status.records()) {
|
|
if (condition(status, curr)) {
|
|
removeStatusRecordLocked(status, curr);
|
|
}
|
|
}
|
|
}, updateStatus);
|
|
}
|
|
|
|
// Convenience wrapper for when client hasn't already done the load of the
|
|
// status
|
|
SWIFT_CC(swift)
|
|
void swift::removeStatusRecord(AsyncTask *task, TaskStatusRecord *record,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)>fn) {
|
|
auto oldStatus = task->_private()._status().load(std::memory_order_relaxed);
|
|
return removeStatusRecord(task, record, oldStatus, fn);
|
|
}
|
|
|
|
|
|
SWIFT_CC(swift)
|
|
void swift::removeStatusRecordWhere(
|
|
AsyncTask *task,
|
|
llvm::function_ref<bool(ActiveTaskStatus, TaskStatusRecord*)> condition,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)>updateStatus) {
|
|
auto status = task->_private()._status().load(std::memory_order_relaxed);
|
|
return removeStatusRecordWhere(task, status, condition, updateStatus);
|
|
}
|
|
|
|
// Convenience wrapper for modifications on current task
|
|
SWIFT_CC(swift)
|
|
void swift::removeStatusRecordFromSelf(TaskStatusRecord *record, ActiveTaskStatus &status,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)>fn) {
|
|
return removeStatusRecord(swift_task_getCurrent(), record, status, fn);
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
void swift::removeStatusRecordFromSelf(TaskStatusRecord *record,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)>fn) {
|
|
return removeStatusRecord(swift_task_getCurrent(), record, fn);
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
void swift::updateStatusRecord(AsyncTask *task, TaskStatusRecord *record,
|
|
llvm::function_ref<void()>updateRecord,
|
|
ActiveTaskStatus& status,
|
|
llvm::function_ref<void(ActiveTaskStatus, ActiveTaskStatus&)>fn) {
|
|
|
|
SWIFT_TASK_DEBUG_LOG("Updating status record %p of task %p", record, task);
|
|
withStatusRecordLock(task, status, [&](ActiveTaskStatus lockedStatus) {
|
|
#ifndef NDEBUG
|
|
bool foundRecord = false;
|
|
for (auto cur: lockedStatus.records()) {
|
|
if (cur == record) {
|
|
foundRecord = true;
|
|
break;
|
|
}
|
|
}
|
|
assert(foundRecord);
|
|
#endif
|
|
updateRecord();
|
|
}, fn);
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
static bool swift_task_hasTaskGroupStatusRecordImpl() {
|
|
auto task = swift_task_getCurrent();
|
|
|
|
// a group must be in a task, so if we're not in a task...
|
|
// then, we certainly are not in a group either!
|
|
if (!task)
|
|
return false;
|
|
|
|
bool foundTaskGroupRecord = false;
|
|
withStatusRecordLock(task, [&](ActiveTaskStatus status) {
|
|
// Scan for the task group record within all the active records.
|
|
for (auto record: status.records()) {
|
|
if (record->getKind() == TaskStatusRecordKind::TaskGroup) {
|
|
foundTaskGroupRecord = true;
|
|
return;
|
|
}
|
|
}
|
|
});
|
|
|
|
return foundTaskGroupRecord;
|
|
}
|
|
|
|
///**************************************************************************/
|
|
///************************** TASK EXECUTORS ********************************/
|
|
///**************************************************************************/
|
|
|
|
TaskExecutorRef AsyncTask::getPreferredTaskExecutor(bool assumeHasRecord) {
|
|
// We first check the executor preference status flag, in order to avoid
|
|
// having to scan through the records of the task checking if there was
|
|
// such record.
|
|
//
|
|
// This is an optimization in order to make the enqueue/run
|
|
// path of a task avoid excessive work if a task had many records.
|
|
if (!hasTaskExecutorPreferenceRecord()) {
|
|
return TaskExecutorRef::undefined(); // "no executor preference"
|
|
}
|
|
|
|
TaskExecutorRef preference = TaskExecutorRef::undefined();
|
|
withStatusRecordLock(this, [&](ActiveTaskStatus status) {
|
|
for (auto record : status.records()) {
|
|
if (record->getKind() == TaskStatusRecordKind::TaskExecutorPreference) {
|
|
auto executorPreferenceRecord =
|
|
cast<TaskExecutorPreferenceStatusRecord>(record);
|
|
preference = executorPreferenceRecord->getPreferredExecutor();
|
|
return;
|
|
}
|
|
}
|
|
});
|
|
|
|
return preference;
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
static TaskExecutorRef
|
|
swift_task_getPreferredTaskExecutorImpl() {
|
|
if (auto task = swift_task_getCurrent()) {
|
|
return task->getPreferredTaskExecutor();
|
|
}
|
|
|
|
return TaskExecutorRef::undefined(); // "no executor preference"
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
static TaskExecutorPreferenceStatusRecord *
|
|
swift_task_pushTaskExecutorPreferenceImpl(TaskExecutorRef taskExecutor) {
|
|
auto task = swift_task_getCurrent();
|
|
if (!task) {
|
|
// we cannot push a preference if we're not in a task (including in
|
|
// compatibility tests), so we return eagerly.
|
|
return nullptr;
|
|
}
|
|
|
|
void *allocation = _swift_task_alloc_specific(
|
|
task, sizeof(class TaskExecutorPreferenceStatusRecord));
|
|
auto record =
|
|
::new (allocation) TaskExecutorPreferenceStatusRecord(
|
|
taskExecutor,
|
|
// we don't retain the executor by the task/record, because the "push"
|
|
// is implemented as a scope which keeps the executor alive by itself
|
|
// already, so we save the retain/release pair by the task doing it
|
|
// as well. In contrast, unstructured task creation always retains
|
|
// the executor.
|
|
/*retainedExecutor=*/false);
|
|
SWIFT_TASK_DEBUG_LOG("[TaskExecutorPreference] Create task executor "
|
|
"preference record %p for task:%p",
|
|
allocation, task);
|
|
|
|
|
|
addStatusRecord(task, record,
|
|
[&](ActiveTaskStatus oldStatus, ActiveTaskStatus &newStatus) {
|
|
// We use a flag to mark a task executor preference is
|
|
// present in order to avoid looking for task executor
|
|
// records when running the task, and we know there is no
|
|
// task executor preference present.
|
|
newStatus = newStatus.withTaskExecutorPreference();
|
|
|
|
return true; // always add the record
|
|
});
|
|
|
|
return record;
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
static void swift_task_popTaskExecutorPreferenceImpl(
|
|
TaskExecutorPreferenceStatusRecord *record) {
|
|
SWIFT_TASK_DEBUG_LOG("[TaskExecutorPreference] Remove task executor "
|
|
"preference record %p from task:%p",
|
|
record, swift_task_getCurrent());
|
|
// We keep count of how many records there are because if there is more than
|
|
// one, it means the task status flag should still be "has task preference".
|
|
int preferenceRecordsCount = 0;
|
|
|
|
auto task = swift_task_getCurrent();
|
|
if (!task)
|
|
return;
|
|
|
|
removeStatusRecordWhere(
|
|
task,
|
|
/*condition=*/[&](ActiveTaskStatus status, TaskStatusRecord *cur) {
|
|
assert(status.hasTaskExecutorPreference() && "does not have record!");
|
|
|
|
if (cur->getKind() == TaskStatusRecordKind::TaskExecutorPreference) {
|
|
preferenceRecordsCount += 1;
|
|
|
|
return preferenceRecordsCount == 1 &&
|
|
record == cast<TaskExecutorPreferenceStatusRecord>(cur);
|
|
}
|
|
return false;
|
|
},
|
|
/*updateStatus==*/[&](ActiveTaskStatus oldStatus, ActiveTaskStatus &newStatus) {
|
|
if (preferenceRecordsCount == 1) {
|
|
// if this was the last record removed, we flip the flag to off.
|
|
assert(oldStatus.hasTaskExecutorPreference());
|
|
newStatus = newStatus.withoutTaskExecutorPreference();
|
|
}
|
|
});
|
|
|
|
swift_task_dealloc(record);
|
|
}
|
|
|
|
void AsyncTask::pushInitialTaskExecutorPreference(
|
|
TaskExecutorRef preferredExecutor, bool owned) {
|
|
void *allocation = _swift_task_alloc_specific(
|
|
this, sizeof(class TaskExecutorPreferenceStatusRecord));
|
|
auto record =
|
|
::new (allocation) TaskExecutorPreferenceStatusRecord(
|
|
preferredExecutor, /*ownsExecutor=*/owned);
|
|
SWIFT_TASK_DEBUG_LOG("[InitialTaskExecutorPreference] Create a task "
|
|
"preference record %p for task:%p",
|
|
record, this);
|
|
|
|
addStatusRecord(this, record,
|
|
[&](ActiveTaskStatus oldStatus, ActiveTaskStatus &newStatus) {
|
|
// We use a flag to mark a task executor preference is
|
|
// present in order to avoid looking for task executor
|
|
// records when running the task, and we know there is no
|
|
// task executor preference present.
|
|
newStatus = newStatus.withTaskExecutorPreference();
|
|
|
|
return true;
|
|
});
|
|
}
|
|
|
|
// ONLY use this method while destroying task and removing the "initial"
|
|
// preference. In all other situations prefer a balanced "push / pop" pair of
|
|
// calls.
|
|
void AsyncTask::dropInitialTaskExecutorPreferenceRecord() {
|
|
SWIFT_TASK_DEBUG_LOG("[InitialTaskExecutorPreference] Drop initial task "
|
|
"preference record from task:%p",
|
|
this);
|
|
assert(hasInitialTaskExecutorPreferenceRecord());
|
|
|
|
HeapObject *executorIdentityToRelease = nullptr;
|
|
withStatusRecordLock(this, [&](ActiveTaskStatus status) {
|
|
for (auto r : status.records()) {
|
|
if (r->getKind() == TaskStatusRecordKind::TaskExecutorPreference) {
|
|
auto record = cast<TaskExecutorPreferenceStatusRecord>(r);
|
|
|
|
if (record->hasRetainedExecutor()) {
|
|
// Some tasks own their executor (i.e. take it consuming and guarantee
|
|
// its lifetime dynamically), while strictly structured tasks like
|
|
// async let do not retain it
|
|
executorIdentityToRelease =
|
|
record->getPreferredExecutor().getIdentity();
|
|
}
|
|
|
|
removeStatusRecordLocked(status, record);
|
|
_swift_task_dealloc_specific(this, record);
|
|
return;
|
|
}
|
|
}
|
|
|
|
// This drop mirrors the push "initial" preference during task creation;
|
|
// so it must always reliably always have a preference to drop.
|
|
assert(false && "dropInitialTaskExecutorPreferenceRecord must be "
|
|
"guaranteed to drop the last preference");
|
|
});
|
|
|
|
// Release the "initial" preferred task executor, because it was specifically
|
|
// set in a Task initializer, which retained it.
|
|
//
|
|
// This should not be done for withTaskExecutorPreference executors,
|
|
// however in that case, we would not enter this function here to clean up.
|
|
//
|
|
// NOTE: This MUST NOT assume that the object is a swift object (and use
|
|
// swift_release), because a dispatch_queue_t conforms to TaskExecutor,
|
|
// and may be passed in here; in which case swift_releasing it would be incorrect.
|
|
swift_unknownObjectRelease(executorIdentityToRelease);
|
|
}
|
|
|
|
/******************************************************************************/
|
|
/************************** TASK NAMING ***************************************/
|
|
/******************************************************************************/
|
|
|
|
void AsyncTask::pushInitialTaskName(const char* _taskName) {
|
|
assert(_taskName && "Task name must not be null!");
|
|
assert(hasInitialTaskNameRecord() && "Attempted pushing name but task has no initial task name flag!");
|
|
|
|
void *allocation = _swift_task_alloc_specific(
|
|
this, sizeof(class TaskNameStatusRecord));
|
|
|
|
// TODO: Copy the string maybe into the same allocation at an offset or retain the swift string?
|
|
auto taskNameLen = strlen(_taskName);
|
|
char* taskNameCopy = reinterpret_cast<char*>(
|
|
_swift_task_alloc_specific(this, taskNameLen + 1/*null terminator*/));
|
|
(void) strncpy(/*dst=*/taskNameCopy, /*src=*/_taskName, taskNameLen);
|
|
taskNameCopy[taskNameLen] = '\0'; // make sure we null-terminate
|
|
|
|
auto record =
|
|
::new (allocation) TaskNameStatusRecord(taskNameCopy);
|
|
SWIFT_TASK_DEBUG_LOG("[TaskName] Create initial task name record %p "
|
|
"for task:%p, name:%s", record, this, taskNameCopy);
|
|
|
|
addStatusRecord(this, record,
|
|
[&](ActiveTaskStatus oldStatus, ActiveTaskStatus &newStatus) {
|
|
return true; // always add the record
|
|
});
|
|
}
|
|
|
|
void AsyncTask::dropInitialTaskNameRecord() {
|
|
if (!hasInitialTaskNameRecord()) {
|
|
return;
|
|
}
|
|
|
|
SWIFT_TASK_DEBUG_LOG("[TaskName] Drop initial task name record for task:%p", this);
|
|
withStatusRecordLock(this, [&](ActiveTaskStatus status) {
|
|
for (auto cur : status.records()) {
|
|
if (cur->getKind() == TaskStatusRecordKind::TaskName) {
|
|
auto record = cast<TaskNameStatusRecord>(cur);
|
|
|
|
SWIFT_TASK_DEBUG_LOG("[TaskName] Drop initial task name record %p "
|
|
"for task:%p", record, this);
|
|
|
|
removeStatusRecordLocked(status, record);
|
|
// Since we first allocated the record, and then the string copy
|
|
char *name = const_cast<char*>(record->getName());
|
|
_swift_task_dealloc_specific(this, name);
|
|
_swift_task_dealloc_specific(this, record);
|
|
return;
|
|
}
|
|
}
|
|
|
|
// This drop mirrors the push "initial" name during task creation;
|
|
// so it must always reliably always have a preference to drop.
|
|
assert(false && "dropInitialTaskNameRecord must be guaranteed to drop "
|
|
"the initial task name record if it was present");
|
|
});
|
|
}
|
|
|
|
const char*
|
|
AsyncTask::getTaskName() {
|
|
// We first check the executor preference status flag, in order to avoid
|
|
// having to scan through the records of the task checking if there was
|
|
// such record.
|
|
//
|
|
// This is an optimization in order to make the enqueue/run
|
|
// path of a task avoid excessive work if a task had many records.
|
|
if (!hasInitialTaskNameRecord()) {
|
|
return nullptr;
|
|
}
|
|
|
|
const char *data = nullptr;
|
|
withStatusRecordLock(this, [&](ActiveTaskStatus status) {
|
|
for (auto record : status.records()) {
|
|
if (record->getKind() == TaskStatusRecordKind::TaskName) {
|
|
auto nameRecord = cast<TaskNameStatusRecord>(record);
|
|
data = nameRecord->getName();
|
|
return;
|
|
}
|
|
}
|
|
});
|
|
|
|
return data;
|
|
}
|
|
|
|
/**************************************************************************/
|
|
/************************** CHILD TASK MANAGEMENT *************************/
|
|
/**************************************************************************/
|
|
|
|
// ==== Child tasks ------------------------------------------------------------
|
|
|
|
/// Called in the path of linking a child into a parent/group synchronously with
|
|
/// the parent task.
|
|
//
|
|
/// When called to link a child into a parent directly, this does not hold the
|
|
/// parent's task status record lock. When called to link a child into a task
|
|
/// group, this holds the parent's task status record lock.
|
|
SWIFT_CC(swift)
|
|
void swift::updateNewChildWithParentAndGroupState(AsyncTask *child,
|
|
ActiveTaskStatus parentStatus,
|
|
TaskGroup *group) {
|
|
// We can take the fast path of just modifying the ActiveTaskStatus in the
|
|
// child task since we know that it won't have any task status records and
|
|
// cannot be accessed by anyone else since it hasn't been linked in yet.
|
|
// Avoids the extra logic in `swift_task_cancel` and `swift_task_escalate`
|
|
auto oldChildTaskStatus =
|
|
child->_private()._status().load(std::memory_order_relaxed);
|
|
assert(oldChildTaskStatus.getInnermostRecord() == NULL);
|
|
|
|
auto newChildTaskStatus = oldChildTaskStatus;
|
|
|
|
if (parentStatus.isCancelled() || (group && group->isCancelled())) {
|
|
newChildTaskStatus = newChildTaskStatus.withCancelled();
|
|
}
|
|
|
|
// Propagate max priority of parent to child task's active status
|
|
JobPriority pri = parentStatus.getStoredPriority();
|
|
newChildTaskStatus =
|
|
newChildTaskStatus.withNewPriority(withUserInteractivePriorityDowngrade(pri));
|
|
|
|
child->_private()._status().store(newChildTaskStatus, std::memory_order_relaxed);
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
static void swift_taskGroup_attachChildImpl(TaskGroup *group,
|
|
AsyncTask *child) {
|
|
|
|
// We are always called from the context of the parent
|
|
//
|
|
// Acquire the status record lock of parent - we want to synchronize with
|
|
// concurrent cancellation or escalation as we're adding new tasks to the
|
|
// group.
|
|
auto parent = child->childFragment()->getParent();
|
|
assert(parent == swift_task_getCurrent());
|
|
|
|
withStatusRecordLock(parent, [&](ActiveTaskStatus parentStatus) {
|
|
group->addChildTask(child);
|
|
|
|
// After getting parent's status record lock, do some soundness checks to
|
|
// see if parent task or group has state changes that need to be
|
|
// propagated to the child.
|
|
//
|
|
// This is the same logic that we would do if we were adding a child
|
|
// task status record - see also asyncLet_addImpl. Since we attach a
|
|
// child task to a TaskGroupRecord instead, we synchronize on the
|
|
// parent's task status and then update the child.
|
|
updateNewChildWithParentAndGroupState(child, parentStatus, group);
|
|
});
|
|
}
|
|
|
|
void swift::_swift_taskGroup_detachChild(TaskGroup *group,
|
|
AsyncTask *child) {
|
|
// We are called synchronously from the perspective of the owning task.
|
|
// That doesn't necessarily mean the owning task *is* the current task,
|
|
// though, just that it's not concurrently running.
|
|
auto parent = child->childFragment()->getParent();
|
|
|
|
withStatusRecordLock(parent, [&](ActiveTaskStatus unused) {
|
|
group->removeChildTask(child);
|
|
});
|
|
}
|
|
|
|
/// Cancel all the child tasks that belong to `group`.
|
|
///
|
|
/// The caller must guarantee that this is called while holding the owning
|
|
/// task's status record lock.
|
|
void swift::_swift_taskGroup_cancelAllChildren(TaskGroup *group) {
|
|
// Because only the owning task of the task group can modify the
|
|
// child list of a task group status record, and it can only do so
|
|
// while holding the owning task's status record lock, we do not need
|
|
// any additional synchronization within this function.
|
|
for (auto childTask : group->getTaskRecord()->children())
|
|
swift_task_cancel(childTask);
|
|
}
|
|
|
|
/// Cancel all the child tasks that belong to `group`.
|
|
///
|
|
/// The caller must guarantee that this is called from the owning task.
|
|
void swift::_swift_taskGroup_cancelAllChildren_unlocked(TaskGroup *group,
|
|
AsyncTask *owningTask) {
|
|
// Early out. If there are no children, there's nothing to do. We can safely
|
|
// check this without locking, since this can only be concurrently mutated
|
|
// from a child task. If there are no children then no more can be added.
|
|
if (!group->getTaskRecord()->getFirstChild())
|
|
return;
|
|
|
|
withStatusRecordLock(owningTask, [&group](ActiveTaskStatus status) {
|
|
_swift_taskGroup_cancelAllChildren(group);
|
|
});
|
|
}
|
|
|
|
/**************************************************************************/
|
|
/****************************** CANCELLATION ******************************/
|
|
/**************************************************************************/
|
|
|
|
/// Perform any cancellation actions required by the given record.
|
|
static void performCancellationAction(TaskStatusRecord *record) {
|
|
switch (record->getKind()) {
|
|
// Child tasks need to be recursively cancelled.
|
|
case TaskStatusRecordKind::ChildTask: {
|
|
auto childRecord = cast<ChildTaskStatusRecord>(record);
|
|
for (AsyncTask *child: childRecord->children())
|
|
swift_task_cancel(child);
|
|
return;
|
|
}
|
|
|
|
// Task groups need their children to be cancelled. Note that we do
|
|
// not want to formally cancel the task group itself; that property is
|
|
// under the synchronous control of the task that owns the group.
|
|
case TaskStatusRecordKind::TaskGroup: {
|
|
auto groupRecord = cast<TaskGroupTaskStatusRecord>(record);
|
|
_swift_taskGroup_cancelAllChildren(groupRecord->getGroup());
|
|
return;
|
|
}
|
|
|
|
// Cancellation notifications need to be called.
|
|
case TaskStatusRecordKind::CancellationNotification: {
|
|
auto notification =
|
|
cast<CancellationNotificationStatusRecord>(record);
|
|
notification->run();
|
|
return;
|
|
}
|
|
|
|
// Escalation notifications can be ignored.
|
|
case TaskStatusRecordKind::EscalationNotification:
|
|
return;
|
|
|
|
// Record locks shouldn't be found this way, but they don't have
|
|
// anything to do anyway.
|
|
case TaskStatusRecordKind::Private_RecordLock:
|
|
return;
|
|
|
|
// No cancellation action needs to be taken for dependency status records
|
|
case TaskStatusRecordKind::TaskDependency:
|
|
break;
|
|
|
|
// Cancellation has no impact on executor preference.
|
|
case TaskStatusRecordKind::TaskExecutorPreference:
|
|
break;
|
|
|
|
// Cancellation has no impact on task names.
|
|
case TaskStatusRecordKind::TaskName:
|
|
break;
|
|
}
|
|
|
|
// Other cases can fall through here and be ignored.
|
|
// FIXME: allow dynamic extension/correction?
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
static void swift_task_cancelImpl(AsyncTask *task) {
|
|
SWIFT_TASK_DEBUG_LOG("cancel task = %p", task);
|
|
|
|
auto oldStatus = task->_private()._status().load(std::memory_order_relaxed);
|
|
auto newStatus = oldStatus;
|
|
while (true) {
|
|
if (oldStatus.isCancelled()) {
|
|
return;
|
|
}
|
|
|
|
// Set cancelled bit even if oldStatus.isStatusRecordLocked()
|
|
newStatus = oldStatus.withCancelled();
|
|
|
|
// consume here pairs with the release in addStatusRecord.
|
|
if (task->_private()._status().compare_exchange_weak(oldStatus, newStatus,
|
|
/*success*/ SWIFT_MEMORY_ORDER_CONSUME,
|
|
/*failure*/ std::memory_order_relaxed)) {
|
|
_swift_tsan_consume(task);
|
|
break;
|
|
}
|
|
}
|
|
|
|
newStatus.traceStatusChanged(task, false);
|
|
if (newStatus.getInnermostRecord() == NULL) {
|
|
// No records, nothing to propagate
|
|
return;
|
|
}
|
|
|
|
withStatusRecordLock(task, newStatus, [&](ActiveTaskStatus status) {
|
|
for (auto cur : status.records()) {
|
|
// Some of the cancellation actions can cause us to recursively
|
|
// modify this list that is being iterated. However, cancellation is
|
|
// happening from outside of the task so we know that no new records will
|
|
// be added since that's only possible while on task.
|
|
performCancellationAction(cur);
|
|
}
|
|
});
|
|
}
|
|
|
|
/**************************************************************************/
|
|
/******************************* ESCALATION *******************************/
|
|
/**************************************************************************/
|
|
|
|
/// Perform any escalation actions required by the given record.
|
|
static void performEscalationAction(TaskStatusRecord *record,
|
|
JobPriority oldPriority,
|
|
JobPriority newPriority) {
|
|
switch (record->getKind()) {
|
|
// Child tasks need to be recursively escalated.
|
|
case TaskStatusRecordKind::ChildTask: {
|
|
auto childRecord = cast<ChildTaskStatusRecord>(record);
|
|
for (AsyncTask *child: childRecord->children())
|
|
swift_task_escalate(child, newPriority);
|
|
return;
|
|
}
|
|
case TaskStatusRecordKind::TaskGroup: {
|
|
auto childRecord = cast<TaskGroupTaskStatusRecord>(record);
|
|
for (AsyncTask *child: childRecord->children())
|
|
swift_task_escalate(child, newPriority);
|
|
return;
|
|
}
|
|
|
|
// Escalation notifications need to be called.
|
|
case TaskStatusRecordKind::EscalationNotification: {
|
|
auto notification =
|
|
cast<EscalationNotificationStatusRecord>(record);
|
|
SWIFT_TASK_DEBUG_LOG("[Dependency] Trigger task escalation handler record %p, escalate from %#x to %#x",
|
|
record, oldPriority, newPriority);
|
|
notification->run(oldPriority, newPriority);
|
|
return;
|
|
}
|
|
|
|
case TaskStatusRecordKind::TaskDependency: {
|
|
auto dependencyRecord = cast<TaskDependencyStatusRecord>(record);
|
|
SWIFT_TASK_DEBUG_LOG("[Dependency] Escalating a task dependency record %p from %#x to %#x",
|
|
record, oldPriority, newPriority);
|
|
dependencyRecord->performEscalationAction(oldPriority, newPriority);
|
|
return;
|
|
}
|
|
|
|
// Record locks shouldn't be found this way, but they don't have
|
|
// anything to do anyway.
|
|
case TaskStatusRecordKind::Private_RecordLock:
|
|
return;
|
|
// Cancellation notifications can be ignore.
|
|
case TaskStatusRecordKind::CancellationNotification:
|
|
return;
|
|
/// Executor preference we can ignore.
|
|
case TaskStatusRecordKind::TaskExecutorPreference:
|
|
return;
|
|
/// Task names don't matter to priority escalation.
|
|
case TaskStatusRecordKind::TaskName:
|
|
return;
|
|
}
|
|
|
|
// Other cases can fall through here and be ignored.
|
|
// FIXME: allow dynamic extension/correction?
|
|
}
|
|
|
|
SWIFT_CC(swift)
|
|
JobPriority
|
|
static swift_task_escalateImpl(AsyncTask *task, JobPriority newPriority) {
|
|
SWIFT_TASK_DEBUG_LOG("Escalating %p to %#zx priority", task, newPriority);
|
|
auto oldStatus = task->_private()._status().load(std::memory_order_relaxed);
|
|
auto oldPriority = oldStatus.getStoredPriority();
|
|
auto newStatus = oldStatus;
|
|
|
|
while (true) {
|
|
// Ensure oldPriority is up to date if we retry the compare_exchange.
|
|
oldPriority = oldStatus.getStoredPriority();
|
|
|
|
// Fast path: check that the stored priority is already at least
|
|
// as high as the desired priority.
|
|
if (oldPriority >= newPriority) {
|
|
SWIFT_TASK_DEBUG_LOG("Task is already at %#zx priority", oldPriority);
|
|
return oldPriority;
|
|
}
|
|
|
|
if (oldStatus.isRunning() || oldStatus.isEnqueued()) {
|
|
// Regardless of whether status record is locked or not, update the
|
|
// priority and RO bit on the task status
|
|
newStatus = oldStatus.withEscalatedPriority(newPriority);
|
|
} else if (oldStatus.isComplete()) {
|
|
// We raced with concurrent completion, nothing to escalate
|
|
SWIFT_TASK_DEBUG_LOG("Escalated a task %p which had completed, do nothing", task);
|
|
return oldStatus.getStoredPriority();
|
|
} else {
|
|
// Task is suspended.
|
|
newStatus = oldStatus.withNewPriority(newPriority);
|
|
}
|
|
|
|
// consume here pairs with the release in addStatusRecord.
|
|
if (task->_private()._status().compare_exchange_weak(oldStatus, newStatus,
|
|
/* success */ SWIFT_MEMORY_ORDER_CONSUME,
|
|
/* failure */ std::memory_order_relaxed)) {
|
|
_swift_tsan_consume(task);
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (newStatus.isRunning()) {
|
|
#if SWIFT_CONCURRENCY_ENABLE_PRIORITY_ESCALATION
|
|
// The task is running, escalate the thread that is running it.
|
|
ActiveTaskStatus *taskStatus;
|
|
dispatch_lock_t *executionLock;
|
|
|
|
taskStatus = (ActiveTaskStatus *) &task->_private()._status();
|
|
executionLock = (dispatch_lock_t *) ((char*)taskStatus + ActiveTaskStatus::executionLockOffset());
|
|
|
|
SWIFT_TASK_DEBUG_LOG("[Override] Escalating %p which is running on %#x from %#x to %#x",
|
|
task, newStatus.currentExecutionLockOwner(),
|
|
oldPriority, newPriority);
|
|
swift_dispatch_lock_override_start_with_debounce(
|
|
executionLock, newStatus.currentExecutionLockOwner(), (qos_class_t) newPriority);
|
|
#endif
|
|
} else if (newStatus.isEnqueued()) {
|
|
// Task is not running, it's enqueued somewhere waiting to be run
|
|
//
|
|
// TODO (rokhinip): Add a stealer to escalate the thread request for
|
|
// the task. Still mark the task has having been escalated so that the
|
|
// thread will self override when it starts draining the task
|
|
//
|
|
// TODO (rokhinip): Add a signpost to flag that this is a potential
|
|
// priority inversion
|
|
SWIFT_TASK_DEBUG_LOG("[Override] Escalating %p which is enqueued", task);
|
|
|
|
}
|
|
|
|
if (newStatus.getInnermostRecord() == NULL) {
|
|
return newStatus.getStoredPriority();
|
|
}
|
|
|
|
SWIFT_TASK_DEBUG_LOG("[Override] Escalating %p which is suspended from %#x to %#x",
|
|
task, oldPriority, newPriority);
|
|
// We must have at least one record - the task dependency one.
|
|
assert(newStatus.getInnermostRecord() != NULL);
|
|
|
|
withStatusRecordLock(task, newStatus, [&](ActiveTaskStatus status) {
|
|
// We know that none of the escalation actions will recursively
|
|
// modify the task status record list by adding or removing task records
|
|
for (auto cur: status.records()) {
|
|
performEscalationAction(cur, oldPriority, newPriority);
|
|
}
|
|
});
|
|
|
|
return newStatus.getStoredPriority();
|
|
}
|
|
|
|
void TaskDependencyStatusRecord::performEscalationAction(
|
|
JobPriority oldPriority, JobPriority newPriority) {
|
|
switch (this->DependencyKind) {
|
|
case WaitingOnTask:
|
|
SWIFT_TASK_DEBUG_LOG("[Dependency] Escalate dependent task %p noted in %p record",
|
|
this->DependentOn.Task, this);
|
|
swift_task_escalate(this->DependentOn.Task, newPriority);
|
|
break;
|
|
case WaitingOnContinuation:
|
|
// We can't do anything meaningful to escalate this since we don't know
|
|
// who will resume the continuation
|
|
SWIFT_TASK_DEBUG_LOG("[Dependency] Escalate dependent continuation %p noted in %p record -- do nothing",
|
|
this->DependentOn.Continuation, this);
|
|
break;
|
|
case WaitingOnTaskGroup:
|
|
// If a task is being escalated while waiting on a task group, the task
|
|
// should also have a TaskGroupTaskStatusRecord and the escalation
|
|
// action on that record should do the needful to propagate the
|
|
// escalation to the child tasks. We can short-circuit here.
|
|
SWIFT_TASK_DEBUG_LOG("[Dependency] Escalate dependent taskgroup %p noted in %p record -- do nothing",
|
|
this->DependentOn.TaskGroup, this);
|
|
break;
|
|
case EnqueuedOnExecutor:
|
|
SWIFT_TASK_DEBUG_LOG("[Dependency] Escalate dependent executor %p noted in %p record from %#x to %#x",
|
|
this->DependentOn.Executor, this, oldPriority, newPriority);
|
|
swift_executor_escalate(this->DependentOn.Executor, this->WaitingTask, newPriority);
|
|
break;
|
|
}
|
|
}
|
|
|
|
#define OVERRIDE_TASK_STATUS COMPATIBILITY_OVERRIDE
|
|
#include "../CompatibilityOverride/CompatibilityOverrideIncludePath.h"
|