mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
8770c7f826
This PR refactors the ASTDumper to make it more structured, less mistake-prone, and more amenable to future changes. For example:
```cpp
// Before:
void visitUnresolvedDotExpr(UnresolvedDotExpr *E) {
printCommon(E, "unresolved_dot_expr")
<< " field '" << E->getName() << "'";
PrintWithColorRAII(OS, ExprModifierColor)
<< " function_ref=" << getFunctionRefKindStr(E->getFunctionRefKind());
if (E->getBase()) {
OS << '\n';
printRec(E->getBase());
}
PrintWithColorRAII(OS, ParenthesisColor) << ')';
}
// After:
void visitUnresolvedDotExpr(UnresolvedDotExpr *E, StringRef label) {
printCommon(E, "unresolved_dot_expr", label);
printFieldQuoted(E->getName(), "field");
printField(E->getFunctionRefKind(), "function_ref", ExprModifierColor);
if (E->getBase()) {
printRec(E->getBase());
}
printFoot();
}
```
* Values are printed through calls to base class methods, rather than direct access to the underlying `raw_ostream`.
* These methods tend to reduce the chances of bugs like missing/extra spaces or newlines, too much/too little indentation, etc.
* More values are quoted, and unprintable/non-ASCII characters in quoted values are escaped before printing.
* Infrastructure to label child nodes now exists.
* Some weird breaks from the normal "style", like `PatternBindingDecl`'s original and processed initializers, have been brought into line.
* Some types that previously used ad-hoc dumping functions, like conformances and substitution maps, are now structured similarly to the dumper classes.
* I've fixed the odd dumping bug along the way. For example, distributed actors were only marked `actor`, not `distributed actor`.
This PR doesn't change the overall style of AST dumps; they're still pseudo-S-expressions. But the logic that implements this style is now isolated into a relatively small base class, making it feasible to introduce e.g. JSON dumping in the future.
50 lines
1.3 KiB
Swift
50 lines
1.3 KiB
Swift
// RUN: %target-swift-frontend -dump-ast %s | %FileCheck %s
|
|
// RUN: %target-swift-frontend -emit-ir %s > /dev/null
|
|
|
|
// RUN: %target-swift-frontend -dump-ast -DVAR %s | %FileCheck %s
|
|
// RUN: %target-swift-frontend -emit-ir -DVAR %s > /dev/null
|
|
|
|
// CHECK: (top_level_code_decl
|
|
// CHECK: (guard_stmt
|
|
#if VAR
|
|
guard var x = Optional(0) else { fatalError() }
|
|
#else
|
|
guard let x = Optional(0) else { fatalError() }
|
|
#endif
|
|
|
|
// CHECK: (top_level_code_decl
|
|
_ = 0 // intervening code
|
|
|
|
// CHECK-LABEL: (func_decl{{.*}}"function()" interface type="() -> ()" access=internal captures=(x<direct>)
|
|
func function() {
|
|
_ = x
|
|
}
|
|
|
|
// CHECK-LABEL: (processed_init=closure_expr
|
|
// CHECK: location={{.*}}top-level-guard.swift:[[@LINE+3]]
|
|
// CHECK: captures=(x<direct>)
|
|
// CHECK: (var_decl{{.*}}"closure"
|
|
let closure: () -> Void = {
|
|
_ = x
|
|
}
|
|
|
|
// CHECK-LABEL: (processed_init=capture_list
|
|
// CHECK: location={{.*}}top-level-guard.swift:[[@LINE+5]]
|
|
// CHECK: (closure_expr
|
|
// CHECK: location={{.*}}top-level-guard.swift:[[@LINE+3]]
|
|
// CHECK: captures=(x<direct>)
|
|
// CHECK: (var_decl{{.*}}"closureCapture"
|
|
let closureCapture: () -> Void = { [x] in
|
|
_ = x
|
|
}
|
|
|
|
// CHECK-LABEL: (defer_stmt
|
|
// CHECK-NEXT: (func_decl{{.*}}implicit "$defer()" interface type="() -> ()" access=fileprivate captures=(x<direct><noescape>)
|
|
defer {
|
|
_ = x
|
|
}
|
|
|
|
#if VAR
|
|
x = 5
|
|
#endif
|