mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
945c09b1cc
When we determine that an optional value needs to be unwrapped to make
an expression type check, use notes to provide several different
Fix-It options (with descriptions) rather than always pushing users
toward '!'. Specifically, the errors + Fix-Its now looks like this:
error: value of optional type 'X?' must be unwrapped to a value of
type 'X'
f(x)
^
note: coalesce using '??' to provide a default when the optional
value contains 'nil'
f(x)
^
?? <#default value#>
note: force-unwrap using '!' to abort execution if the optional
value contains 'nil'
f(x)
^
!
Fixes rdar://problem/42081852.
90 lines
2.9 KiB
Swift
90 lines
2.9 KiB
Swift
// RUN: %target-typecheck-verify-swift
|
|
|
|
func useInt(_ x: Int) {}
|
|
func useDouble(_ x: Double) {}
|
|
|
|
class B {
|
|
init() {}
|
|
}
|
|
class D1 : B {
|
|
override init() { super.init() }
|
|
}
|
|
class D2 : B {
|
|
override init() { super.init() }
|
|
}
|
|
|
|
func useB(_ x: B) {}
|
|
func useD1(_ x: D1) {}
|
|
func useD2(_ x: D2) {}
|
|
|
|
var a = true ? 1 : 0 // should infer Int
|
|
var b : Double = true ? 1 : 0 // should infer Double
|
|
var c = true ? 1 : 0.0 // should infer Double
|
|
var d = true ? 1.0 : 0 // should infer Double
|
|
|
|
useInt(a)
|
|
useDouble(b)
|
|
useDouble(c)
|
|
useDouble(d)
|
|
|
|
var z = true ? a : b // expected-error{{result values in '? :' expression have mismatching types 'Int' and 'Double'}}
|
|
var _ = a ? b : b // expected-error{{'Int' is not convertible to 'Bool'}}
|
|
|
|
|
|
|
|
var e = true ? B() : B() // should infer B
|
|
var f = true ? B() : D1() // should infer B
|
|
var g = true ? D1() : B() // should infer B
|
|
var h = true ? D1() : D1() // should infer D1
|
|
var i = true ? D1() : D2() // should infer B
|
|
|
|
useB(e)
|
|
useD1(e) // expected-error{{cannot convert value of type 'B' to expected argument type 'D1'}}
|
|
useB(f)
|
|
useD1(f) // expected-error{{cannot convert value of type 'B' to expected argument type 'D1'}}
|
|
useB(g)
|
|
useD1(g) // expected-error{{cannot convert value of type 'B' to expected argument type 'D1'}}
|
|
useB(h)
|
|
useD1(h)
|
|
useB(i)
|
|
useD1(i) // expected-error{{cannot convert value of type 'B' to expected argument type 'D1'}}
|
|
useD2(i) // expected-error{{cannot convert value of type 'B' to expected argument type 'D2'}}
|
|
|
|
var x = true ? 1 : 0
|
|
var y = 22 ? 1 : 0 // expected-error{{'Int' is not convertible to 'Bool'}}
|
|
|
|
_ = x ? x : x // expected-error {{'Int' is not convertible to 'Bool'}}
|
|
_ = true ? x : 1.2 // expected-error {{result values in '? :' expression have mismatching types 'Int' and 'Double'}}
|
|
|
|
_ = (x: true) ? true : false // expected-error {{'(x: Bool)' is not convertible to 'Bool'}}
|
|
_ = (x: 1) ? true : false // expected-error {{'(x: Int)' is not convertible to 'Bool'}}
|
|
|
|
let ib: Bool! = false
|
|
let eb: Bool? = .some(false)
|
|
let conditional = ib ? "Broken" : "Heart" // should infer Bool!
|
|
let conditional = eb ? "Broken" : "Heart" // expected-error {{value of optional type 'Bool?' must be unwrapped}}
|
|
// expected-note@-1{{coalesce using '??' to provide a default when the optional value contains 'nil'}}
|
|
// expected-note@-2{{force-unwrap using '!' to abort execution if the optional value contains 'nil'}}
|
|
|
|
// <rdar://problem/39586166> - crash when IfExpr has UnresolvedType in condition
|
|
struct Delegate {
|
|
var shellTasks: [ShellTask]
|
|
}
|
|
|
|
extension Array {
|
|
subscript(safe safe: Int) -> Element? { // expected-note {{found this candidate}}
|
|
get { }
|
|
set { }
|
|
}
|
|
}
|
|
|
|
struct ShellTask {
|
|
var commandLine: [String]
|
|
}
|
|
|
|
let delegate = Delegate(shellTasks: [])
|
|
_ = delegate.shellTasks[safe: 0]?.commandLine.compactMap({ $0.asString.hasPrefix("") ? $0 : nil }).count ?? 0
|
|
// expected-error@-1 {{ambiguous reference to member 'subscript'}}
|
|
|
|
// FIXME: Horrible diagnostic, but at least we no longer crash
|