mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
f3ff561c6f
This is phase-1 of switching from llvm::Optional to std::optional in the
next rebranch. llvm::Optional was removed from upstream LLVM, so we need
to migrate off rather soon. On Darwin, std::optional, and llvm::Optional
have the same layout, so we don't need to be as concerned about ABI
beyond the name mangling. `llvm::Optional` is only returned from one
function in
```
getStandardTypeSubst(StringRef TypeName,
bool allowConcurrencyManglings);
```
It's the return value, so it should not impact the mangling of the
function, and the layout is the same as `std::optional`, so it should be
mostly okay. This function doesn't appear to have users, and the ABI was
already broken 2 years ago for concurrency and no one seemed to notice
so this should be "okay".
I'm doing the migration incrementally so that folks working on main can
cherry-pick back to the release/5.9 branch. Once 5.9 is done and locked
away, then we can go through and finish the replacement. Since `None`
and `Optional` show up in contexts where they are not `llvm::None` and
`llvm::Optional`, I'm preparing the work now by going through and
removing the namespace unwrapping and making the `llvm` namespace
explicit. This should make it fairly mechanical to go through and
replace llvm::Optional with std::optional, and llvm::None with
std::nullopt. It's also a change that can be brought onto the
release/5.9 with minimal impact. This should be an NFC change.
101 lines
3.1 KiB
C++
101 lines
3.1 KiB
C++
//===--- Task.inc - ---------------------------------------------*- C++ -*-===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
///
|
|
/// \file
|
|
/// This file contains the default implementation of the class Task
|
|
///
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/ADT/ArrayRef.h"
|
|
#include "llvm/ADT/StringExtras.h"
|
|
#include "llvm/ADT/Optional.h"
|
|
#include "llvm/Support/FileSystem.h"
|
|
#include "llvm/Support/Program.h"
|
|
#include "llvm/Support/Signals.h"
|
|
|
|
namespace swift {
|
|
namespace sys {
|
|
|
|
// Platform-independent implementation of Task,
|
|
// a particular platform can provide its own more efficient version.
|
|
class Task {
|
|
public:
|
|
/// The path to the executable which this Task will execute.
|
|
const char *ExecPath;
|
|
|
|
/// Any arguments which should be passed during execution.
|
|
llvm::ArrayRef<const char *> Args;
|
|
|
|
/// The environment which should be used during execution. If empty,
|
|
/// the current process's environment will be used instead.
|
|
llvm::ArrayRef<const char *> Env;
|
|
|
|
/// Context associated with this Task.
|
|
void *Context;
|
|
|
|
/// True if the errors of the Task should be stored in Errors instead of
|
|
/// Output.
|
|
bool SeparateErrors;
|
|
|
|
llvm::SmallString<64> StdoutPath;
|
|
|
|
llvm::SmallString<64> StderrPath;
|
|
|
|
llvm::sys::ProcessInfo PI;
|
|
|
|
Task(const char *ExecPath, llvm::ArrayRef<const char *> Args,
|
|
llvm::ArrayRef<const char *> Env = llvm::None, void *Context = nullptr,
|
|
bool SeparateErrors = false)
|
|
: ExecPath(ExecPath), Args(Args), Env(Env), Context(Context),
|
|
SeparateErrors(SeparateErrors) {}
|
|
|
|
/// Begins execution of this Task.
|
|
/// \returns true on error.
|
|
bool execute();
|
|
};
|
|
|
|
bool Task::execute() {
|
|
llvm::SmallVector<const char *, 128> Argv;
|
|
Argv.push_back(ExecPath);
|
|
Argv.append(Args.begin(), Args.end());
|
|
Argv.push_back(nullptr);
|
|
|
|
llvm::Optional<llvm::ArrayRef<llvm::StringRef>> Envp =
|
|
Env.empty() ? decltype(Envp)(llvm::None)
|
|
: decltype(Envp)(llvm::toStringRefArray(Env.data()));
|
|
|
|
if (llvm::sys::fs::createTemporaryFile("stdout", "tmp", StdoutPath))
|
|
return true;
|
|
llvm::sys::RemoveFileOnSignal(StdoutPath);
|
|
|
|
if (SeparateErrors) {
|
|
if (llvm::sys::fs::createTemporaryFile("stderr", "tmp", StderrPath))
|
|
return true;
|
|
llvm::sys::RemoveFileOnSignal(StderrPath);
|
|
}
|
|
|
|
llvm::Optional<llvm::StringRef> Redirects[] = {
|
|
llvm::None,
|
|
llvm::StringRef{StdoutPath},
|
|
llvm::StringRef{SeparateErrors ? StderrPath : StdoutPath},
|
|
};
|
|
|
|
bool ExecutionFailed = false;
|
|
PI = llvm::sys::ExecuteNoWait(ExecPath, llvm::toStringRefArray(Argv.data()),
|
|
Envp, Redirects, /*memoryLimit*/ 0,
|
|
/*ErrMsg*/ nullptr, &ExecutionFailed);
|
|
return ExecutionFailed;
|
|
}
|
|
|
|
} // namespace sys
|
|
} // namespace swift
|